Fix tab grid crash when closing last incognito tab |
||||
Issue descriptionFix tab grid crash when closing last incognito tab. I would like to fix this sooner than later, but won't sacrifice the promised Q1 deliverables. Marked as medium, and may later downgrade to small.
,
Mar 22 2018
From discussion on hangouts, I suspect this is happening because TabGrid has a strong reference to TabModel. When the last incognito Tab is closed, the incognito BrowserState is destroyed, and TabModel -browserStateDestroyed is invoked. From that point, the TabModel should not be accessed. BVW should be dropping its reference at this point and expect that it will eventually be deallocated. So either TabGrid should have a __weak reference to TabModel or should not have a reference at all, but instead get the TabModel from BVW (directly or indirectly).
,
Mar 23 2018
CL is in-flight.
,
Mar 23 2018
,
Mar 27 2018
Issue verified Version: Chrome Canary 67.0.3382.0 Device: iPhone 6 Plus iOS: 11.2.6 There is no tab grid crash when closing last incognito tab. Not sure whether this is part of Proj-UIRefresh therefore tested with and without flag. No crash observed. https://drive.google.com/open?id=12rP3-fEtl8zWmxQl1x6fSujkpqYE_a07
,
Apr 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by edchin@chromium.org
, Mar 22 2018