New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822507 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 813699



Sign in to add a comment

Crostini setup flow

Project Member Reported by tbuck...@chromium.org, Mar 16 2018

Issue description

The user should be able to click an icon in the Launcher to set up Crostini. It will explain the features of Crostini and the storage costs. If the user proceeds, it will download the VM/container. At the end, it should drop the user into a Terminal.

More details in go/crostini.
 
Labels: Pri-1
Labels: Hotlist-Announce
Owner: nverne@chromium.org
Status: Assigned (was: Available)
I just went through the flow on 68.0.3403.0 canary, some feedback. I know most of these are in-progress, but just want to confirm.

1) We should show a linear indeterminate progress bar [1] until we're actually able to monitor download progress. It would be nice to describe the current step below the progress bar ("Downloading VM", "Downloading container", etc)
2) Dialog remains open over Terminal at the end of the flow. It should auto-close.
3) Terminal window has no icon in the Shelf.
4) Clicking Terminal icon in the Launcher does not add it to recently used list (at top of Launcher)

Lower priority:
5) Deleting "termina" VM via crosh makes Terminal icon unresponsive

[1] https://material.io/guidelines/components/progress-activity.html#progress-activity-types-of-indicators

Comment 4 by timloh@chromium.org, Apr 24 2018

(4) is on my plate, will look at it later in the week (unless someone else really wants to)

Comment 5 by nverne@chromium.org, Apr 24 2018

3. Should already be fixed. More changes are in flight to have the right icon displayed in the shelf.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0af0684b4b07adf61f8913b3c570f21c17f7d6e

commit a0af0684b4b07adf61f8913b3c570f21c17f7d6e
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Apr 26 04:44:38 2018

Supports the ContainerStartupFailedSignal.

Concierge client's long-running StartContainer method is terminated
by one of two signals: ContainerStarted or ContainerStartupFailed.
After this change, CrostiniManager can respond to the failures as well
as the successes.

Bug:  822507 
Change-Id: Ic86f8876d084029436a99a3e0500a306d7cea54c
Reviewed-on: https://chromium-review.googlesource.com/1026950
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553916}
[modify] https://crrev.com/a0af0684b4b07adf61f8913b3c570f21c17f7d6e/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/a0af0684b4b07adf61f8913b3c570f21c17f7d6e/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/a0af0684b4b07adf61f8913b3c570f21c17f7d6e/chromeos/dbus/concierge_client.cc
[modify] https://crrev.com/a0af0684b4b07adf61f8913b3c570f21c17f7d6e/chromeos/dbus/concierge_client.h
[modify] https://crrev.com/a0af0684b4b07adf61f8913b3c570f21c17f7d6e/chromeos/dbus/fake_concierge_client.cc
[modify] https://crrev.com/a0af0684b4b07adf61f8913b3c570f21c17f7d6e/chromeos/dbus/fake_concierge_client.h

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8383af35ac909317c134144c3c0d0a1809ecc7

commit 8a8383af35ac909317c134144c3c0d0a1809ecc7
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Apr 26 07:31:02 2018

Crostini installer view with progress messages.

The install progress now has feedback messages in the dialog.
The view also closes automatically on completion

Bug:  822507 
Change-Id: I962c9975a19fb322c611c9a02c5e2cc7ab21e06b
Reviewed-on: https://chromium-review.googlesource.com/1029559
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553944}
[modify] https://crrev.com/8a8383af35ac909317c134144c3c0d0a1809ecc7/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/8a8383af35ac909317c134144c3c0d0a1809ecc7/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc
[modify] https://crrev.com/8a8383af35ac909317c134144c3c0d0a1809ecc7/chrome/browser/ui/app_list/crostini/crostini_installer_view.h

Labels: ReleaseBlock-Dev
Labels: M-68
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e082f999c8b2e9e43b2220ff6b4481d1ccc12c74

commit e082f999c8b2e9e43b2220ff6b4481d1ccc12c74
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Apr 27 05:14:23 2018

Crosh extension icons section is png instead of webp

Bug:  822507 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieee1606155667561c88fc8360eeafb4067361e5d
Reviewed-on: https://chromium-review.googlesource.com/1032112
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554314}
[modify] https://crrev.com/e082f999c8b2e9e43b2220ff6b4481d1ccc12c74/chrome/browser/resources/chromeos/crosh_builtin/manifest.json

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/c7fc40e67404211c7f9a05ac1217a5316b24c180

commit c7fc40e67404211c7f9a05ac1217a5316b24c180
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Apr 27 05:47:22 2018

nassh: crostini-192 icon needs to be .png

.webp is not currently supported in Chrome for extension app icons.

BUG= chromium:822507 
TEST=manual testing

Change-Id: Iccf7bc274b928ffa4cd0052f6ae767f2bccc44e0
Reviewed-on: https://chromium-review.googlesource.com/1032032
Tested-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/75459a35079b89ed9309c3003cc31ce60127ea71/nassh/images/dev/crostini-192.webp
[add] https://crrev.com/c7fc40e67404211c7f9a05ac1217a5316b24c180/nassh/images/dev/crostini-192.png

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9403d32c2901a2d51c168272b100ac3dd20bc96a

commit 9403d32c2901a2d51c168272b100ac3dd20bc96a
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Apr 27 23:52:41 2018

The Termial App Item now has an Uninstall in its context menu.

This runs the uninstall flow for crostini, which now includes
stopping the concierge service then unloading the cros-termina
component.

Bug:  822507 
Change-Id: I31cc40a3ad6732a55ff3f9ae47468751d996c6cf
Reviewed-on: https://chromium-review.googlesource.com/1032353
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554567}
[modify] https://crrev.com/9403d32c2901a2d51c168272b100ac3dd20bc96a/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/9403d32c2901a2d51c168272b100ac3dd20bc96a/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/9403d32c2901a2d51c168272b100ac3dd20bc96a/chrome/browser/chromeos/crostini/crostini_remover.cc
[modify] https://crrev.com/9403d32c2901a2d51c168272b100ac3dd20bc96a/chrome/browser/chromeos/crostini/crostini_remover.h
[modify] https://crrev.com/9403d32c2901a2d51c168272b100ac3dd20bc96a/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc
[modify] https://crrev.com/9403d32c2901a2d51c168272b100ac3dd20bc96a/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.h
[modify] https://crrev.com/9403d32c2901a2d51c168272b100ac3dd20bc96a/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc

This has multiple CLs, is this fixed?
Project Member

Comment 15 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26965d853dbce55b1ec1053f46dac50b6ba278c9

commit 26965d853dbce55b1ec1053f46dac50b6ba278c9
Author: Nicholas Verne <nverne@chromium.org>
Date: Tue May 01 02:07:03 2018

Adds a crostini uninstall dialog.

This requires user confirmation,and shows an indefinite progress bar
while the uninstall takes place over about 3 seconds. CrostiniRemover now has a
callback, so we can know when to close the dialog.

Bug:  822507 
Change-Id: I6d60f40a81824c89c9b82dfde4deca7ead26e680
Reviewed-on: https://chromium-review.googlesource.com/1034472
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554971}
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/chromeos/crostini/crostini_remover.cc
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/chromeos/crostini/crostini_remover.h
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/ui/app_list/crostini/crostini_installer_view.cc
[add] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/ui/app_list/crostini/crostini_uninstaller_view.cc
[add] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/ui/app_list/crostini/crostini_uninstaller_view.h
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/26965d853dbce55b1ec1053f46dac50b6ba278c9/chrome/browser/ui/webui/settings/chromeos/crostini_handler.cc

Project Member

Comment 16 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe08d08c0bf64d5528805967b36701e491bbcc3

commit ffe08d08c0bf64d5528805967b36701e491bbcc3
Author: Nicholas Verne <nverne@chromium.org>
Date: Tue May 01 04:46:55 2018

Check the kCrostini feature before allowing UI.

This feature will be enabled from chrome_setup.cc for boards which have
vm capability.

Bug:  822507 
Change-Id: I78235a5bf3ab32ec3a36fca1c804f8c0bdc51b82
Reviewed-on: https://chromium-review.googlesource.com/1036863
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554997}
[modify] https://crrev.com/ffe08d08c0bf64d5528805967b36701e491bbcc3/chrome/browser/chromeos/crostini/crostini_util.cc

Project Member

Comment 17 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/22ec9246c639ed255bea8709a01ab8f2624e5b1d

commit 22ec9246c639ed255bea8709a01ab8f2624e5b1d
Author: Timothy Loh <timloh@chromium.org>
Date: Tue May 01 20:06:45 2018

libchromeos-use-flags: Add the kvm_host USE flag

BUG= chromium:822507 
TEST=Manually checked the flag was passed through

Change-Id: Ib588a5aa07effbcb160c844c12f84810b9da295b
Reviewed-on: https://chromium-review.googlesource.com/1036866
Commit-Ready: Timothy Loh <timloh@chromium.org>
Tested-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[rename] https://crrev.com/22ec9246c639ed255bea8709a01ab8f2624e5b1d/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r48.ebuild
[modify] https://crrev.com/22ec9246c639ed255bea8709a01ab8f2624e5b1d/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild

Project Member

Comment 18 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cbc4fbbb532479ca209b4e88d876ffb7fd0013cb

commit cbc4fbbb532479ca209b4e88d876ffb7fd0013cb
Author: Timothy Loh <timloh@chromium.org>
Date: Tue May 01 20:06:48 2018

login: Enable Crostini feature when kvm_host USE flag is set

We want to only enable Crostini on boards where we actually support VMs,
which the kvm_host USE flag specifies.

BUG= chromium:822507 
TEST=Manually checked the flag was passed through

Change-Id: I59710c5c664ac56b32568936d61260b9d0ae14c0
Reviewed-on: https://chromium-review.googlesource.com/1036865
Commit-Ready: Nicholas Verne <nverne@chromium.org>
Tested-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/cbc4fbbb532479ca209b4e88d876ffb7fd0013cb/login_manager/chrome_setup.cc

Status: Fixed (was: Assigned)
Cc: hannia@google.com ejcaruso@chromium.org chirantan@chromium.org
 Issue 703949  has been merged into this issue.
 Issue 703951  has been merged into this issue.
 Issue 703957  has been merged into this issue.
Labels: -Restrict-View-Google

Sign in to add a comment