When clicking a link in a Linux app (eg. Extension store in VS Code), the link should open in the native Chrome browser.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/f822074d0c43898c6393ba8816b10945cf6a3ae5 commit f822074d0c43898c6393ba8816b10945cf6a3ae5 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Apr 11 21:55:50 2018 Constants for D-Bus server for opening URLs with Chrome BUG= chromium:822496 TEST=Builds Change-Id: Ib023896cd604c8beab1b5669ef7b5a486e733db2 Reviewed-on: https://chromium-review.googlesource.com/999953 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/f822074d0c43898c6393ba8816b10945cf6a3ae5/dbus/service_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4204e85d87563d5d028182d7ec5c1f64697cc17c commit 4204e85d87563d5d028182d7ec5c1f64697cc17c Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Sat Apr 14 17:43:16 2018 Add ash D-Bus framework & service for opening URLs with Chrome This adds a small D-Bus service framework to ash and then adds an initial service that has one call "OpenUrl" which will then open a new tab in Chrome with that URL. This is intended to be used by Chrome OS clients that want to open a URL with Chrome; initial usage will be from VMs. Bug: 822496 Bug: 831333 Test: Verified with dbus-send that links open properly Change-Id: I648af624817cd387f30aba751c7f465e0dcc60e0 Reviewed-on: https://chromium-review.googlesource.com/998081 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550900} [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/BUILD.gn [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/DEPS [add] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/dbus/DEPS [add] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/dbus/ash_dbus_services.cc [add] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/dbus/ash_dbus_services.h [add] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/dbus/url_handler_service_provider.cc [add] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/dbus/url_handler_service_provider.h [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/new_window_controller.cc [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/new_window_controller.h [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/public/interfaces/new_window.mojom [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/shell.cc [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/ash/shell.h [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/chrome/browser/ui/ash/chrome_new_window_client.cc [modify] https://crrev.com/4204e85d87563d5d028182d7ec5c1f64697cc17c/chrome/browser/ui/ash/chrome_new_window_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26e00c44ee54f161eb59936baced6b089adc55b3 commit 26e00c44ee54f161eb59936baced6b089adc55b3 Author: Blake O'Hare <blakeo@chromium.org> Date: Mon Apr 16 06:49:06 2018 Revert "Add ash D-Bus framework & service for opening URLs with Chrome" This reverts commit 4204e85d87563d5d028182d7ec5c1f64697cc17c. Reason for revert: Multiple people are noticing the following fatal error on startup. It's preventing Chrome OS from starting (noticed on an Eve and a Cyan). Testing with and without this change indicates that this CL is the cause: [5643:5757:0416/141408.095095:ERROR:bus.cc(551)] Failed to get the ownership of org.chromium.UrlHandlerService: Connection ":1.102" is not allowed to own the service "org.chromium.UrlHandlerService" due to security policies in the configuration file [5643:5643:0416/141408.181175:FATAL:cros_dbus_service.cc(77)] Failed to own: org.chromium.UrlHandlerService Original change's description: > Add ash D-Bus framework & service for opening URLs with Chrome > > This adds a small D-Bus service framework to ash and then adds an > initial service that has one call "OpenUrl" which will then > open a new tab in Chrome with that URL. This is intended to be used by > Chrome OS clients that want to open a URL with Chrome; initial usage > will be from VMs. > > Bug: 822496 > Bug: 831333 > Test: Verified with dbus-send that links open properly > Change-Id: I648af624817cd387f30aba751c7f465e0dcc60e0 > Reviewed-on: https://chromium-review.googlesource.com/998081 > Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550900} TBR=derat@chromium.org,xiyuan@chromium.org,hashimoto@chromium.org,stevenjb@chromium.org,sky@chromium.org,jorgelo@chromium.org,benwells@chromium.org,mnissler@chromium.org,dominickn@chromium.org,jkardatzke@google.com,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822496 , 831333 Change-Id: Ie7ea0e469116c7b1968cf929c378d9bceaeb9e1d Reviewed-on: https://chromium-review.googlesource.com/1013799 Reviewed-by: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550944} [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/ash/BUILD.gn [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/ash/DEPS [delete] https://crrev.com/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd/ash/dbus/DEPS [delete] https://crrev.com/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd/ash/dbus/ash_dbus_services.cc [delete] https://crrev.com/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd/ash/dbus/ash_dbus_services.h [delete] https://crrev.com/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd/ash/dbus/url_handler_service_provider.cc [delete] https://crrev.com/9b98a25a5d7df1f1b2b1f40bf20294ede0f18dbd/ash/dbus/url_handler_service_provider.h [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/ash/new_window_controller.cc [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/ash/new_window_controller.h [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/ash/public/interfaces/new_window.mojom [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/ash/shell.cc [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/ash/shell.h [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/chrome/browser/ui/ash/chrome_new_window_client.cc [modify] https://crrev.com/26e00c44ee54f161eb59936baced6b089adc55b3/chrome/browser/ui/ash/chrome_new_window_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f108f0254bcf7f69e81fafa5592b266429e50197 commit f108f0254bcf7f69e81fafa5592b266429e50197 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Apr 17 17:52:35 2018 Reland: Add ash D-Bus framework & service for opening URLs with Chrome This adds a small D-Bus service framework to ash and then adds an initial service that has one call "OpenUrl" which will then open a new tab in Chrome with that URL. This is intended to be used by Chrome OS clients that want to open a URL with Chrome; initial usage will be from VMs. Relanding crrev.com/c/998081, fixed missing D-Bus .conf file TBR=stevenjb@chromium.org,dominickn@chromium.org,hashimoto@chromium.org,mkwst@chromium.org Bug: 822496 Bug: 831333 Test: Verified with dbus-send that links open properly Change-Id: I5e6d9c716ef6da88b184e8e05582825d9547946e Reviewed-on: https://chromium-review.googlesource.com/1014424 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551383} [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/BUILD.gn [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/DEPS [add] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/dbus/DEPS [add] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/dbus/ash_dbus_services.cc [add] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/dbus/ash_dbus_services.h [add] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/dbus/org.chromium.UrlHandlerService.conf [add] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/dbus/url_handler_service_provider.cc [add] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/dbus/url_handler_service_provider.h [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/new_window_controller.cc [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/new_window_controller.h [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/public/interfaces/new_window.mojom [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/shell.cc [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/ash/shell.h [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/chrome/browser/ui/ash/chrome_new_window_client.cc [modify] https://crrev.com/f108f0254bcf7f69e81fafa5592b266429e50197/chrome/browser/ui/ash/chrome_new_window_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a19b012a59a39b42682a105e2fff017fb1687931 commit a19b012a59a39b42682a105e2fff017fb1687931 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Thu Apr 19 08:13:13 2018 vm_tools: Added OpenUrl functionality to concierge and garcon This adds a gRPC call from Garcon to Concierge for requesting that it opens a URL with Chrome. It also adds the call from Concierge to the D-Bus server in Chrome which will handle the request and actually open the URL. BUG= chromium:822496 TEST=Verified with manual execution of garcon Change-Id: Ibdd9cfd183ca9ba09e28e0140cd51bb33faf9360 Reviewed-on: https://chromium-review.googlesource.com/1015768 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/proto/container_host.proto [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/garcon/host_notifier.h [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/garcon/main.cc [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/concierge/service.cc [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/concierge/container_listener_impl.h [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/concierge/container_listener_impl.cc [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/concierge/service.h [modify] https://crrev.com/a19b012a59a39b42682a105e2fff017fb1687931/vm_tools/garcon/host_notifier.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/7be0b8241c43db4f78356cf66c4c04c989aaa4f1 commit 7be0b8241c43db4f78356cf66c4c04c989aaa4f1 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Thu Apr 19 18:08:34 2018 Enable garcon handling of URLs in container This adds a script for sending URLs to Chrome over garcon which is then setup as the alternative handler for x-www-browser. It also creates a desktop file corresponding to that same type of execution which is used in some cases (such as GTK or xdg-open) for URL handling. BUG= chromium:822496 TEST=Verified commands/scripts behave as expected Change-Id: I7b8585c40b2d81d4ba6fe9fa957a55e303816249 Reviewed-on: https://chromium-review.googlesource.com/1017806 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> [add] https://crrev.com/7be0b8241c43db4f78356cf66c4c04c989aaa4f1/cros-garcon/prerm [add] https://crrev.com/7be0b8241c43db4f78356cf66c4c04c989aaa4f1/cros-garcon/garcon-url-handler [add] https://crrev.com/7be0b8241c43db4f78356cf66c4c04c989aaa4f1/cros-garcon/garcon_host_browser.desktop [modify] https://crrev.com/7be0b8241c43db4f78356cf66c4c04c989aaa4f1/cros-garcon/BUILD [add] https://crrev.com/7be0b8241c43db4f78356cf66c4c04c989aaa4f1/cros-garcon/postinst
Comment 1 by tbuck...@chromium.org
, Mar 16 2018