Some tryjobs have the wrong display labels. |
||
Issue descriptionTryjobs for INCREMENTAL/FULL/INFORMATIONAL display labels, will be treated by Legoland identically to production builds of the same type. This is incorrect. It happened because when first creating the TRYJOB_DISPLAY_LABEL concept, I focused on which build configs could be run as tryjobs without breaking the current build infrastructure.
,
Mar 16 2018
This causes further confusion, because it's impossible to distinguish tryjob versus production artifacts. That distinction is causing active problems for the fuzzing team and "amd64-generic-fuzzer".
,
Mar 16 2018
#2 Exactly! That should make your life easier. ;>
,
Mar 16 2018
Great, thanks!
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6792b856916a4391bae64a9494843fb8e0835078 commit 6792b856916a4391bae64a9494843fb8e0835078 Author: Don Garrett <dgarrett@google.com> Date: Tue Mar 20 23:08:23 2018 chromeos_config: incremental, full, informational use -tryjob. Builds with the display labels incremental, full, and informational run on normal waterfalls and should be displayed distinctly from tryjob equivalents to these builds. I mistakenly grouped them with tryjobs because they wouldn't confuse other parts of our build infrastructure if the configs were reused as-is. BUG= chromium:822491 TEST=chromeos_config_unittest Change-Id: Id7fd8287b417437d285b377f4c2761ff93ca497c Reviewed-on: https://chromium-review.googlesource.com/965392 Reviewed-by: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/6792b856916a4391bae64a9494843fb8e0835078/cbuildbot/config_dump.json [modify] https://crrev.com/6792b856916a4391bae64a9494843fb8e0835078/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/6792b856916a4391bae64a9494843fb8e0835078/lib/config_lib.py
,
Mar 20 2018
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d73f2399adb5c2decace29643e4da09545f313 commit a7d73f2399adb5c2decace29643e4da09545f313 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Mar 21 01:14:48 2018 Roll src/third_party/chromite/ b84994071..6792b8569 (1 commit) https://chromium.googlesource.com/chromiumos/chromite.git/+log/b84994071091..6792b856916a $ git log b84994071..6792b8569 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 dgarrett chromeos_config: incremental, full, informational use -tryjob. Created with: roll-dep src/third_party/chromite BUG= chromium:822491 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If98ccbaf2fcc549dd8892a259163e1f81dbcf762 Reviewed-on: https://chromium-review.googlesource.com/972164 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544608} [modify] https://crrev.com/a7d73f2399adb5c2decace29643e4da09545f313/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by jinjingl@chromium.org
, Mar 16 2018