New issue
Advanced search Search tips

Issue 822480 link

Starred by 2 users
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Oct 29
Cc:
bsheedy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Write automated test to cover closing Chrome while VR UI is visible

Project Member Reported by dougman@chromium.org, Mar 15 2018 
Chrome Version: 66.0.3359.30
OS: Android 8.1.0 on Pixel 2

The scenarios focus around having various VR elements presented while existing.
Using X, System Back Button, or Setting * button considered to be equivalent.

Basic cases
	VR Browsing close with page up.
	VR Browsing NTP up
	WebVr

Omnibox Keyboard
	Without results pane
	With results pane
	only results pane, hide keyboard

Mic
	Mic Recording
	Permissions dialog asking for Mic

native dialog
	Permission Dialogs
	Java Dialogs

Permission Indicators
Exit VR dialog
2D UI triggered Keyboard

Comment 1 by dougman@chromium.org, Mar 16 2018

Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)
Mentioned that you already started writing these tests.

Comment 2 by bsheedy@chromium.org, Mar 16 2018 

Working CL is at https://chromium-review.googlesource.com/c/chromium/src/+/965385, but it can't be committed until the root issue is fixed.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64dafe84babbc578ea60831c759f3935f2385b96

commit 64dafe84babbc578ea60831c759f3935f2385b96
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Mar 21 23:45:31 2018

Add VR regression test for 821443

Adds a test that exits the VR browser while JavaScript dialogs and
permission prompts are displayed and ensures that the browser does not
crash.

Bug:  822480 
Change-Id: Ie0f1f2be5575ecd0bd30cf12f83c51404d90c169
Reviewed-on: https://chromium-review.googlesource.com/965385
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544909}
[modify] https://crrev.com/64dafe84babbc578ea60831c759f3935f2385b96/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/64dafe84babbc578ea60831c759f3935f2385b96/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java
[modify] https://crrev.com/64dafe84babbc578ea60831c759f3935f2385b96/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java

Comment 4 by bsheedy@chromium.org, Oct 29

Status: Fixed (was: Assigned)
I think this has been fixed for a while.
►

Sign in to add a comment