New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822473 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 817973
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 703263



Sign in to add a comment

"LayerTreeHostTestEarlyDamageCheckStops.RunMultiThread_DelegatingRenderer" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 15 2018

Issue description

"LayerTreeHostTestEarlyDamageCheckStops.RunMultiThread_DelegatingRenderer" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhMYXllclRyZWVIb3N0VGVzdEVhcmx5RGFtYWdlQ2hlY2tTdG9wcy5SdW5NdWx0aVRocmVhZF9EZWxlZ2F0aW5nUmVuZGVyZXIM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 817973 .
 
Cc: boliu@chromium.org jamwalla@chromium.org
Cc: -jamwalla@chromium.org
Labels: -Sheriff-Chromium
Owner: jamwalla@chromium.org
Status: Assigned (was: Untriaged)
Submitting https://chromium-review.googlesource.com/c/chromium/src/+/965402
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2c5dcbc2e75493483e828a646e9b01a12dca0d4

commit e2c5dcbc2e75493483e828a646e9b01a12dca0d4
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Fri Mar 16 02:20:50 2018

Disable flaky DelegatingRenderer test

See  issue 822473 . I'm just following instructions.

TBR=kylechar@chromium.org


Bug:  822473 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: If3e84296be13d52bbe3a08b7f744bc785f629142
Reviewed-on: https://chromium-review.googlesource.com/965402
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543598}
[modify] https://crrev.com/e2c5dcbc2e75493483e828a646e9b01a12dca0d4/cc/test/layer_tree_test.h

Comment 4 by boliu@chromium.org, Mar 16 2018

mostly on linux tsan build this time, so probably some other timing issue

Comment 5 by danakj@chromium.org, Mar 27 2018

Uhoh, this CL turned off ~ 1/2 of the cc unit tests. We want to disable just one test not everything.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b114d47e107c0080f2848f5d25076e9430fccb5d

commit b114d47e107c0080f2848f5d25076e9430fccb5d
Author: danakj <danakj@chromium.org>
Date: Wed Mar 28 00:00:46 2018

Revert "Disable flaky DelegatingRenderer test"

This reverts commit e2c5dcbc2e75493483e828a646e9b01a12dca0d4.

Reason for revert: This disabled about half of cc_unittests.

Original change's description:
> Disable flaky DelegatingRenderer test
> 
> See  issue 822473 . I'm just following instructions.
> 
> TBR=kylechar@chromium.org
> 
> 
> Bug:  822473 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: If3e84296be13d52bbe3a08b7f744bc785f629142
> Reviewed-on: https://chromium-review.googlesource.com/965402
> Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543598}

TBR=crouleau@chromium.org,jamwalla@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  822473 
Change-Id: Ieb2858c6042d635202ac96a0674ee4ad22ae67b9
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/982755
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546323}
[modify] https://crrev.com/b114d47e107c0080f2848f5d25076e9430fccb5d/cc/test/layer_tree_test.h

Comment 7 by danakj@chromium.org, Mar 28 2018

Blocking: 703263

Comment 8 by danakj@chromium.org, Mar 28 2018

Mergedinto: 817973
Status: Duplicate (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b905ac3f67f31eb3d07da528c45dfb54fe469c4b

commit b905ac3f67f31eb3d07da528c45dfb54fe469c4b
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Mar 28 19:24:25 2018

Disable LayerTreeHostTestEarlyDamageCheckStops on all platforms

Flaky on linux_chromium_tsan_rel_ng, should be flaky everywhere else.

BUG= 822473 , 817973 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0fe8b29e74d763ec36f91bfcb7fa2c347006d125
Reviewed-on: https://chromium-review.googlesource.com/984348
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546561}
[modify] https://crrev.com/b905ac3f67f31eb3d07da528c45dfb54fe469c4b/cc/trees/layer_tree_host_unittest.cc

Sign in to add a comment