Any apps that would appear in a Linux desktop app list should also appear in the Chrome OS Launcher. The bridge should expose .desktop files to Chrome OS. There are some properties we can use to weed out unnecessary icons, such as NoDisplay [1]. [1] https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/2ebcd492badfe06e07d14788ee327db991cadfec commit 2ebcd492badfe06e07d14788ee327db991cadfec Author: Tim Zheng <timzheng@google.com> Date: Wed Apr 11 08:19:47 2018 Add D-Bus call to concierge for getting icons. BUG= chromium:822467 TEST=Log message from the container when concierge_client is called. Change-Id: I3e5894a29a01487236f8734bfe5c34ac0c6b252b Reviewed-on: https://chromium-review.googlesource.com/1000819 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/2ebcd492badfe06e07d14788ee327db991cadfec/dbus/vm_concierge/service.proto [modify] https://crrev.com/2ebcd492badfe06e07d14788ee327db991cadfec/dbus/vm_concierge/dbus-constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3 commit 90bc3cef69f5c3338c4d89a5696bc4b23ad588d3 Author: Tim Zheng <timzheng@google.com> Date: Tue Apr 17 22:47:10 2018 vm_tools: Get icon call to concierge and garcon. This change add the API and the plubming of the call to get application icons from the container. This change doesn't include the container implementation to actually get the icons. BUG= chromium:822467 TEST=Log message from the container when concierge_client is called. Change-Id: I8549a5c0e55331e0ca56b7bc4fe4b7855d5ebccf Reviewed-on: https://chromium-review.googlesource.com/1000816 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/concierge/service.cc [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/concierge/client.cc [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/garcon/service_impl.h [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/garcon/service_impl.cc [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/proto/container_guest.proto [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/concierge/service.h [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/concierge/virtual_machine.cc [modify] https://crrev.com/90bc3cef69f5c3338c4d89a5696bc4b23ad588d3/vm_tools/concierge/virtual_machine.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5f886f904ccc6e3471d2f39b4f73d0f4eb916a6c commit 5f886f904ccc6e3471d2f39b4f73d0f4eb916a6c Author: Tim Zheng <timzheng@google.com> Date: Wed Apr 18 09:08:13 2018 vm_tools: Get icon from the container. This change implement the lookup and fetch of application icons inside the Crostini container. BUG= chromium:822467 TEST=Manual test on device. Change-Id: Iade9fdfa8d55c3d9390db6d429715eacb1b8fcd5 Reviewed-on: https://chromium-review.googlesource.com/1011707 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [add] https://crrev.com/5f886f904ccc6e3471d2f39b4f73d0f4eb916a6c/vm_tools/garcon/icon_finder.h [modify] https://crrev.com/5f886f904ccc6e3471d2f39b4f73d0f4eb916a6c/vm_tools/garcon/service_impl.cc [modify] https://crrev.com/5f886f904ccc6e3471d2f39b4f73d0f4eb916a6c/vm_tools/guest.gypi [add] https://crrev.com/5f886f904ccc6e3471d2f39b4f73d0f4eb916a6c/vm_tools/garcon/icon_finder.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/45bd595fad7d0d69b3ff94a81319077e34f2846c commit 45bd595fad7d0d69b3ff94a81319077e34f2846c Author: Tim Zheng <timzheng@google.com> Date: Sat May 19 08:04:30 2018 Add garcon_icon_index_file_test to vm_tools tests. BUG= chromium:822467 TEST=Unit Tests. Change-Id: Ibe8f6fee48ba89d2b1a6036e2836e3be9fe3e4f4 Reviewed-on: https://chromium-review.googlesource.com/1058564 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/45bd595fad7d0d69b3ff94a81319077e34f2846c/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1eea2ab42f7327f3e5310521f1767437e2b807fb commit 1eea2ab42f7327f3e5310521f1767437e2b807fb Author: Stephen Barber <smbarber@chromium.org> Date: Sat May 19 19:30:30 2018 Revert "Add garcon_icon_index_file_test to vm_tools tests." This reverts commit 45bd595fad7d0d69b3ff94a81319077e34f2846c. Reason for revert: This needed a CQ-DEPEND=CL:1056359 to ensure it landed after the unittests were added Original change's description: > Add garcon_icon_index_file_test to vm_tools tests. > > BUG= chromium:822467 > TEST=Unit Tests. > > Change-Id: Ibe8f6fee48ba89d2b1a6036e2836e3be9fe3e4f4 > Reviewed-on: https://chromium-review.googlesource.com/1058564 > Commit-Ready: Tim Zheng <timzheng@chromium.org> > Tested-by: Tim Zheng <timzheng@chromium.org> > Reviewed-by: Stephen Barber <smbarber@chromium.org> Bug: chromium:822467 Change-Id: I5e55bdfcd723a038d29320b6214b6f55d3a31327 Reviewed-on: https://chromium-review.googlesource.com/1066995 Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Tim Zheng <timzheng@chromium.org> Commit-Queue: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/1eea2ab42f7327f3e5310521f1767437e2b807fb/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a617bfc5904a43de9d4ef169696e00539c76ce2e commit a617bfc5904a43de9d4ef169696e00539c76ce2e Author: Tim Zheng <timzheng@chromium.org> Date: Tue May 22 04:18:05 2018 vm_tools: Read index.theme files to look for icons. This change update the process of looking for Crostini app icons inside the container to read the index.theme files and use it to list all the possible sub directories. BUG= chromium:822467 TEST=unit tests Change-Id: Ic0b6b9e732c80df48c7b755c0e5af743b1ed5bc6 Reviewed-on: https://chromium-review.googlesource.com/1056359 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [add] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/icon_index_file_unittest.cc [modify] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/desktop_file.cc [modify] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/icon_finder.cc [modify] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/icon_finder.h [add] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/ini_parse_util.h [add] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/icon_index_file.cc [add] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/icon_index_file.h [modify] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/guest.gypi [add] https://crrev.com/a617bfc5904a43de9d4ef169696e00539c76ce2e/vm_tools/garcon/ini_parse_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4f4a20d962d977a52aea2566cc47bbdff9bc55ba commit 4f4a20d962d977a52aea2566cc47bbdff9bc55ba Author: Tim Zheng <timzheng@google.com> Date: Tue May 22 07:21:30 2018 Reland "Add garcon_icon_index_file_test to vm_tools tests." This is a reland of 45bd595fad7d0d69b3ff94a81319077e34f2846c CQ-DEPEND=CL:1056359 Original change's description: > Add garcon_icon_index_file_test to vm_tools tests. > > BUG= chromium:822467 > TEST=Unit Tests. > > Change-Id: Ibe8f6fee48ba89d2b1a6036e2836e3be9fe3e4f4 > Reviewed-on: https://chromium-review.googlesource.com/1058564 > Commit-Ready: Tim Zheng <timzheng@chromium.org> > Tested-by: Tim Zheng <timzheng@chromium.org> > Reviewed-by: Stephen Barber <smbarber@chromium.org> Bug: chromium:822467 Change-Id: I25046aae336f13888339dd2a4e276f1b569d3bcf Reviewed-on: https://chromium-review.googlesource.com/1067897 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/4f4a20d962d977a52aea2566cc47bbdff9bc55ba/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4ea90de421d798e913de400a37556124246056bf commit 4ea90de421d798e913de400a37556124246056bf Author: Tim Zheng <timzheng@google.com> Date: Wed May 23 01:45:44 2018 vm_tools: Add unit tests for icon_finder.cc. BUG= chromium:822467 TEST=unit tests Change-Id: Ie8a2150aca0ccf755d56c15364cc0acf6881cfaf Reviewed-on: https://chromium-review.googlesource.com/1064791 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/4ea90de421d798e913de400a37556124246056bf/vm_tools/guest.gypi [add] https://crrev.com/4ea90de421d798e913de400a37556124246056bf/vm_tools/garcon/icon_finder_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9ca418a9e8ce33f581b93fd4644f898b5b78f9ad commit 9ca418a9e8ce33f581b93fd4644f898b5b78f9ad Author: Tim Zheng <timzheng@google.com> Date: Wed May 23 08:25:46 2018 Add garcon_icon_finder_test to vm_tools tests. BUG= chromium:822467 TEST=Unit tests. CQ-DEPEND=CL:1064791 Change-Id: Ic85e20b353afcf65f7ca21af3068b5d279f85565 Reviewed-on: https://chromium-review.googlesource.com/1065066 Commit-Ready: Tim Zheng <timzheng@chromium.org> Tested-by: Tim Zheng <timzheng@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/9ca418a9e8ce33f581b93fd4644f898b5b78f9ad/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild
Comment 1 by tbuck...@chromium.org
, Mar 16 2018