Installation flow for .deb files |
|||||||||||||||
Issue descriptionCrostini users should be able to double-click a .deb file to trigger an installation flow. This will be needed for apps like VS Code and Atom that direct users to download .deb installers. If Crostini has not already been set up, we should kick-off the setup flow. The first screen of the setup flow may note that Crostini is needed to install this type of file.
,
May 9 2018
,
May 10 2018
,
May 18 2018
This needs 9p support for mounting files from Chrome OS to Crostini before it can be implemented.
,
May 25 2018
We were originally thinking we may be able to use something like gdebi with this and then just do an xdg-open on the .deb file, but gdebi doesn't seem to like passwordless sudo...gdebi also installs a .desktop file (which we could forcibly filter out). The problem with using 'sudo dpkg -i foo.deb' was that it doesn't install the dependencies...but we can easily correct that problem by running 'sudo apt-get install -f' afterwards. It's also possible to get machine parseable status output from both dpkg and from apt-get. dpkg will only give you textual status updates (i.e. no overall progress), but this does specifically include the error for when dependencies are not satisfied (which we would like to distinguish from other errors, as another type of dpkg failure which we may imply as a dependency failure would then lead us to running apt-get successfully and wrongly assume the install succeeded). apt-get gives you a nice percentage progress along with the text status updates. I'm proposing we handle this as follow: 1. Do the 9p mounting of the file (that's something totally separate from this bug, so no details on that here) 2. Run 'sudo dpkg -i foo.deb', send the machine parseable output to an fd (that's how it works) that we parse. Show a Chrome OS notification with an infinite progress bar and send back the status messages over gRPC->D-Bus (possibly to the vm_applications service, that seems logical) which then routes those into the notification.. 3. If we detect a dependency failure in dpkg and it exits, then run 'sudo apt-get install -f -y' and also send the machine parseable output to that same fd as before. The Chrome OS notification can then have a real progress bar, since apt-get gives percentage progress in there. It can also show textual updates on what's happening as well (but those will fly by). 4. When it's all complete we can update the notification with the overall success/failure message and let the user dismiss it when they want.
,
May 30 2018
Would drawing the status UI from inside the container help reduce complexity at all? Would it allow for an estimated progress instead of an infinite spinner?
,
May 30 2018
Doing the status from inside the container won't help with progress for when running 'dpkg'. It just doesn't give any type of numerical progress feedback....but if we end up doing apt-get, then we get numerical progress feedback.
,
May 31 2018
,
Jun 13 2018
,
Jun 21 2018
To keep this bug coherent...the plan has changed. Final strategy is to use the PackageKit daemon for this and we will communicate with that over D-Bus. It handles dependencies automatically and provides good progress information.
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/5b4e110778875b58be0b797e8685ddf3e001ef68 commit 5b4e110778875b58be0b797e8685ddf3e001ef68 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Jun 22 13:00:23 2018 Enable dbus in libchrome for termina D-Bus is used in new garcon code that communicates with PackageKit, so we need to add it to the libchrome build for termina. BUG= chromium:822464 TEST=Builds and base/dbus headers exist Change-Id: I4c6f711886ef3385f62526d723ea448e0a17f14c Reviewed-on: https://chromium-review.googlesource.com/1111097 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/5b4e110778875b58be0b797e8685ddf3e001ef68/project-termina/profiles/base/package.use
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/8f9ecbdae5ab6ea0cd1a97d49490bd2bde5a76be commit 8f9ecbdae5ab6ea0cd1a97d49490bd2bde5a76be Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Jun 22 17:13:38 2018 Add polkit rule for packagekit usage by garcon This adds a polkit rule to allow users in the sudo group to perform package installs and removals. Garcon will use this to interact with PackageKit over D-Bus to perform those operations. Bug: chromium:822464 Test: Verified on eve this allows the operations to succeed Change-Id: I8e156680aee99fcf862c636175ad870abb9a4399 Reviewed-on: https://chromium-review.googlesource.com/1111033 Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> [add] https://crrev.com/8f9ecbdae5ab6ea0cd1a97d49490bd2bde5a76be/cros-garcon/garcon-packagekit.pkla [modify] https://crrev.com/8f9ecbdae5ab6ea0cd1a97d49490bd2bde5a76be/cros-garcon/BUILD
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/00f3e404f8a3833d1605efd07f43a994a4d95670 commit 00f3e404f8a3833d1605efd07f43a994a4d95670 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Jun 26 09:55:44 2018 Add constants and protos for Debian package handling for cicerone This adds support for doing .deb installs and querying information about .deb files that will be residing in the container's filesystem. BUG= chromium:822464 TEST=Builds Change-Id: I19ecb65497a34932dd1e3b3b7ca6f835970578df Reviewed-on: https://chromium-review.googlesource.com/1111101 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/00f3e404f8a3833d1605efd07f43a994a4d95670/dbus/vm_cicerone/cicerone_service.proto [modify] https://crrev.com/00f3e404f8a3833d1605efd07f43a994a4d95670/dbus/vm_cicerone/dbus-constants.h
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f49e214ec84c926b9c04eff2fdfef7dd08366d91 commit f49e214ec84c926b9c04eff2fdfef7dd08366d91 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Jun 26 19:51:58 2018 vm_tools: garcon: Add installing of .deb package files This adds support to garcon for performing installation of .deb files that are located inside of the container's filesystem. This is done by making D-Bus calls to the PackageKit daemon. A gRPC request from the host initiates the action and upon successful startup gRPC calls are made back to the host regularly with progress/completion updates. I do plan to write a unit test for package_kit_proxy, but will do that later so I unblock others who are dependent upon this work. BUG= chromium:822464 TEST=Verified works manually on eve CQ-DEPEND=CL:1111097,CL:1111101 Change-Id: I1fca19dee133b678b61127a4e29cf7da9a7bf5c5 Reviewed-on: https://chromium-review.googlesource.com/1111262 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/proto/container_host.proto [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/garcon/host_notifier.h [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/garcon/main.cc [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/garcon/service_impl.h [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/garcon/service_impl.cc [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/proto/container_guest.proto [add] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/garcon/package_kit_proxy.cc [add] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/garcon/package_kit_proxy.h [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/garcon/host_notifier.cc [modify] https://crrev.com/f49e214ec84c926b9c04eff2fdfef7dd08366d91/vm_tools/guest.gypi
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/498f066c8e9ffeecac339edacfee21083c2b351e commit 498f066c8e9ffeecac339edacfee21083c2b351e Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Jun 26 19:51:59 2018 vm_tools: cicerone: Add support for Debian package installs This adds the D-Bus call for doing .deb file installs and then sends the gRPC command over to garcon to complete the operation inside the container. BUG= chromium:822464 TEST=Verified works on eve CQ-DEPEND=CL:1111262 Change-Id: I4d04ed9c882fe3c85e5fe3f42ff3e5c19392766e Reviewed-on: https://chromium-review.googlesource.com/1111319 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/498f066c8e9ffeecac339edacfee21083c2b351e/vm_tools/cicerone/container_listener_impl.cc [modify] https://crrev.com/498f066c8e9ffeecac339edacfee21083c2b351e/vm_tools/cicerone/service.cc [modify] https://crrev.com/498f066c8e9ffeecac339edacfee21083c2b351e/vm_tools/cicerone/service.h [modify] https://crrev.com/498f066c8e9ffeecac339edacfee21083c2b351e/vm_tools/cicerone/virtual_machine.h [modify] https://crrev.com/498f066c8e9ffeecac339edacfee21083c2b351e/vm_tools/cicerone/container_listener_impl.h [modify] https://crrev.com/498f066c8e9ffeecac339edacfee21083c2b351e/vm_tools/cicerone/virtual_machine.cc
,
Jun 28 2018
Tim, Everything for doing the installs is in there now...the stuff for querying package information should be landing soon (just waiting on CQ, but I know you don't need that yet. Reassigning to you for tracking completion of this at the UI level.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8e5253a35dc977147e8fa15642817847d0e84cc3 commit 8e5253a35dc977147e8fa15642817847d0e84cc3 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Jun 29 08:08:54 2018 vm_tools: garcon: Add querying of info for package file This adds support to garcon for querying information about a package file (e.g. .deb) in the container's filesystem. BUG= chromium:822464 TEST=Verified with cicerone_client on eve Change-Id: I8461d08c066fb432f760bcc8c3eec523f98df3d1 Reviewed-on: https://chromium-review.googlesource.com/1117307 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/8e5253a35dc977147e8fa15642817847d0e84cc3/vm_tools/garcon/package_kit_proxy.h [modify] https://crrev.com/8e5253a35dc977147e8fa15642817847d0e84cc3/vm_tools/proto/container_guest.proto [modify] https://crrev.com/8e5253a35dc977147e8fa15642817847d0e84cc3/vm_tools/garcon/service_impl.cc [modify] https://crrev.com/8e5253a35dc977147e8fa15642817847d0e84cc3/vm_tools/garcon/service_impl.h [modify] https://crrev.com/8e5253a35dc977147e8fa15642817847d0e84cc3/vm_tools/garcon/package_kit_proxy.cc
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c6fda47a5c1e4336eaeb7a9fe8771f9b2149a91a commit c6fda47a5c1e4336eaeb7a9fe8771f9b2149a91a Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Jun 29 08:08:55 2018 vm_tools: cicerone: Add querying of info for package file This adds support to cicerone for passing through requests to garcon for querying information on a package file (e.g. .deb file) in a container. The cicerone_client changes will be done in a later CL after the base CL for cicerone_client itself lands. BUG= chromium:822464 TEST=Verified with cicerone_client on eve CQ-DEPEND=CL:1117307 Change-Id: I26f32a252a72a4bba451fc124913bcaa70e33d76 Reviewed-on: https://chromium-review.googlesource.com/1117314 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/c6fda47a5c1e4336eaeb7a9fe8771f9b2149a91a/vm_tools/cicerone/service.cc [modify] https://crrev.com/c6fda47a5c1e4336eaeb7a9fe8771f9b2149a91a/vm_tools/cicerone/virtual_machine.cc [modify] https://crrev.com/c6fda47a5c1e4336eaeb7a9fe8771f9b2149a91a/vm_tools/cicerone/service.h [modify] https://crrev.com/c6fda47a5c1e4336eaeb7a9fe8771f9b2149a91a/vm_tools/cicerone/virtual_machine.h
,
Jul 2
Thanks Jeff!
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f0262750d61bf9042882c7b71aa1841089e729c1 commit f0262750d61bf9042882c7b71aa1841089e729c1 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Tue Jul 10 05:35:45 2018 vm_tools: cicerone: Update client for package install & info This add commands to the cicerone client for executing a package file install or for querying its information. BUG= chromium:822464 TEST=Verified package functions on eve via cmd line Change-Id: I481b4dd082511e887fdbf8675d9d4b379c5136da Reviewed-on: https://chromium-review.googlesource.com/1130220 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/f0262750d61bf9042882c7b71aa1841089e729c1/vm_tools/cicerone/client.cc
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d3c7a29a005efddfd38b4363fe3dc7c55e010a6b commit d3c7a29a005efddfd38b4363fe3dc7c55e010a6b Author: Timothy Loh <timloh@chromium.org> Date: Mon Jul 16 10:42:06 2018 vm_tools: Update dbus permissions for Cicerone Remove the crosvm permissions for calling into GetContainerAppIcon and LaunchContainerApplication as these are properly migrated on the Chrome side now, and add permissions for calling the new InstallLinuxPackage. BUG= chromium:822464 TEST=Manual Change-Id: I939650324f160f557cce6102f8d0b47e7b0882e3 Reviewed-on: https://chromium-review.googlesource.com/1122063 Commit-Ready: Timothy Loh <timloh@chromium.org> Tested-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/d3c7a29a005efddfd38b4363fe3dc7c55e010a6b/vm_tools/dbus/org.chromium.VmCicerone.conf
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49d5b2e464d0c4aea76074fa2b575ed65d0ca886 commit 49d5b2e464d0c4aea76074fa2b575ed65d0ca886 Author: Timothy Loh <timloh@chromium.org> Date: Tue Jul 17 05:32:34 2018 Add D-Bus and CrostiniManager logic for supporting package installation This CL adds support in the CiceroneClient for the InstallLinuxPackage function and the InstallLinuxPackageProgress signal. These are then exposed via the CrostiniManager as InstallLinuxPackage and an observer interface InstallLinuxPackageProgressObserver. This CL also tidies up the existing Cicerone D-Bus calls to use the default timeout instead of an infinite timeout. This will be followed up by a CL adding UI for these: https://chromium-review.googlesource.com/c/chromium/src/+/1126812 Bug: 822464 Change-Id: Ia293d8baa7f69c5417924c3492f54353bfeb352e Reviewed-on: https://chromium-review.googlesource.com/1126811 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575555} [modify] https://crrev.com/49d5b2e464d0c4aea76074fa2b575ed65d0ca886/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/49d5b2e464d0c4aea76074fa2b575ed65d0ca886/chrome/browser/chromeos/crostini/crostini_manager.h [modify] https://crrev.com/49d5b2e464d0c4aea76074fa2b575ed65d0ca886/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc [modify] https://crrev.com/49d5b2e464d0c4aea76074fa2b575ed65d0ca886/chromeos/dbus/cicerone_client.cc [modify] https://crrev.com/49d5b2e464d0c4aea76074fa2b575ed65d0ca886/chromeos/dbus/cicerone_client.h [modify] https://crrev.com/49d5b2e464d0c4aea76074fa2b575ed65d0ca886/chromeos/dbus/fake_cicerone_client.cc [modify] https://crrev.com/49d5b2e464d0c4aea76074fa2b575ed65d0ca886/chromeos/dbus/fake_cicerone_client.h
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8136e7a0b96ceb15b4698d985dc9bc408e582c9b commit 8136e7a0b96ceb15b4698d985dc9bc408e582c9b Author: Timothy Loh <timloh@chromium.org> Date: Thu Jul 19 04:11:45 2018 Support installing .deb files in the file manager This CL adds basic support for installing .deb files from within the file manager. An "Install with Linux (Beta)" task is added for .deb files, which will open a confirmation dialog when selected. A future CL will expand this dialog to retrieve and display detailed information about the package, such as name, version, and a description. For successfully started installations, progress will be displayed in a notification (similar to e.g. file downloads). This patch only adds the file handler to .deb files that are selected individually and already in the container. In a subsequent patch, we should expand this so we can show an appropriate error message when selecting multiple .deb files, or files outside the container. TBR=benwells Bug: 822464 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1cfb84491134e0911ad53a488a02a7479d78d299 Reviewed-on: https://chromium-review.googlesource.com/1126812 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#576364} [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/crostini/crostini_package_installer_notification.cc [add] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/crostini/crostini_package_installer_notification.h [add] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/crostini/crostini_package_installer_service.cc [add] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/crostini/crostini_package_installer_service.h [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/file_manager/crostini_file_tasks.cc [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/file_manager/path_util.cc [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/browser/chromeos/file_manager/path_util.h [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/common/extensions/api/file_manager_private.idl [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/common/extensions/api/file_manager_private_internal.idl [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/third_party/closure_compiler/externs/file_manager_private.js [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/css/file_manager.css [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/js/file_tasks.js [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/js/main_scripts.js [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js [add] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/foreground/js/ui/install_linux_package_dialog.js [modify] https://crrev.com/8136e7a0b96ceb15b4698d985dc9bc408e582c9b/ui/file_manager/file_manager/manifest.json
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4493016095aef28415784fd2ed2063106e678bd9 commit 4493016095aef28415784fd2ed2063106e678bd9 Author: Timothy Loh <timloh@chromium.org> Date: Thu Jul 19 06:25:35 2018 Update string in notification for Linux package installation success Bug: 822464 Change-Id: I61fa85818c016f1839e1f6875367da4f8fc25d06 Reviewed-on: https://chromium-review.googlesource.com/1143084 Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#576395} [modify] https://crrev.com/4493016095aef28415784fd2ed2063106e678bd9/chrome/app/chromeos_strings.grdp
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b1c272338a7ab1630a3e3121535520cf8e73dba commit 3b1c272338a7ab1630a3e3121535520cf8e73dba Author: Timothy Loh <timloh@chromium.org> Date: Mon Jul 23 01:36:27 2018 Use a proper icon for Crostini package install notifications This CL adds a vector icon for use in notifications for Linux packages. Using a vector icon allows this to get blue/red colours automatically to match the notification title color. Bug: 822464 Change-Id: Ie21f437b8c65aefb8d5be4732e864f826445d361 Reviewed-on: https://chromium-review.googlesource.com/1143046 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577100} [modify] https://crrev.com/3b1c272338a7ab1630a3e3121535520cf8e73dba/ash/message_center/message_center_controller.cc [modify] https://crrev.com/3b1c272338a7ab1630a3e3121535520cf8e73dba/ash/public/cpp/vector_icons/BUILD.gn [add] https://crrev.com/3b1c272338a7ab1630a3e3121535520cf8e73dba/ash/public/cpp/vector_icons/notification_linux.icon [modify] https://crrev.com/3b1c272338a7ab1630a3e3121535520cf8e73dba/chrome/browser/chromeos/crostini/crostini_package_installer_notification.cc
,
Jul 25
Requesting merge of the CL in comment #25, which is a small polish fix adding a more appropriate icon for a notification.
,
Jul 25
This bug requires manual review: There is .grd file changes and we are only 40 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
Hi, reviewing merge request. Has this been successfully tested on ToT, multiple devices? Thanks.
,
Jul 27
Me and nverne@ just tested this on our respective pixelbooks.
,
Jul 27
Issue 848120 has been merged into this issue.
,
Aug 1
,
Aug 8
cindyb@: Any update on this merge request Chrome Unboxed also happened to post a screenshot featuring the updated icon: https://chromeunboxed.com/news/chrome-os-linux-debian-packages-chromebook-crostini#jp-carousel-5662
,
Aug 9
Merge approved, M69.
,
Aug 13
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d3340c90841a0f931b815b6b6e7b76c81369826 commit 8d3340c90841a0f931b815b6b6e7b76c81369826 Author: Timothy Loh <timloh@chromium.org> Date: Thu Aug 16 01:26:50 2018 Use a proper icon for Crostini package install notifications This CL adds a vector icon for use in notifications for Linux packages. Using a vector icon allows this to get blue/red colours automatically to match the notification title color. Bug: 822464 Change-Id: Ie21f437b8c65aefb8d5be4732e864f826445d361 Reviewed-on: https://chromium-review.googlesource.com/1143046 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577100}(cherry picked from commit 3b1c272338a7ab1630a3e3121535520cf8e73dba) Reviewed-on: https://chromium-review.googlesource.com/1176921 Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#669} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/8d3340c90841a0f931b815b6b6e7b76c81369826/ash/message_center/message_center_controller.cc [modify] https://crrev.com/8d3340c90841a0f931b815b6b6e7b76c81369826/ash/public/cpp/vector_icons/BUILD.gn [add] https://crrev.com/8d3340c90841a0f931b815b6b6e7b76c81369826/ash/public/cpp/vector_icons/notification_linux.icon [modify] https://crrev.com/8d3340c90841a0f931b815b6b6e7b76c81369826/chrome/browser/chromeos/crostini/crostini_package_installer_notification.cc
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/69f307c0797e932930c87ffab9ea048c2abf60c9 commit 69f307c0797e932930c87ffab9ea048c2abf60c9 Author: Timothy Loh <timloh@chromium.org> Date: Mon Sep 10 08:13:21 2018 vm_tools: Add VmCicerone methods GetLinuxPackageInfo to whitelist User chronos can now call GetLinuxPackageInfo BUG= 822464 TEST=manual testing on device Change-Id: Ib241ba550e0ef6a6cd5c1693e92aa7a018057481 Reviewed-on: https://chromium-review.googlesource.com/1198667 Commit-Ready: Timothy Loh <timloh@chromium.org> Tested-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/69f307c0797e932930c87ffab9ea048c2abf60c9/vm_tools/dbus/org.chromium.VmCicerone.conf |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by tbuck...@chromium.org
, Mar 16 2018