New issue
Advanced search Search tips

Issue 822450 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ParallelDownloadTest.ResumptionLastSliceFinished" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 15 2018

Issue description

"ParallelDownloadTest.ResumptionLastSliceFinished" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBQYXJhbGxlbERvd25sb2FkVGVzdC5SZXN1bXB0aW9uTGFzdFNsaWNlRmluaXNoZWQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
[ RUN      ] ParallelDownloadTest.ResumptionLastSliceFinished
[773:791:0315/123625.032218:ERROR:network_service.cc(43)] Not implemented reached in std::unique_ptr<net::NetworkChangeNotifier> network::(anonymous namespace)::CreateNetworkChangeNotifierIfNeeded()

Components: Internals>Network
Cc: xingliu@chromium.org
Cc: qin...@chromium.org
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000002d8e56c base::debug::StackTrace::StackTrace()
#1 0x000002989062 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7fac406becb0 <unknown>
#3 0x7fac40786693 epoll_wait
#4 0x000002e4e2dd epoll_dispatch
#5 0x000002e4bdcc event_base_loop
#6 0x000002dad582 base::MessagePumpLibevent::Run()
#7 0x000002daa899 base::MessageLoop::Run()
#8 0x000002dcd3e9 base::RunLoop::Run()
#9 0x0000029a46c3 content::RunMessageLoop()
#10 0x0000029922c8 content::DownloadUpdatedObserver::WaitForEvent()
#11 0x00000054ae71 content::(anonymous namespace)::ParallelDownloadTest::RunResumptionTest()
#12 0x00000054b1bc content::ParallelDownloadTest_ResumptionLastSliceFinished_Test::RunTestOnMainThread()
#13 0x000002988dc2 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#14 0x0000029fc4e5 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#15 0x000002293d31 content::BrowserMainLoop::PreMainMessageLoopRun()
#16 0x0000026cdd15 content::StartupTaskRunner::RunAllTasksNow()
#17 0x0000022926ed content::BrowserMainLoop::CreateStartupTasks()
#18 0x000002296783 content::BrowserMainRunnerImpl::Initialize()
#19 0x0000029e15a0 ShellBrowserMain()
#20 0x0000029d737e content::ShellMainDelegate::RunProcess()
#21 0x0000021aac60 content::RunNamedProcessTypeMain()
#22 0x0000021abb9e content::ContentMainRunnerImpl::Run()
#23 0x0000042a4d44 service_manager::Main()
#24 0x0000015a44d4 content::ContentMain()
#25 0x00000298894f content::BrowserTestBase::SetUp()
#26 0x00000297e289 content::ContentBrowserTest::SetUp()
#27 0x0000011d5db1 testing::Test::Run()
#28 0x0000011d6980 testing::TestInfo::Run()
#29 0x0000011d6e67 testing::TestCase::Run()
#30 0x0000011e2337 testing::internal::UnitTestImpl::RunAllTests()
#31 0x0000011e1ebe testing::UnitTest::Run()
#32 0x0000029b9b42 base::TestSuite::Run()
#33 0x000002981e7a content::ContentTestLauncherDelegate::RunTestSuite()
#34 0x0000029a0c38 content::LaunchTests()
#35 0x000002981e40 main
#36 0x7fac406a9f45 __libc_start_main
#37 0x000000489cca _start
Cc: mmenke@chromium.org
The error is at the NOTIMPLEMENTED here: https://cs.chromium.org/chromium/src/services/network/network_service.cc?q=network_service.cc&sq=package:chromium&dr&l=43

so looks like CreateNetworkChangeNotifierIfNeeded() doesn't work if we're on ChromeOS and we don't have a network change notifier.
Labels: -Pri-1 Pri-2
Owner: xingliu@chromium.org
Status: Started (was: Untriaged)
Cc: dtrainor@chromium.org
Will disable soon, I'm also working on cl to fix the root cause.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc4d4da0ecae92c50f5aa503a21ba6498fec0d5

commit 0fc4d4da0ecae92c50f5aa503a21ba6498fec0d5
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Mar 16 17:18:58 2018

Disable a flaky ParallelDownloadTest on ChromeOS.

Disable ParallelDownloadTest.ResumptionLastSliceFinished because it's
flaky on ChromeOS.

TBR=dtrainor@chromium.org, qinmin@chromium.org

Bug:  822450 
Change-Id: I90d737a8397a453af90288d05c7dc6bd8eefe23f
Reviewed-on: https://chromium-review.googlesource.com/965569
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543742}
[modify] https://crrev.com/0fc4d4da0ecae92c50f5aa503a21ba6498fec0d5/content/browser/download/download_browsertest.cc

Labels: -Sheriff-Chromium
Removing Sheriff label since the test has been disabled.
This is caused by 822340, should have been fixed, will enable the test soon.
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce6c08ea4d654862e2acad26233d2988f273f99e

commit ce6c08ea4d654862e2acad26233d2988f273f99e
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Apr 06 20:50:49 2018

Enable ParallelDownloadTest.ResumptionLastSliceFinished

The flakiness issue of this test was fixed in crbug/822340, so the test
can be enabled now.

TBR=dtrainor@chromium.org, qinmin@chromium.org

Bug:  822450 
Change-Id: Ib2d2b185368475732623336c027d0c0140f49bd7
Reviewed-on: https://chromium-review.googlesource.com/1000022
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548920}
[modify] https://crrev.com/ce6c08ea4d654862e2acad26233d2988f273f99e/content/browser/download/download_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment