Issue metadata
Sign in to add a comment
|
Cannot drag file from Chrome Downloads bar to non-Chrome focused window
Reported by
jeffreyc...@gmail.com,
Mar 15 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.124 Safari/537.36 Steps to reproduce the problem: 1. Download any file 2. Focus an external application, say Finder, with Chrome downloads bar visible behind it 3. Drag download file from downloads bar to Finder window What is the expected behavior? Finder window should not lose focus, and file should be moved appropriately to current directory in Finder. What went wrong? Finder window loses focus, cannot move download file in one step. Workaround: Drag file from downloads bar, hover over Finder icon in dock, press space, hover cursor over Finder window (should be highlighted/outlined in blue), press space again, release. Did this work before? Yes Chrome version: 65.0.3325.124 Channel: beta OS Version: OS X 10.13.3 Flash Version: Prior to the change to the downloads bar it was working fine.
,
Mar 16 2018
,
Mar 16 2018
Able to reproduce the issue on mac 10.13.3 using chrome stable version #65.0.3325.162 and latest dev #66.0.3359.26 but the flag #mac-md-download-shelf is not present in latest canary #67.0.3371.0. Reverse Bisect Information: =========================== Good build: 67.0.3365.0 Bad Build : 67.0.3364.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/1cffa8f71564086c45cae117d9321ec52458c6be..405ee5e59e4e3a1f487a700d7e599f6570dfbede From the above change log suspecting below change Change-Id: Ia82c6a5c1f7e6444e2e482ae967266da3c1882ea Reviewed-on: https://chromium-review.googlesource.com/951924 sdy@ - Could you please check and merge the fix to M-65 if it is a valid candidate. Note: Adding stable blocker for M-65 as it is a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
Mar 16 2018
Will do, but this shouldn’t be RBS.
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37046981bdfd58a262a2b7f1295eab70c22f1331 commit 37046981bdfd58a262a2b7f1295eab70c22f1331 Author: Sidney San Martín <sdy@chromium.org> Date: Tue Mar 20 19:19:18 2018 Let an MD download shelf item be dragged without bringing its window to the front. Bug: 822416 Change-Id: Ic3331be8d13982075e06b11031e6cbe147c68927 Reviewed-on: https://chromium-review.googlesource.com/969950 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#544478} [modify] https://crrev.com/37046981bdfd58a262a2b7f1295eab70c22f1331/chrome/browser/ui/cocoa/download/md_download_item_view.mm
,
Mar 21 2018
Able to reproduce the issue on mac 10.13.3 using chrome build without fix. Verified the fix on Mac 10.13.3 using Chrome version #67.0.3377.0 as per the comment #0. Attaching screen cast for reference. Observed that finder window did not lose focus, and file moved appropriately to current directory in Finder. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Mar 21 2018
Thank you for verifying!
,
Mar 21 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
Approving merge to M66. Branch:3359
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c00cdf550211b9f014186365745cc5a46da03e24 commit c00cdf550211b9f014186365745cc5a46da03e24 Author: Sidney San Martín <sdy@chromium.org> Date: Sat Mar 24 00:08:17 2018 Let an MD download shelf item be dragged without bringing its window to the front. Bug: 822416 Change-Id: Ic3331be8d13982075e06b11031e6cbe147c68927 Reviewed-on: https://chromium-review.googlesource.com/969950 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#544478}(cherry picked from commit 37046981bdfd58a262a2b7f1295eab70c22f1331) Reviewed-on: https://chromium-review.googlesource.com/979172 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#412} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/c00cdf550211b9f014186365745cc5a46da03e24/chrome/browser/ui/cocoa/download/md_download_item_view.mm
,
Mar 28 2018
Tested this issue on Mac OS 10.13.3 on the build without fix 65.0.3325.162 and latest Beta 66.0.3359.66. Able to reproduce this issue on 65.0.3325.162 and the issue is fixed on the latest Beta 66.0.3359.66. On dragging a file from Download bar and dropping to Finder window, can observe that finder window did not lose focus, and the file is moved without any issues. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Jun 30 2018
This bug was reintroduced after setting #enable-google-branded-context-menu flag to enabled. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jeffreyc...@gmail.com
, Mar 15 2018