New issue
Advanced search Search tips

Issue 822413 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Conditionalizable (with strong validator) range request concurrent with other request may get range corrupted

Project Member Reported by morlovich@chromium.org, Mar 15 2018

Issue description

This is a variant on  issue 820599 ; but in the case where the response 
has a strong etag (or suitable )

Appropriate interactive testcase is the same as in that bug, but with 
function respondToFetch(req, res) {

modified to add:
    res.setHeader('ETag', 'foo');
 
Vote
Owner: morlovich@chromium.org
Status: Started (was: Available)
Giving this a shot..
Status: Fixed (was: Started)
https://chromium-review.googlesource.com/c/chromium/src/+/973918 should have fixed it; not sure why this didn't get CC'd.

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d19c827f4be7a6b81232f7a703921e82fe64f629

commit d19c827f4be7a6b81232f7a703921e82fe64f629
Author: Maks Orlovich <morlovich@chromium.org>
Date: Fri Mar 23 15:27:05 2018

HttpCache: Don't clip range to concurrent incomplete full fetch

In PartialData::UpdateFromStoredHeaders, the data stream size in cache
isn't a reliable notion of the total size of resource if we're still
fetching it. Use Content-Length, if available, for that instead.


Bug:  822413 
Change-Id: I36f09b6d72336385755cd4a1ea22da345b541d67
Reviewed-on: https://chromium-review.googlesource.com/973918
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545454}
[modify] https://crrev.com/d19c827f4be7a6b81232f7a703921e82fe64f629/net/http/http_cache_transaction.cc
[modify] https://crrev.com/d19c827f4be7a6b81232f7a703921e82fe64f629/net/http/http_cache_unittest.cc
[modify] https://crrev.com/d19c827f4be7a6b81232f7a703921e82fe64f629/net/http/partial_data.cc
[modify] https://crrev.com/d19c827f4be7a6b81232f7a703921e82fe64f629/net/http/partial_data.h

Sign in to add a comment