VR: Input is offset upon entering VR |
||||||||||||||||
Issue descriptionInput is offset by what looks like it might be the toolbar height until the controller is clicked or the page is scrolled.
,
Mar 23 2018
Michael: is this still reproable?
,
Apr 13 2018
I can still repro in Canary. The offset also goes away by moving the reticle off the content quad.
,
Apr 16 2018
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb commit 0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Apr 17 22:17:11 2018 Update top offset of motion events on hover in CompositorViewHolder When entering VR we hide the browser controls. However, it can take some time for this state update to reach the FullscreenManager. As a consequence, hover move events may have a false offset depending on whether the initial hover enter event was processed with the updated browser controls state or not. To fix that, also update the top offset for hover move events. Bug: 822384 Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864 Reviewed-on: https://chromium-review.googlesource.com/1014708 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551502} [modify] https://crrev.com/0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Apr 18 2018
,
Apr 19 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df23fc7dd6255cac7ea26120fde809482cad5964 commit df23fc7dd6255cac7ea26120fde809482cad5964 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Apr 19 14:29:10 2018 Update top offset of motion events on hover in CompositorViewHolder When entering VR we hide the browser controls. However, it can take some time for this state update to reach the FullscreenManager. As a consequence, hover move events may have a false offset depending on whether the initial hover enter event was processed with the updated browser controls state or not. To fix that, also update the top offset for hover move events. Bug: 822384 Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864 Reviewed-on: https://chromium-review.googlesource.com/1014708 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551502}(cherry picked from commit 0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb) Reviewed-on: https://chromium-review.googlesource.com/1019540 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#124} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/df23fc7dd6255cac7ea26120fde809482cad5964/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Apr 19 2018
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0758bac3975f7342a30f04e3cf24646db5670471 commit 0758bac3975f7342a30f04e3cf24646db5670471 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Thu Apr 19 21:06:07 2018 Revert "Update top offset of motion events on hover in CompositorViewHolder" This reverts commit df23fc7dd6255cac7ea26120fde809482cad5964. Reason for revert: Stutters scrolling in 2D Original change's description: > Update top offset of motion events on hover in CompositorViewHolder > > When entering VR we hide the browser controls. However, it can take some > time for this state update to reach the FullscreenManager. As a > consequence, hover move events may have a false offset depending on > whether the initial hover enter event was processed with the updated > browser controls state or not. To fix that, also update the top offset > for hover move events. > > Bug: 822384 > Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864 > Reviewed-on: https://chromium-review.googlesource.com/1014708 > Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#551502}(cherry picked from commit 0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb) > Reviewed-on: https://chromium-review.googlesource.com/1019540 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/branch-heads/3396@{#124} > Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} TBR=tiborg@chromium.org Change-Id: Id1206ea347d791453384934da4ebebd55d477c7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822384 Reviewed-on: https://chromium-review.googlesource.com/1019618 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#149} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/0758bac3975f7342a30f04e3cf24646db5670471/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Apr 19 2018
Change got reverted due to 2D scrolling issues.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfb8e5a85ff1b59d10b521690e5e080583bdfeeb commit dfb8e5a85ff1b59d10b521690e5e080583bdfeeb Author: Ned Nguyen <nednguyen@google.com> Date: Thu Apr 19 22:16:41 2018 Revert "Update top offset of motion events on hover in CompositorViewHolder" This reverts commit 0ef4af14dff5f447bc8746e7aa1634c3adcdd3bb. Reason for revert: break Telemetry tests BUG:834833 Original change's description: > Update top offset of motion events on hover in CompositorViewHolder > > When entering VR we hide the browser controls. However, it can take some > time for this state update to reach the FullscreenManager. As a > consequence, hover move events may have a false offset depending on > whether the initial hover enter event was processed with the updated > browser controls state or not. To fix that, also update the top offset > for hover move events. > > Bug: 822384 > Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864 > Reviewed-on: https://chromium-review.googlesource.com/1014708 > Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551502} TBR=mdjones@chromium.org,jinsukkim@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822384 Change-Id: Ibb0dd8b2fe110e9f7ecd7785604f956fede4bfd3 Reviewed-on: https://chromium-review.googlesource.com/1020240 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#552183} [modify] https://crrev.com/dfb8e5a85ff1b59d10b521690e5e080583bdfeeb/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Apr 23 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86440056a3ed001d5ef5e3dd9d64eca9ad8f4b99 commit 86440056a3ed001d5ef5e3dd9d64eca9ad8f4b99 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Wed Apr 25 15:39:19 2018 Update top offset of motion events on hover in CompositorViewHolder When entering VR we hide the browser controls. However, it can take some time for this state update to reach the FullscreenManager. As a consequence, hover move events may have a false offset depending on whether the initial hover enter event was processed with the updated browser controls state or not. To fix that, also update the top offset for hover move events. Bug: 822384 Change-Id: Idd46e2c45e20089f2ee6c701cae386b6ce931b5f Reviewed-on: https://chromium-review.googlesource.com/1024928 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553570} [modify] https://crrev.com/86440056a3ed001d5ef5e3dd9d64eca9ad8f4b99/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
Apr 27 2018
Second fix is in Canary and looks good.
,
Apr 27 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 1 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/121469e764f9573781002d691ad8ad6f12da1b4d commit 121469e764f9573781002d691ad8ad6f12da1b4d Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue May 01 21:19:19 2018 Update top offset of motion events on hover in CompositorViewHolder When entering VR we hide the browser controls. However, it can take some time for this state update to reach the FullscreenManager. As a consequence, hover move events may have a false offset depending on whether the initial hover enter event was processed with the updated browser controls state or not. To fix that, also update the top offset for hover move events. Bug: 822384 Change-Id: Idd46e2c45e20089f2ee6c701cae386b6ce931b5f Reviewed-on: https://chromium-review.googlesource.com/1024928 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#553570}(cherry picked from commit 86440056a3ed001d5ef5e3dd9d64eca9ad8f4b99) Reviewed-on: https://chromium-review.googlesource.com/1038463 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#429} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/121469e764f9573781002d691ad8ad6f12da1b4d/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
,
May 1 2018
,
May 3 2018
,
May 8 2018
Verified in build 67.0.3396.29 beta. Looks good. |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by mthiesse@chromium.org
, Mar 15 2018