New issue
Advanced search Search tips

Issue 822374 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VR Browsing] Chrome crashes while in VR on page https://jsfiddle.net/fsbhjy9t/1/

Project Member Reported by dbbrooks@chromium.org, Mar 15 2018

Issue description

Chrome Version: 66.0.3359.31
VRCore: 1.13.185188193
OS: Android N
Device: Galaxy S8+ 

What steps will reproduce the problem?

(1) Enable flags:
“Top document isolation”,
vr-browsing-native-android-ui,
vr-web-input-editing
(2) Go to https://jsfiddle.net/fsbhjy9t/1/
(3) Enter VR browsing

What is the expected result? No crash

What happens instead? crash 

Uploaded Crash Report ID 10698d7027d37828
Uploaded Crash Report ID a48b99662a05ca0b
 
Owner: mthiesse@chromium.org
Status: Started (was: Untriaged)
I'll investigate
Components: Internals>Sandbox>SiteIsolation
Fix here: https://chromium-review.googlesource.com/c/chromium/src/+/963680
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb8d3afd6628cbccdd26a15161d3a7125b598f3c

commit eb8d3afd6628cbccdd26a15161d3a7125b598f3c
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Mar 16 16:38:55 2018

Fix segfault in VR with Top Document Isolation on.

The touch selection controller may be null on Android for a few reasons,
one of which is that selection is disabled in VR currently.

Bug:  822374 
Change-Id: Ie19fc8a4b148f64dc0fda391a45e758940d39154
Reviewed-on: https://chromium-review.googlesource.com/963680
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543726}
[modify] https://crrev.com/eb8d3afd6628cbccdd26a15161d3a7125b598f3c/content/browser/renderer_host/input/touch_selection_controller_client_manager_android.cc
[modify] https://crrev.com/eb8d3afd6628cbccdd26a15161d3a7125b598f3c/content/public/browser/touch_selection_controller_client_manager.h

Status: Fixed (was: Started)

Sign in to add a comment