New issue
Advanced search Search tips

Issue 822340 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Mar 2018
Cc:
qin...@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Parallel-Download-Follow-Ups


Sign in to add a comment

Parallel download resumption won't complete if the first request close early.

Project Member Reported by xingliu@chromium.org, Mar 15 2018 
Chrome Version: 67.0.3371.0

For parallel download resumption, if the original request is closed early, and there is only one whole left. The ForkSubRequest logic will bail out in 
https://chromium.googlesource.com/chromium/src/+/67.0.3371.0/content/browser/download/parallel_download_job.cc#217
So the last slice will not be fetched.

This is due to a recent CL that we pop out a slice when the last downloaded slice is marked as finished, in
https://chromium.googlesource.com/chromium/src/+/67.0.3371.0/content/browser/download/parallel_download_job.cc#207

So since this assumption breaks, the code in ForkSubRequests needs to be adjusted.


If the user encounter this bug, one more resume should mitigate the problem.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd960ac6d32ba89d28596cd09155a2f56ed72986

commit dd960ac6d32ba89d28596cd09155a2f56ed72986
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Mar 19 21:30:05 2018

Parallel Download: Fix missing request in an edge case.

Previously we always send a request after the last received slice, this
may lead to an out of range request, and we fix this issue in
https://chromium.googlesource.com/chromium/src/+/cb75f08beac18e6a237bf605fc612362b346d6fc

However, when the orginal request is completed before creating parallel
requests, we may not send parallel requests correctly due to the
assumption of always sending a request after last slice.

This CL fixes this issue and adds test coverage for this edge case.


Bug:  822340 
Change-Id: Ibe459a642dc2f743075a5c9744ec1d9710446b05
Reviewed-on: https://chromium-review.googlesource.com/964992
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544165}
[modify] https://crrev.com/dd960ac6d32ba89d28596cd09155a2f56ed72986/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/dd960ac6d32ba89d28596cd09155a2f56ed72986/content/browser/download/parallel_download_job_unittest.cc

Comment 2 by xingliu@chromium.org, Mar 21 2018

Status: Fixed (was: Started)
►

Sign in to add a comment