New issue
Advanced search Search tips

Issue 822331 link

Starred by 1 user
Status: Fixed
Owner:
steimel@chromium.org
Closed: Mar 2018
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Modify keyboard controls for modern media controls

Project Member Reported by steimel@chromium.org, Mar 15 2018 
Two differences between keyboard controls for legacy vs modern:

1) On spacebar, legacy controls send click to the play button. However, on modern we typically only show the overlay play button, so we want to send the click event there when the play button isn't displayed.

2) On ArrowUp/Down, legacy controls increases/decreases the volume. However, on modern controls we don't display a volume slider, so that should be disabled
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23c90356346f45c4c60b041c5c4e9f1128490104

commit 23c90356346f45c4c60b041c5c4e9f1128490104
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Mar 20 18:05:28 2018

Fix keyboard controls for modern media controls

This CL fixes some issues with the keyboard controls on modern media
controls. It disables using the up/down arrows to change volume, since
the new controls don't have a volume slider. It also sends the play
click event to the overlay play button instead of the play button since
the play button isn't shown on modern.

Bug:  822331 
Change-Id: I8c030a946c7884e075648466ca60855c88f5da75
Reviewed-on: https://chromium-review.googlesource.com/965246
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544437}
[modify] https://crrev.com/23c90356346f45c4c60b041c5c4e9f1128490104/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/23c90356346f45c4c60b041c5c4e9f1128490104/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h

Comment 2 by steimel@chromium.org, Mar 20 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment