New issue
Advanced search Search tips

Issue 822326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

USE flag wifi_bootstrapping is unused

Project Member Reported by ejcaruso@chromium.org, Mar 15 2018

Issue description

This flag isn't present in any overlays and isn't set by any ebuilds with IUSE=+wifi_bootstrapping. We should be able to get rid of it and any code with is conditionally compiled based on it.
 
"equery-whirlwind u <package>" for several packages also shows that wifi_bootstrapping is unset so it's not like this is being picked up from somewhere else.
Cc: benchan@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0ebfb82b55b51393e6b58247b8a0ba120776f5f6

commit 0ebfb82b55b51393e6b58247b8a0ba120776f5f6
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Fri Mar 16 18:47:37 2018

autotest-tests: blacklist wifi_bootstrapping tests

These ebuilds can be deleted. Blacklist them so we can get rid of
them.

BUG= chromium:822326 
TEST=None

Change-Id: Ib0f6f2f837aca891a1d6fcc25dcb6001f71572bd
Reviewed-on: https://chromium-review.googlesource.com/966939
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/0ebfb82b55b51393e6b58247b8a0ba120776f5f6/chromeos-base/autotest-tests-wifi-bootstrapping/autotest-tests-wifi-bootstrapping-9999.ebuild
[modify] https://crrev.com/0ebfb82b55b51393e6b58247b8a0ba120776f5f6/chromeos-base/autotest-tests-wifi-bootstrapping/autotest-tests-wifi-bootstrapping-0.0.1-r2734.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/eef6fd2989096159c22bcbe8e423614b7138ae79

commit eef6fd2989096159c22bcbe8e423614b7138ae79
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Fri Mar 16 22:56:21 2018

buffet: remove refs to USE=wifi_bootstrapping

This USE flag is not set by any overlays, so any code that only
compiles under it is dead. Remove it from the set of variables
in common-mk and remove any files that use it as a condition or
code under #ifdef.

BUG= chromium:822326 
TEST=unit tests on whirlwind

Change-Id: I510be2eb8dc3fc097b521f2b4094169c0c5d60c3
Reviewed-on: https://chromium-review.googlesource.com/964709
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/eef6fd2989096159c22bcbe8e423614b7138ae79/buffet/shill_client.h
[delete] https://crrev.com/bc1d977253e400d8b0fc6690b5a134c62cbf01b3/buffet/webserv_client.cc
[delete] https://crrev.com/bc1d977253e400d8b0fc6690b5a134c62cbf01b3/buffet/peerd_client.h
[modify] https://crrev.com/eef6fd2989096159c22bcbe8e423614b7138ae79/buffet/buffet.gyp
[modify] https://crrev.com/eef6fd2989096159c22bcbe8e423614b7138ae79/buffet/manager.cc
[modify] https://crrev.com/eef6fd2989096159c22bcbe8e423614b7138ae79/buffet/manager.h
[modify] https://crrev.com/eef6fd2989096159c22bcbe8e423614b7138ae79/common-mk/common.gypi
[delete] https://crrev.com/bc1d977253e400d8b0fc6690b5a134c62cbf01b3/buffet/webserv_client.h
[delete] https://crrev.com/bc1d977253e400d8b0fc6690b5a134c62cbf01b3/buffet/ap_manager_client.cc
[delete] https://crrev.com/bc1d977253e400d8b0fc6690b5a134c62cbf01b3/buffet/ap_manager_client.h
[modify] https://crrev.com/eef6fd2989096159c22bcbe8e423614b7138ae79/buffet/shill_client.cc
[delete] https://crrev.com/bc1d977253e400d8b0fc6690b5a134c62cbf01b3/buffet/peerd_client.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6bef3ad6bea54863afb3df3b80956654647e9310

commit 6bef3ad6bea54863afb3df3b80956654647e9310
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Sat Mar 17 01:31:10 2018

autotest: delete wifi_boostrapping tests

This USE flag is never set, so dependencies are never built and
these tests are not expected to run.

CQ-DEPEND=CL:964587
BUG= chromium:822326 
TEST=emerge

Change-Id: I05c30d31335cee9e1c49a4b26eab61265e434c64
Reviewed-on: https://chromium-review.googlesource.com/964611
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/client/site_tests/apmanager_CheckAPProcesses/apmanager_CheckAPProcesses.py
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/server/site_tests/buffet_PrivetInfo/buffet_PrivetInfo.py
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/client/site_tests/apmanager_CheckAPProcesses/control
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/server/site_tests/buffet_WebServerSanity/control
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/server/site_tests/buffet_PrivetInfo/control
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/server/site_tests/buffet_PrivetSetupFlow/control
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/client/site_tests/platform_CheckWiFiBootstrappingProcesses/control
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/server/site_tests/buffet_PrivetSetupFlow/buffet_PrivetSetupFlow.py
[delete] https://crrev.com/65baa596302451cf379ddb1e9732456ec96a322c/server/site_tests/buffet_WebServerSanity/buffet_WebServerSanity.py

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9b6e682782354c90213cadba3fa8ce03eafa8303

commit 9b6e682782354c90213cadba3fa8ce03eafa8303
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Sat Mar 17 01:31:09 2018

chromiumos-overlay: remove refs to USE=wifi_bootstrapping

This USE flag is never set, so the ebuild segments that depend
on it are dead. Get rid of them so that it's more obvious which
packages are unused as well.

(Also change EAPI to 5 so the hooks stop complaining.)

CQ-DEPEND=CL:964611
BUG= chromium:822326 
TEST=build_packages --board=whirlwind

Change-Id: Ia491d2c61569744c6f141e72a1b9e35a9d5fd702
Reviewed-on: https://chromium-review.googlesource.com/964587
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9b6e682782354c90213cadba3fa8ce03eafa8303/chromeos-base/buffet/buffet-9999.ebuild
[modify] https://crrev.com/9b6e682782354c90213cadba3fa8ce03eafa8303/virtual/target-chromium-os/target-chromium-os-1.ebuild
[rename] https://crrev.com/9b6e682782354c90213cadba3fa8ce03eafa8303/virtual/target-chromium-os/target-chromium-os-1-r90.ebuild
[delete] https://crrev.com/8fef385c45083412398876ef5a75cf5337ae90a8/chromeos-base/autotest-tests-wifi-bootstrapping/autotest-tests-wifi-bootstrapping-0.0.1-r2734.ebuild
[rename] https://crrev.com/9b6e682782354c90213cadba3fa8ce03eafa8303/chromeos-base/autotest-all/autotest-all-0.0.1-r45.ebuild
[delete] https://crrev.com/8fef385c45083412398876ef5a75cf5337ae90a8/chromeos-base/autotest-tests-wifi-bootstrapping/autotest-tests-wifi-bootstrapping-9999.ebuild
[modify] https://crrev.com/9b6e682782354c90213cadba3fa8ce03eafa8303/chromeos-base/autotest-all/autotest-all-0.0.1.ebuild

Status: Fixed (was: Assigned)
Forgot to close this out.

Sign in to add a comment