New issue
Advanced search Search tips

Issue 822321 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Bootstrap GN error

Reported by juanka85...@gmail.com, Mar 15 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.146 Safari/537.36

Steps to reproduce the problem:
1. Extract tarball
2. Bootstrap GN
3. See fail

What is the expected behavior?
Bootstrap GN   and begin to build (rulefiles > chromium itself)

What went wrong?
https://p.teknik.io/g2hgc

Did this work before? N/A 

Chrome version: 66.0.3371.0  Channel: canary
OS Version: 66.0.3371.0
Flash Version: 

at 67.0.3370.0 worked fine
 
please edit it 

its 67.0.3371.0
 Issue 822436  has been merged into this issue.
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01ab4cc587e13c2f2cf944e100ca101191b8c1ae

commit 01ab4cc587e13c2f2cf944e100ca101191b8c1ae
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Mar 17 03:18:19 2018

Disable app shell installer when use_sysroot=false

This cl adds an additional condition of use_sysroot=true to enable the app shell
installer.  This matches the Linux condition [1].

This is needed to fix gn bootstrap for Chromium packagers, who build without the
sysroot.

[1] https://cs.chromium.org/chromium/src/chrome/installer/BUILD.gn

BUG= 822321 

Change-Id: Iae8ba0576525a51a3be91960deb939c760c80b86
Reviewed-on: https://chromium-review.googlesource.com/966967
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543928}
[modify] https://crrev.com/01ab4cc587e13c2f2cf944e100ca101191b8c1ae/extensions/shell/installer/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment