New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment
link

Issue 822317: Rename FeaturePolicy::Whitelist to "Allowlist"

Reported by cha...@chromium.org, Mar 15 2018 Project Member

Issue description

In the early stages the FP spec was updated to be more inclusive, namely by using "allowlist", instead of "whitelist".

The implementation code is still using the "whitelist" terminology:
https://cs.chromium.org/chromium/src/third_party/WebKit/public/common/feature_policy/feature_policy.h?l=116&gs=kythe%253A%252F%252Fchromium%253Flang%253Dc%25252B%25252B%253Fpath%253Dsrc%252Fthird_party%252FWebKit%252Fpublic%252Fcommon%252Ffeature_policy%252Ffeature_policy.h%2523o4dlK6rxHakJzW8Uk9D4iHJEg8U5cKs89WU%25252BArP1b9E%25253D&gsn=Whitelist&ct=xref_usages

The code should be updated to use the appropriate terminology, which also happens to match the spec more closely. This also applies to various comments throughout.
 

Comment 1 by bugdroid1@chromium.org, Mar 19 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6e0efb9aa41ed89ce46552aec46b3b93ad79798

commit f6e0efb9aa41ed89ce46552aec46b3b93ad79798
Author: Jason Chase <chasej@chromium.org>
Date: Mon Mar 19 02:22:21 2018

Add TODO to rename to FeaturePolicy::Allowlist

Add a TODO linking to the bug as a reminder, in case the rename makes
sense along with other changes.

Also updated all the comments in the file to use "allowlist".

Bug:  822317 
Change-Id: I9ac55077491be776a50cadc723bf3cac41c8ebaf
Reviewed-on: https://chromium-review.googlesource.com/964613
Commit-Queue: Jason Chase <chasej@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543962}
[modify] https://crrev.com/f6e0efb9aa41ed89ce46552aec46b3b93ad79798/third_party/WebKit/public/common/feature_policy/feature_policy.h

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4907629e9d2b1338fde9699b70f8f4d6b02e4800

commit 4907629e9d2b1338fde9699b70f8f4d6b02e4800
Author: qi1988.yang <qi1988.yang@samsung.com>
Date: Wed Mar 21 13:52:39 2018

Rename FeaturePolicy::Whitelist to "Allowlist"

Fix the TODO( crbug.com/822317 ): Rename to Allowlist

Bug:822317

Signed-off-by: qi1988.yang <qi1988.yang@samsung.com>
Change-Id: I1dd676fd5953b4cfc90e6b24d75ab9e3d69bc4da
Reviewed-on: https://chromium-review.googlesource.com/968043
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Commit-Queue: Philip J├Ągenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544685}
[modify] https://crrev.com/4907629e9d2b1338fde9699b70f8f4d6b02e4800/third_party/WebKit/Source/core/policy/Policy.cpp
[modify] https://crrev.com/4907629e9d2b1338fde9699b70f8f4d6b02e4800/third_party/WebKit/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/4907629e9d2b1338fde9699b70f8f4d6b02e4800/third_party/WebKit/public/common/feature_policy/feature_policy.h

Comment 4 by iclell...@chromium.org, Jul 12 2018

Status: Fixed (was: Available)

Sign in to add a comment