New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822310 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 826576
issue 920290

Blocking:
issue 850252



Sign in to add a comment

ANGLE Try servers having capacity problems with Mac testers

Project Member Reported by jmad...@chromium.org, Mar 15 2018

Issue description

This seems to be popping up moderately often right now:

https://ci.chromium.org/buildbot/tryserver.chromium.angle/mac_angle_rel_ng/

Example failures:

https://ci.chromium.org/buildbot/tryserver.chromium.angle/mac_angle_rel_ng/9063
https://ci.chromium.org/buildbot/tryserver.chromium.angle/mac_angle_rel_ng/9052

Maybe ANGLE needs to audit our tests set to reduce usage on these machines? Not sure how they are being provisioned right now.
 

Comment 1 by kbr@chromium.org, Mar 15 2018

Owner: jmad...@chromium.org
Status: Assigned (was: Untriaged)
We need to stop running tryjobs on the NVIDIA Mac Retinas. We don't have the capacity to do so.

In this file:

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/trybots.py?q=trybots.py&sq=package:chromium&dr&l=218

The block for "Mac FYI Retina Release (NVIDIA)" needs to be removed.

Jamie, could you please make this change? I can review it.

Sure, I can do that. Sorry I haven't gotten to it right away. This is temporary, right? We probably do want to have some coverage that ANGLE CLs don't break this configuration at some point.

Comment 3 by kbr@chromium.org, Mar 16 2018

We might be able to undo this after the LUCI cutover. Right now we are running 50% duplicate tryjobs. However we have only a small number of these machines and we have no ability to get any more. I think the best we can do in the long run is to have them on the waterfall and have a manually-triggerable trybot for them.

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/926645a389c7db8d81f80f38140ac502dda2f0df

commit 926645a389c7db8d81f80f38140ac502dda2f0df
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Mar 21 00:28:04 2018

Disable Mac Retina testing on ANGLE.

This is a temporary fix to the capacity problems we're having during
the LUCI migration. We might need to reduce the number of ANGLE tests
we're running on these bots even after we have full capacity again.

Bug: 822310
Change-Id: I8660abd18dec4b67bfa67180702879d870cada49
Reviewed-on: https://chromium-review.googlesource.com/968982
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/926645a389c7db8d81f80f38140ac502dda2f0df/scripts/slave/recipe_modules/chromium_tests/trybots.py

Comment 5 by kbr@chromium.org, Mar 28 2018

Blockedon: 826576
Ken, is it possible to configure ANGLE try bots differently than GPU.FYI with the LUCI cutover? I'm thinking we only need to run a few select tests on this configuration to get effective coverage, rather than the full set we see on the FYI bots.

Comment 7 by kbr@chromium.org, Mar 29 2018

We can do that independently of the LUCI cutover. Namely, we can invent a fake new bot name like "ANGLE Mac NVIDIA Tryserver", define which tests we want on it in generate_buildbot_json.py, and have mac_angle_rel_ng mirror it. We need to hook it up in the same way as the Optional trybots; specifically, it will have to have no-op triggers in https://cs.chromium.org/chromium/src/infra/config/global/luci-scheduler.cfg?sq=package:chromium&dr .

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/d1a55e393e65601ba26e2d76bd46a12fc6bc4e3e

commit d1a55e393e65601ba26e2d76bd46a12fc6bc4e3e
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Nov 14 00:31:47 2018

Expand dEQP-GLES3 suppressions.

These were missing a few suppressions for prior bugs. Going to run this
config on the CQ.

Bug: chromium:822310
Change-Id: I758d8823ff8b1ab347212426d73c6dad1bb6de39
Reviewed-on: https://chromium-review.googlesource.com/c/1334431
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/d1a55e393e65601ba26e2d76bd46a12fc6bc4e3e/src/tests/deqp_support/deqp_gles3_test_expectations.txt

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36d98fc346b8506fb91139149e605c6d7b57bc80

commit 36d98fc346b8506fb91139149e605c6d7b57bc80
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Nov 14 02:15:20 2018

Roll src/third_party/angle f9143725470b..d1a55e393e65 (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/f9143725470b..d1a55e393e65


git log f9143725470b..d1a55e393e65 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 jmadill@chromium.org Expand dEQP-GLES3 suppressions.


Created with:
  gclient setdep -r src/third_party/angle@d1a55e393e65

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:822310
TBR=cwallez@chromium.org

Change-Id: I707d1a122db30dcf53255adc0ee1a749552ffe02
Reviewed-on: https://chromium-review.googlesource.com/c/1334570
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607862}
[modify] https://crrev.com/36d98fc346b8506fb91139149e605c6d7b57bc80/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc7feeb83edb6af8595b39ad8d473fad3dfab0a1

commit dc7feeb83edb6af8595b39ad8d473fad3dfab0a1
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Nov 14 04:54:56 2018

testing/buildbot: Add fake Win ANGLE try bots.

These bots will be used to trigger tests on the ANGLE CQ.
Mirrors the design used in the existing files and in
http://crrev.com/c/1326157 .

Only tackles Windows for now. Will be extended to other platforms.

Also adds a few NVIDIA dEQP tests and cleans up some ANGLE test naming.

Bug: 822310
Change-Id: I5638bdc8588bdf3a4716fd45380ad25cc35ee121
Reviewed-on: https://chromium-review.googlesource.com/c/1333995
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607911}
[modify] https://crrev.com/dc7feeb83edb6af8595b39ad8d473fad3dfab0a1/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/dc7feeb83edb6af8595b39ad8d473fad3dfab0a1/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/dc7feeb83edb6af8595b39ad8d473fad3dfab0a1/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/dc7feeb83edb6af8595b39ad8d473fad3dfab0a1/testing/buildbot/waterfalls.pyl

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e5e6935a8aced1fb52f8d8eb7d0cd3567e6f1d

commit 98e5e6935a8aced1fb52f8d8eb7d0cd3567e6f1d
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Nov 27 23:26:51 2018

Add ANGLE GPU config to luci configs.

This adds a win-angle-rel try config to cr-buildbucket.cfg. It
also adds dummy no-op builders to luci-scheduler.cfg. This will
allow ANGLE to define a set of test distinct from the set of
tests run on the GPU FYI bots.

Bug: 822310
Change-Id: Ie42166d35ab01ddcce8d0ad637e02ba10629917d
Reviewed-on: https://chromium-review.googlesource.com/c/1341216
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611408}
[modify] https://crrev.com/98e5e6935a8aced1fb52f8d8eb7d0cd3567e6f1d/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/98e5e6935a8aced1fb52f8d8eb7d0cd3567e6f1d/infra/config/global/luci-scheduler.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/90a680399e0cd08af6d222ca4e79436905347960

commit 90a680399e0cd08af6d222ca4e79436905347960
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Nov 29 19:48:46 2018

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/89770722800698777ce1cd7923e7d9b75ee16069

commit 89770722800698777ce1cd7923e7d9b75ee16069
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Nov 29 19:59:24 2018

Make win-angle-rel mirror fake ANGLE Windows bots.

Modeled after http://crrev.com/c/1335800 . Will allow ANGLE to
specify different sets of tests than the GPU.FYI waterfall.

Bug: 822310
Change-Id: Ic7ab7fc50e86ee7c3a2844f82444193315c882d5
Reviewed-on: https://chromium-review.googlesource.com/c/1355442
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/89770722800698777ce1cd7923e7d9b75ee16069/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/89770722800698777ce1cd7923e7d9b75ee16069/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/68eddf4e3e1f29d39a3c406fc198dc9fdf51d74b

commit 68eddf4e3e1f29d39a3c406fc198dc9fdf51d74b
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Nov 29 22:41:36 2018

Revert "Make win-angle-rel mirror fake ANGLE Windows bots."

This reverts commit 89770722800698777ce1cd7923e7d9b75ee16069.

Reason for revert: Causes failures on the ANGLE CQ.
The fake bots are trying to build dEQP tests. This is invalid because
dEQP was split off into a separate builder and tester. Reverting to
fix the CQ.

See https://www.google.com/url?q=https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_angle_rel_ng/4387&sa=D&source=hangouts&ust=1543617570453000&usg=AFQjCNG6btu1UZFMG5o2VcSxSinYcacDJA

Original change's description:
> Make win-angle-rel mirror fake ANGLE Windows bots.
> 
> Modeled after http://crrev.com/c/1335800 . Will allow ANGLE to
> specify different sets of tests than the GPU.FYI waterfall.
> 
> Bug: 822310
> Change-Id: Ic7ab7fc50e86ee7c3a2844f82444193315c882d5
> Reviewed-on: https://chromium-review.googlesource.com/c/1355442
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=jmadill@chromium.org,kbr@chromium.org

Change-Id: I70ca3b41d61f7a795e24aa0215f6141ad6958066
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 822310
Reviewed-on: https://chromium-review.googlesource.com/c/1355710
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/68eddf4e3e1f29d39a3c406fc198dc9fdf51d74b/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/68eddf4e3e1f29d39a3c406fc198dc9fdf51d74b/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d260cfb598ff3477ea5c746e11f30790f5acd00d

commit d260cfb598ff3477ea5c746e11f30790f5acd00d
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Nov 30 22:09:19 2018

Remove dEQP tests from ANGLE fake builders.

The dEQP test suites need to be run on specific dEQP buidlers
and testers. Trying to build dEQP on these configs was breaking
the ANGLE CQ when the testers were enabled. After this change
the configs can be re-added to the tools/build repo.

Bug: 822310
Change-Id: I7dae7799948819004640f14379839c425f8a8280
Reviewed-on: https://chromium-review.googlesource.com/c/1357002
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612811}
[modify] https://crrev.com/d260cfb598ff3477ea5c746e11f30790f5acd00d/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/d260cfb598ff3477ea5c746e11f30790f5acd00d/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/d260cfb598ff3477ea5c746e11f30790f5acd00d/testing/buildbot/waterfalls.pyl

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/234114325f743370debebbd2bb9249f7c9a6a2ba

commit 234114325f743370debebbd2bb9249f7c9a6a2ba
Author: Jamie Madill <jmadill@chromium.org>
Date: Mon Dec 03 22:42:06 2018

Reland "Make win-angle-rel mirror fake ANGLE Windows bots."

This is a reland of 89770722800698777ce1cd7923e7d9b75ee16069

I removed dEQP from the ANGLE src-side tests so this should be
safe to land now. Previously it was causing build errors on
the ANGLE CQ because of missing dEQP dependencies.

Original change's description:
> Make win-angle-rel mirror fake ANGLE Windows bots.
>
> Modeled after http://crrev.com/c/1335800 . Will allow ANGLE to
> specify different sets of tests than the GPU.FYI waterfall.
>
> Bug: 822310
> Change-Id: Ic7ab7fc50e86ee7c3a2844f82444193315c882d5
> Reviewed-on: https://chromium-review.googlesource.com/c/1355442
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: 822310
Change-Id: Ie141e30211b0a626da7d284ef2f6e9a56565bdac
Reviewed-on: https://chromium-review.googlesource.com/c/1358532
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/234114325f743370debebbd2bb9249f7c9a6a2ba/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/234114325f743370debebbd2bb9249f7c9a6a2ba/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8ea53adf380fc06d664f4d940789d251d5cf40

commit 2e8ea53adf380fc06d664f4d940789d251d5cf40
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Dec 04 00:30:17 2018

mb_config.pyl: Add win-angle-rel

Bug: 822310
Change-Id: I08253e03f7a7e954b129d7650ca30efcca5fc9cb
Reviewed-on: https://chromium-review.googlesource.com/c/1355603
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613350}
[modify] https://crrev.com/2e8ea53adf380fc06d664f4d940789d251d5cf40/tools/mb/mb_config.pyl

Blocking: 850252
Since this bug involves some changes and refactorings to the GPU test suites, let me link it to the umbrella cleanup bug for those test suites.

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7130d9929aeeba477b9050a307197404605f28c9

commit 7130d9929aeeba477b9050a307197404605f28c9
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Jan 08 14:26:58 2019

Update win-angle-rel tests.

With this change, win-angle-rel is the same as win_angle_rel_ng
except for the removal of the following test suites:

* context_lost_tests
* dawn_end2end_tests
* depth_capture_tests
* gl_unittests
* gpu_process_launch_tests
* hardware_accelerated_feature_tests
* maps_pixel_test
* pixel_test
* screenshot_sync_tests
* tab_capture_end2end_tests
* trace_test
* xr_browser_tests

It also updates some versions of tests to be more explicitly named.
For instance 'webgl_conformance_tests' becomes
'webgl_conformance_d3d11_validating_tests'.

Bug: 822310
No-Try: true
Change-Id: Iea4fda2040febb2ab12a4017e7c4fc9f729892eb
Reviewed-on: https://chromium-review.googlesource.com/c/1398562
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620708}
[modify] https://crrev.com/7130d9929aeeba477b9050a307197404605f28c9/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/7130d9929aeeba477b9050a307197404605f28c9/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/7130d9929aeeba477b9050a307197404605f28c9/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/7130d9929aeeba477b9050a307197404605f28c9/testing/buildbot/waterfalls.pyl

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/988d9a068976cd893eb1cd1093299b166b58594a

commit 988d9a068976cd893eb1cd1093299b166b58594a
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Jan 08 18:57:02 2019

Use win-angle-rel on the ANGLE CQ.

The new test suite doesn't run several Chromium tests.
See https://crrev.com/c/1398562 for reference.

Also sorts the CQ testers alphabetically.

Bug: chromium:822310 
Change-Id: I5f4006e6f027a4666e9ccc5e5bcf981b3b979429
Reviewed-on: https://chromium-review.googlesource.com/c/1400861
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/988d9a068976cd893eb1cd1093299b166b58594a/infra/config/branch/cq.cfg

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4051d5cf954b31efdfb0d760cb839ccdd3c6ca0

commit c4051d5cf954b31efdfb0d760cb839ccdd3c6ca0
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 08 21:15:36 2019

Roll src/third_party/angle 6344d8ea30d7..988d9a068976 (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/6344d8ea30d7..988d9a068976


git log 6344d8ea30d7..988d9a068976 --date=short --no-merges --format='%ad %ae %s'
2019-01-08 jmadill@chromium.org Use win-angle-rel on the ANGLE CQ.


Created with:
  gclient setdep -r src/third_party/angle@988d9a068976

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:822310
TBR=ynovikov@chromium.org

Change-Id: Ia5278ac05900fb91935d692ca30a3053725c117f
Reviewed-on: https://chromium-review.googlesource.com/c/1401245
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#620878}
[modify] https://crrev.com/c4051d5cf954b31efdfb0d760cb839ccdd3c6ca0/DEPS

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f71bf71130fa81ffc980474c8c8b7d88c41fc553

commit f71bf71130fa81ffc980474c8c8b7d88c41fc553
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Jan 09 14:41:21 2019

Update GPU testing docs on machine allocation.

The new machine provider APIs require new steps.

Bug: 822310
Change-Id: I4677328ceaee9532c3557fed1db1bff163ebdbf3
Reviewed-on: https://chromium-review.googlesource.com/c/1395947
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621139}
[modify] https://crrev.com/f71bf71130fa81ffc980474c8c8b7d88c41fc553/docs/gpu/gpu_testing_bot_details.md

Blockedon: 920290
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec61344b0d198971e227f31a8cb1e317bdbf4d84

commit ec61344b0d198971e227f31a8cb1e317bdbf4d84
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Jan 10 01:20:28 2019

Transition win_angle_rel_ng to win-angle-rel.

This completes the src-side transition. It adds win-angle-rel to
the Milo config and removes other occurrences of win_angle_rel_ng.

One use of win_angle_rel_ng remains in third_party/pyjson5. This
file seems unmaintained so it seemed better to leave it.

Bug: 822310
Change-Id: If313f317dfad943dd03baf3252f8d55e41f515a6
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1403348
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621406}
[modify] https://crrev.com/ec61344b0d198971e227f31a8cb1e317bdbf4d84/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/ec61344b0d198971e227f31a8cb1e317bdbf4d84/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/ec61344b0d198971e227f31a8cb1e317bdbf4d84/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/ec61344b0d198971e227f31a8cb1e317bdbf4d84/tools/mb/mb_config.pyl
[modify] https://crrev.com/ec61344b0d198971e227f31a8cb1e317bdbf4d84/tools/roll_webgl_conformance.py

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5d43995b5e55047235c1b9962bb5f3e9cf968955

commit 5d43995b5e55047235c1b9962bb5f3e9cf968955
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Jan 10 20:38:44 2019

Remove win_angle_rel_ng.

This config is superseded by win-angle-rel.

Bug: 822310
Change-Id: I59aa4b08d1ac298413f32b69a5dbf8fa4475eb56
Reviewed-on: https://chromium-review.googlesource.com/c/1405291
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/5d43995b5e55047235c1b9962bb5f3e9cf968955/scripts/slave/recipe_modules/chromium_tests/trybots.py

Sign in to add a comment