This is a nice-to-have for the MVP release, so if it's possible it'd be nice to get it done, but not a big deal if we don't manage.

Also, if we're changing "Add to Home screen" to "Add shortcut" on mobile I think we should do it via Finch and be careful to understand the impact either positively or negatively.

Do we have to do it at the same time on mobile as on desktop?

On Desktop, this is something we can just do now without much hesitation I think. On Mobile there has been a lot more consternation about this string and its effect on the install rate, so I think we have to make it more carefully.

+dominickn

Let's just unrestrict so it's public record. (Having a go/ link is not grounds for censoring a bug.)

I'd prefer not tying mobile and desktop together here. Like #3 mentions, the exact string on mobile has been the cause of some angst, and we and Apple have established "Add to Home screen" as the well-known, identifiable string for quite some time now (Apple possibly since the first release of iOS).

I'm having some doubts about this having implemented it and seeing it in context.

Now that I read it in context, I noticed an ambiguity: "Add shortcut to shelf" could mean "Add (a shortcut to this site) to the shelf", or it could mean "Add (a shortcut to the shelf) to something???". The user may be confused, not knowing where it's going to add the shortcut to the shelf, or why you'd want a shortcut to the shelf.

I think this is even worse on Mac where the string is "Add shortcut to Applications", where a "shortcut to the Applications folder" is a real thing.

Given that this string will be always visible on the Chrome menu on all sites (unless they are PWAs, which is the minority), perhaps we shouldn't change this?

Note: This change will also affect Windows, Mac and Linux immediately (even without the Desktop PWAs flag), but it is less of a concern because it is hidden inside the "More tools" menu.

Assuming we proceed, I am changing the description to:
"Title of the bubble for creating a shortcut to this website, and adding it to the shelf."
which, while wordy, should help translators avoid accidentally translating the wrong interpretation.

https://crrev.com/c/983072

Deleted: add-shortcut-chrome-menu.png 22.3 KB

	add-shortcut-chrome-menu.png 22.3 KB View Download

How the "More tools" submenu will look in Linux and Windows in 67.

Deleted: add-shortcut-chrome-menu-linux.png 34.3 KB

	add-shortcut-chrome-menu-linux.png 34.3 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5dc779f89b3cef868069284185826347f946067

commit c5dc779f89b3cef868069284185826347f946067
Author: Matt Giuca <mgiuca@chromium.org>
Date: Wed Mar 28 04:20:05 2018

Change string for adding non-PWA app to shelf/desktop/apps on Desktop.

"Add to shelf / desktop / Applications" -> "Add shortcut to shelf /
desktop / applications". (Adds the word "shortcut".)

Adding "shortcut" helps distinguish non-PWAs from PWAs.

Bug:  822305 
Change-Id: I8c82b9bc6d3cd07b044038bf680a6874a1550e3d
Reviewed-on: https://chromium-review.googlesource.com/983072
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546397}
[modify] https://crrev.com/c5dc779f89b3cef868069284185826347f946067/chrome/app/generated_resources.grd

Leaving this open so Shimi can comment on whether to keep or revert, per #7.

Shimi, if you want to KEEP the "shortcut" language, please mark this as Fixed. Otherwise I (or Alan) will do a revert.

Ah, I wasn't aware about the details in C#5. Please revert all changes for now and we can revisit. 

Thanks Shimi.

Looks like I am temporarily locked out of code review. I'll get Alan to revert. Then we can close this as WontFix.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4551752558faeb10fdd57c798c3e48aed00b8840

commit 4551752558faeb10fdd57c798c3e48aed00b8840
Author: Alan Cutter <alancutter@chromium.org>
Date: Wed Mar 28 22:57:21 2018

Revert "Change string for adding non-PWA app to shelf/desktop/apps on Desktop."

This reverts commit c5dc779f89b3cef868069284185826347f946067.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=822305#c11

Original change's description:
> Change string for adding non-PWA app to shelf/desktop/apps on Desktop.
> 
> "Add to shelf / desktop / Applications" -> "Add shortcut to shelf /
> desktop / applications". (Adds the word "shortcut".)
> 
> Adding "shortcut" helps distinguish non-PWAs from PWAs.
> 
> Bug:  822305 
> Change-Id: I8c82b9bc6d3cd07b044038bf680a6874a1550e3d
> Reviewed-on: https://chromium-review.googlesource.com/983072
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546397}

TBR=alancutter@chromium.org,mgiuca@chromium.org

Change-Id: I9c5442739163a3f1d30dcc017ec785086d853882
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  822305 
Reviewed-on: https://chromium-review.googlesource.com/985332
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546643}
[modify] https://crrev.com/4551752558faeb10fdd57c798c3e48aed00b8840/chrome/app/generated_resources.grd

Thanks Alan,

WontFix (reverted)

After a UI review we've agreed upon "Create shortcut" for non-PWAs for all platforms.

Screenshots of WIP before and after changes for non-PWA menu + title strings.

Deleted: old-menu-non-pwa.png 68.7 KB

	old-menu-non-pwa.png 68.7 KB View Download

Deleted: new-menu-non-pwa.png 73.3 KB

	new-menu-non-pwa.png 73.3 KB View Download

Deleted: old-title-non-pwa.png 59.1 KB

	old-title-non-pwa.png 59.1 KB View Download

Deleted: new-title-non-pwa.png 64.1 KB

	new-title-non-pwa.png 64.1 KB View Download

Updated the button to say Create.

Deleted: new-dialog-non-pwa.png 60.4 KB

	new-dialog-non-pwa.png 60.4 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7

commit a0632f584b74cfc212e4dd3b2753ca748a0bdfc7
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Mar 29 07:07:45 2018

Update PWA and non-PWA shortcut menu and title texts

This CL implements recommendations from a Desktop PWA UI review.
 - Use "Install <app>..." instead of "Add <app> to shelf..." for PWAs.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331947&signed_aid=9D-HKXE7gYd0wUpreYCSAg==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331948&signed_aid=cDTnW4abw74CAZfks6FXkw==&inline=1
 - Use "Create shortcut" instead of "Add to <shortcut container>" for non-PWAs.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331943&signed_aid=Ok3VbYPcM5cA0kp1mufUcQ==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331944&signed_aid=Jn3zF1Bjunr7NY6U5HZs-Q==&inline=1

In addition to these changes the confirmation dialog for these actions
have been updated for consistency:
 - For PWAs:
   Use "Install app?" instead of "Add to shelf?" for the title.
   Use "Install" instead of "Add" for the button.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331949&signed_aid=NBRq_H4GTrT_Nlj4uJZUgg==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331957&signed_aid=yEqown9Qn32Do3_UyXfbGw==&inline=1
 - For non-PWAs:
   Use "Create shortcut?" instead of "Add to shelf" for the title.
   Use "Create" instead of "Add" for the button.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331945&signed_aid=vHvplIxwxZt1AbSCXNlRug==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331958&signed_aid=y82Q7ebdDf31vnnHy_vqcg==&inline=1

Bug:  789817 ,  822305 
Change-Id: Ib2fbe35f43b575a985af6c50094235dc7693a149
Reviewed-on: https://chromium-review.googlesource.com/984916
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546753}
[modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/app/generated_resources.grd
[modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/browser/ui/extensions/hosted_app_browsertest.cc
[modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc