Issue metadata
Sign in to add a comment
|
0.2%-0.4% regression in sizes at 542396:542396 |
||||||||||||||||||||
Issue descriptionRegression around 300K in binary size. The CL responsible is a v8 roll. Bisect should find the actual V8 CL responsible.
,
Mar 15 2018
Assigning to v8-autoroll@chromium.org because this is the only CL in range: Update V8 to version 6.7.31. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0cf325d6..6487d3d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0c81296a4b5b6aea7abf4856deb9f59e4da79b71 Reviewed-on: https://chromium-review.googlesource.com/958185 Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542396}
,
Mar 26 2018
Looks like the v8 roll above increased binary size by 280KiB on Windows and Linux. Can someone from v8 team take a look?
,
Mar 27 2018
Maybe https://chromium.googlesource.com/v8/v8/+/31ac0219a3e68a2470d169f76f23dc06fd84f7d2 ?
,
Mar 27 2018
Close, but no cigar: it's https://crrev.com/c/957024 that increases binary size. This CL embeds builtins into the binary. A followup (https://chromium-review.googlesource.com/964481) removes the corresponding builtins from the snapshot, so overall it should be net neutral (more or less, given that the snapshotted format attempts to compress a bit and the snapshot now contains tiny serialized trampolines). Snapshot size reduction: https://chromeperf.appspot.com/report?sid=c6da0bf539521d2fa2d2a063e3e499f0ff5456a92070535063618adf0d74e0b7&start_rev=51384&end_rev=52233 Binary increase: https://chromeperf.appspot.com/report?sid=76f2cb63387357c82c2c666ec7b5d2ba0548174ee70ea8fd0b05df96b1ad7d0d&start_rev=51690&end_rev=52238
,
Apr 12 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 15 2018