Issue metadata
Sign in to add a comment
|
AddParentUiElement should not reorder elements. |
||||||||||||||||||||||||||
Issue descriptionThe way this function works is by detaching the to-be-parented element, splicing in the new node, and readding the new node to the old parent. The problem: this changes the stacking order of the children in old parent.
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/878926799972445a4a82377faffbc2c9a2a0ceac commit 878926799972445a4a82377faffbc2c9a2a0ceac Author: Ian Vollick <vollick@chromium.org> Date: Mon May 07 17:36:22 2018 [vr] AddParentUiElement should not reorder elements Previously, this would end up sticking the parent element at the end of the child list. Bug: 822283 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I840edc68a37243d20b24c62a8ab85743c2d42e83 Reviewed-on: https://chromium-review.googlesource.com/1047345 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#556487} [modify] https://crrev.com/878926799972445a4a82377faffbc2c9a2a0ceac/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/878926799972445a4a82377faffbc2c9a2a0ceac/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/878926799972445a4a82377faffbc2c9a2a0ceac/chrome/browser/vr/elements/ui_element_unittest.cc [modify] https://crrev.com/878926799972445a4a82377faffbc2c9a2a0ceac/chrome/browser/vr/ui_scene.cc
,
May 7 2018
,
May 10 2018
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by cjgrant@chromium.org
, May 3 2018