New issue
Advanced search Search tips

Issue 822278 link

Starred by 1 user
Status: Fixed
Owner:
kyleju@chromium.org
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT Export] Escape PR descriptions on GitHub

Project Member Reported by robertma@chromium.org, Mar 15 2018 
Broken example: https://github.com/w3c/web-platform-tests/pull/10048

The HTML tags in the commit message broke the PR description. We need to escape these, or somehow tell GitHub to display our export descriptions as verbatim.

Comment 1 by robertma@chromium.org, Aug 16

Labels: Hotlist-GoodFirstBug

Comment 2 by robertma@chromium.org, Sep 14

Owner: kyleju@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d86fb0af2f5b5f9417bb168ba81a025f27d38f9

commit 6d86fb0af2f5b5f9417bb168ba81a025f27d38f9
Author: kyle Ju <kyleju@chromium.org>
Date: Mon Sep 17 22:54:37 2018

[blinkpy] Escape HTML tags in GitHub PR descriptions

Fix  bug 822278 , due to the difference in supporting html tag between Gerrit and Github

Bug:  822278 

Change-Id: I61dbe497fffb2416b1168cbf2c510a0729445a48
Reviewed-on: https://chromium-review.googlesource.com/1225431
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591858}
[modify] https://crrev.com/6d86fb0af2f5b5f9417bb168ba81a025f27d38f9/third_party/blink/tools/blinkpy/w3c/test_exporter.py
[modify] https://crrev.com/6d86fb0af2f5b5f9417bb168ba81a025f27d38f9/third_party/blink/tools/blinkpy/w3c/test_exporter_unittest.py

Comment 4 by robertma@chromium.org, Sep 18

Status: Fixed (was: Started)
►

Sign in to add a comment