Issue metadata
Sign in to add a comment
|
Custom tab action buttons don't always get updated |
||||||||||||||||||
Issue descriptionSee b/73160522: If a custom action button doesn't have the default ID of 0, Chrome fails to update it.
,
Mar 19 2018
,
Mar 20 2018
The NextAction date has arrived: 2018-03-20
,
Mar 20 2018
I'd like to merge r543660 to the M66 branch. It's a relatively small change, has been on Canary, and (now) has tests.
,
Mar 20 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 20 2018
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2c4d450de16af5cc06fd709313c323cb930da94 commit c2c4d450de16af5cc06fd709313c323cb930da94 Author: Bernhard Bauer <bauerb@chromium.org> Date: Wed Mar 21 16:59:19 2018 Fix variable typo in CustomTabIntentDataProvider.getButtonParamsForId() Also, get the correct child to update in CustomTabToolbar.updateCustomActionButton(). Bug: b/73160522, 822277 Change-Id: Ia77234d6023a1049d506684bda3aaaa7e96cd405 Reviewed-on: https://chromium-review.googlesource.com/964444 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543660}(cherry picked from commit 7d8451ab014022fe060be72b2d568a57f87a0479) Reviewed-on: https://chromium-review.googlesource.com/973523 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#361} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java [modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java [modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java [modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
,
Mar 23 2018
Please verify in M66 and close if everything looks good.
,
Mar 27 2018
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 16 2018