New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822277 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Components:
EstimatedDays: ----
NextAction: 2018-03-20
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Custom tab action buttons don't always get updated

Project Member Reported by bauerb@chromium.org, Mar 15 2018

Issue description

See b/73160522: If a custom action button doesn't have the default ID of 0, Chrome fails to update it.
 

Comment 2 by bauerb@chromium.org, Mar 19 2018

NextAction: 2018-03-20
The NextAction date has arrived: 2018-03-20

Comment 4 by bauerb@chromium.org, Mar 20 2018

Labels: Merge-Request-66
I'd like to merge r543660 to the M66 branch. It's a relatively small change, has been on Canary, and (now) has tests.
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 20 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cmasso@google.com, Mar 20 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2c4d450de16af5cc06fd709313c323cb930da94

commit c2c4d450de16af5cc06fd709313c323cb930da94
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Wed Mar 21 16:59:19 2018

Fix variable typo in CustomTabIntentDataProvider.getButtonParamsForId()

Also, get the correct child to update in
CustomTabToolbar.updateCustomActionButton().

Bug: b/73160522, 822277
Change-Id: Ia77234d6023a1049d506684bda3aaaa7e96cd405
Reviewed-on: https://chromium-review.googlesource.com/964444
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#543660}(cherry picked from commit 7d8451ab014022fe060be72b2d568a57f87a0479)
Reviewed-on: https://chromium-review.googlesource.com/973523
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#361}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/c2c4d450de16af5cc06fd709313c323cb930da94/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Comment 8 by cmasso@google.com, Mar 23 2018

Please verify in M66 and close if everything looks good.

Comment 9 by bauerb@chromium.org, Mar 27 2018

Status: Fixed (was: Started)

Sign in to add a comment