BackgroundFetchBrowserTest.OfflineItemCollection_VerifyIconReceived is flaky |
||||
Issue descriptionhttps://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGRlMGUxOWVkYTIxOWFhYTE5YTE2NzUwMDA2Y2IyMTVmY2IyM2U1MQw Introduced by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/956183 Would you please take a look, Mugdha?
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/999e75b1963c55b36d0344a353c37e06e69cdc28 commit 999e75b1963c55b36d0344a353c37e06e69cdc28 Author: Mugdha Lakhani <nator@chromium.org> Date: Thu Mar 15 17:29:06 2018 Disable a flaky Background Fetch browser test. NOTRY=true Bug: 822276 Change-Id: I7a1781912c47be7bd34cf39e2f1b6f0610cf281a Reviewed-on: https://chromium-review.googlesource.com/964561 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#543424} [modify] https://crrev.com/999e75b1963c55b36d0344a353c37e06e69cdc28/chrome/browser/background_fetch/background_fetch_browsertest.cc
,
Mar 16 2018
Just to update: Failed steps failed browser_tests failed failure reason on Mac #67.0.3372.0 on official.desktop. Build URL: ---------- https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/2759 Log URL: -------- https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fmac64%2F2759%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Error Log: (Please check the Error log URL for complete error). --------- [ FAILED ] CrSettingsAboutPageTest.AboutPage_OfficialBuild, where TypeParam = and GetParam() = (1330 ms) [8355/8355] CrSettingsAboutPageTest.AboutPage_OfficialBuild (1586 ms) 2 tests failed: BackgroundFetchBrowserTest.OfflineItemCollection_SingleFileMetadata (../../chrome/browser/background_fetch/background_fetch_browsertest.cc:297) CrSettingsAboutPageTest.AboutPage_OfficialBuild (../../chrome/test/data/webui/settings/cr_settings_browsertest.js:198) <Thread(Thread-1, started 123145307144192)> ProcessRead: proc.stdout finished. <Thread(Thread-1, started 123145307144192)> ProcessRead: cleaning up. <Thread(Thread-2, started daemon 123145311350784)> TimedFlush: Finished <Thread(Thread-1, started 123145307144192)> ProcessRead: finished. python /b/rr/tmpWqQVq7/rw/checkout/recipes/.recipe_deps/depot_tools/gsutil.py -- cp file:///var/folders/74/6q8tck6s76q64sp6b7wsww_m0000gm/T/tmp2xsSYO gs://chrome-gtest-results/raw/2018/3/12/16/be71f80a51a13e4fd19d10c6f73e28da7c920981.json.gz --------- Operation completed over 1 objects/215.6 KiB. exit code (as seen by runtest.py): 1 Confused: 3 files were deleted from /var/folders/74/6q8tck6s76q64sp6b7wsww_m0000gm/T during the test run step returned non-zero exit code: 1 @nator : Could you please take a look in to it. Thank You!
,
Mar 16 2018
Let's keep this public please.
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1a8b203ae9c854f97d0750591a118f52e6f84a4 commit b1a8b203ae9c854f97d0750591a118f52e6f84a4 Author: Mugdha Lakhani <nator@chromium.org> Date: Mon Mar 26 16:03:27 2018 Pass around BackgroundFetch options as mojom type. CL https://chromium-review.googlesource.com/c/chromium/src/+/956183 caused a few tests to be flaky, which was due to the garbage collector getting rid of BackgroundFetchOptions from under us. This change creates a copy of background fetch options early on, converting them from blink::BackgroundFetchOptions to mojom::blink::BackgroundFetchRegistrationPtr. This copy is not going to be deleted by the GC, hence ensuring accurate data later on in the processing of the fetch. Bug: 822276 Change-Id: Iaab780b18182372cf607b57eb15815c852d4595a Reviewed-on: https://chromium-review.googlesource.com/977909 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#545805} [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchIconLoader.cpp [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchIconLoader.h [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp [modify] https://crrev.com/b1a8b203ae9c854f97d0750591a118f52e6f84a4/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.h
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b9174f8cc3674b9f15a5dfe6064a77e880c4dac commit 8b9174f8cc3674b9f15a5dfe6064a77e880c4dac Author: Mugdha Lakhani <nator@chromium.org> Date: Tue Apr 03 11:01:55 2018 Remove old comment regarding a TODO which is done. Bug: 822276 Change-Id: I8ed04d4681e2f0e7bb41b869d6b855547b023965 Reviewed-on: https://chromium-review.googlesource.com/986294 Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#547666} [modify] https://crrev.com/8b9174f8cc3674b9f15a5dfe6064a77e880c4dac/chrome/browser/background_fetch/background_fetch_browsertest.cc
,
Apr 9 2018
These are fine now, thanks Mugdha! |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 15 2018