New issue
Advanced search Search tips

Issue 822264 link

Starred by 2 users
Status: Fixed
Owner:
samans@chromium.org
Closed: Apr 2018
Cc:
m...@chromium.org
mfo...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Implement direct GPU to shared memory copying for RGBA readback in FrameSinkVideoCapturer

Project Member Reported by samans@chromium.org, Mar 15 2018 
For I420 we directly copy from GPU memory into the media::VideoFrame backed by shared memory. For RGBA though, we first copy from GPU into a SkBitmap then copy that SkBitmap into media::VideoFrame. We should just avoid the extra copy and implement copy directly similar to I420.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bc8d71ce0747ee6287f397e31060c40b4e73a34

commit 4bc8d71ce0747ee6287f397e31060c40b4e73a34
Author: Saman Sami <samans@chromium.org>
Date: Wed Apr 18 14:06:28 2018

viz: Implement direct GPU to shared memory copy for RGBA capture

For I420 capture we directly copy from GPU memory into shared memory
but for RGBA capture there is an extra copy involved. Implement direct
GPU to shared memory copy for RGBA capture.

Bug:  822264 ,  813929 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id359e655cde9d67f12647a0fde6f3751e3d959a4
Reviewed-on: https://chromium-review.googlesource.com/1005404
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551662}
[modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/common/frame_sinks/copy_output_result.cc
[modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/common/frame_sinks/copy_output_result.h
[modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/service/display/gl_renderer_copier.cc
[modify] https://crrev.com/4bc8d71ce0747ee6287f397e31060c40b4e73a34/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl.cc

Comment 2 by samans@chromium.org, Apr 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment