The delay estimator in AEC3 is sometimes too slow to react to a buffer issue causing a delay change |
||||||||
Issue descriptionThe task of the delay estimator in AEC3 is to react to any changes in the alignment between render and capture so that the echo removal is done on properly aligned signals It seems that in some cases, it can be very slow to react to such changes and it has been shown to take up to 10 seconds, which results in 10 seconds of sustained echo leakage until the realignment has been detected.
,
Mar 22 2018
I would like to ask for a merge of this into M66. The feature has been tested in Canary for 5 days and the stats looks good. Furthermore, the feature is only active beneath an experimental flag so the merge is safe in the sense that the code can be turned off in case any issue would arise.
,
Mar 22 2018
This bug requires manual review: Less than 22 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
Approving merge for M66. Branch:3359
,
Mar 23 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/43be8938a716347d9357b92a7122ccfa5c61caa2 commit 43be8938a716347d9357b92a7122ccfa5c61caa2 Author: Per Åhgren <peah@webrtc.org> Date: Fri Mar 23 13:45:59 2018 Merge to M66: Improving the speed of the delay estimator in AEC3 This CL significantly improves the response time of the AEC3 delay estimator to audio buffer issues. The CL adds ensures that the delay estimator correlators reacts to buffer issues from the zero state which is much faster than if it has already achieved a state matching a previous alignment. The CL has been extensively tested on offline recordings. (cherry picked from commit 895ae9a0cdff3f174c08d3f23b7ee4170cf34ffc) TBR: ivoc@webrtc.org,henrik.lundin@webrtc.org Bug: webrtc:9023 , chromium:822245 Change-Id: Ic149b9429e592d4c3535eb8432582f435a1b4745 Reviewed-on: https://webrtc-review.googlesource.com/62081 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#22461} Reviewed-on: https://webrtc-review.googlesource.com/64407 Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/branch-heads/66@{#9} Cr-Branched-From: 12c8110e8c717b7f0f87615d3b99caac2a69fa6c-refs/heads/master@{#22215} [modify] https://crrev.com/43be8938a716347d9357b92a7122ccfa5c61caa2/modules/audio_processing/aec3/echo_path_delay_estimator.cc [modify] https://crrev.com/43be8938a716347d9357b92a7122ccfa5c61caa2/modules/audio_processing/aec3/echo_path_delay_estimator.h [modify] https://crrev.com/43be8938a716347d9357b92a7122ccfa5c61caa2/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc
,
Mar 23 2018
,
Mar 26 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 15 2018