New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822233 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 268984
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Crash browser on startup due to colliding notification types values

Reported by ivafa...@yandex-team.ru, Mar 15 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 YaBrowser/18.3.1.349 Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
Start a browser with fully loaded v4 safe browsing databases.

This crash is a bit problematic to reproduce locally so as it relates to a race condition.

What is the expected behavior?
Not to crash.

What went wrong?
Crash

Crashed report ID: no

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? N/A 

Chrome version: 64.0.3282.140  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 29.0 r0

There is a try to fix crash here:
https://chromium-review.googlesource.com/c/chromium/src/+/964222
 
Thanks for filing the issue. It would be more helpful if you provide us the Crash server id from chrome://crashes (as highlighted in the attachment).

Thanks..!
Serverid.PNG
54.4 KB View Download
Cc: jmukthavaram@chromium.org
Labels: Needs-Milestone Needs-Feedback
Hi!

I don't have the report ID.
I've provided some info about root cause here:
https://chromium-review.googlesource.com/c/chromium/src/+/964222

This info should be sufficient for programmers to fix the issue.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 16 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: derat@chromium.org sandeepkumars@chromium.org
Components: Blink>JavaScript
CC'ing file reviewer from the CL below
https://chromium-review.googlesource.com/c/chromium/src/+/964222

@derat: Could you please help us with this.

Thanks!!

Comment 6 by derat@chromium.org, Mar 19 2018

Cc: jam@chromium.org
There's already a discussion on the changelist. Copying jam@'s comment from there:

"The notification system has been deprecated for a long time, and the existing method which we avoided collisions between chrome and extensions was already hacky. Instead of adding another hack for one notification in components/safe_browsing, i think we should bring back that notification which was added recently back to src/chrome, and have the component just notify src/chrome which then fires it."
Labels: TE-NeedsTraige-help
Seems it is out of scope from TE end as per C#6, adding TE-NeedsTraige-help label to move this out of our triaging bucket.

Could someone from dev team please take a look into this issue.
Thanks..!

Components: -Blink>JavaScript UI>Browser
This issue was fixed here:
https://chromium-review.googlesource.com/c/chromium/src/+/979192

Could please anyone mark the ticket as fixed?

Comment 10 by derat@chromium.org, Mar 29 2018

Mergedinto: 268984
Status: Duplicate (was: Unconfirmed)
Thanks!

Comment 11 by a...@chromium.org, Mar 30 2018

Happy to have accidentally fixed it!

If anyone wants to help slowly remove notifications, please do!

Sign in to add a comment