New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822231 link

Starred by 11 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Flaky-Test: MediaRouterIntegrationOneUABrowserTest.Basic

Blocked on:
issue 822337

Blocking:
issue 678472



Sign in to add a comment

Media Router integration tests are flaky

Project Member Reported by Findit, Mar 15 2018

Issue description

Labels: -Sheriff-Chromium
Owner: mfo...@chromium.org
Status: Assigned (was: Available)
Can you please take a look at this?  Findit believes with 100% confidence it is your CL.  Thanks.

Comment 2 by mfo...@chromium.org, Mar 15 2018

Cc: mfo...@chromium.org crouleau@chromium.org dnicoara@chromium.org
 Issue 822048  has been merged into this issue.

Comment 3 by mfo...@chromium.org, Mar 15 2018

Cc: leilei@chromium.org cliffordcheng@chromium.org zhaobin@chromium.org
 Issue 822300  has been merged into this issue.

Comment 4 by mfo...@chromium.org, Mar 15 2018

 Issue 822301  has been merged into this issue.

Comment 5 by mfo...@chromium.org, Mar 15 2018

 Issue 822216  has been merged into this issue.

Comment 6 by mfo...@chromium.org, Mar 15 2018

 Issue 822215  has been merged into this issue.

Comment 7 by mfo...@chromium.org, Mar 15 2018

 Issue 822179  has been merged into this issue.

Comment 8 by mfo...@chromium.org, Mar 15 2018

Going to do another round of disabling, hopefully that will be the last.

Comment 9 by mfo...@chromium.org, Mar 15 2018

 Issue 822337  has been merged into this issue.
Ping since still getting alerts. For example on MediaRouterIntegrationOneUANoReceiverBrowserTest.Basic . Thanks for helping out!
 Issue 821717  has been merged into this issue.
Let me know if you see any additional flakes after f0c6 landed.

Components: Internals>Cast
The test failed on https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_cfi_rel_ng/426 which I think is past "f0c6" (which I suppose means d42d1308cb2f7a1ca28af8f197524c80579cf0c6 ? I think it might be more common to use the first few letters of the hash instead of the last few, and more than 4 is also needed to avoid collisions)
Those are different tests than the one in the patch in C#11.

 Issue 822741  has been merged into this issue.
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa1b00388b667ff1c7df4a8a3e57e9a87a31f96

commit 3fa1b00388b667ff1c7df4a8a3e57e9a87a31f96
Author: mark a. foltz <mfoltz@chromium.org>
Date: Fri Mar 16 19:23:00 2018

[Media Router] Disable two more flaky tests.

Disables two more tests found to be flaky.

TBR=zhaobin

Bug: 822231
Change-Id: I0c6a36a7d448e942ffd191ea12471f33c2729c81
Reviewed-on: https://chromium-review.googlesource.com/966983
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543780}
[modify] https://crrev.com/3fa1b00388b667ff1c7df4a8a3e57e9a87a31f96/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/3fa1b00388b667ff1c7df4a8a3e57e9a87a31f96/chrome/test/media_router/media_router_one_ua_integration_browsertest.cc

Cc: karandeepb@chromium.org
 Issue 822950  has been merged into this issue.
Labels: Sheriff-Chromium
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd70e542e44ee67671cb5a64d6751ed1ed7ed03

commit 7bd70e542e44ee67671cb5a64d6751ed1ed7ed03
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Sat Mar 17 00:04:19 2018

Disable flaky MediaRouterIntegrationOneUANoReceiverBrowserTest.ReconnectSesion

BUG=822231
TBR=mfoltz@chromium.org

Change-Id: I22d30d5c0c6ba309492697605077a94ba994148c
Reviewed-on: https://chromium-review.googlesource.com/967411
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543876}
[modify] https://crrev.com/7bd70e542e44ee67671cb5a64d6751ed1ed7ed03/chrome/test/media_router/media_router_one_ua_integration_browsertest.cc

Labels: -Sheriff-Chromium Test-Disabled
Project Member

Comment 23 by chromium...@appspot.gserviceaccount.com, Mar 17 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "MediaRouterIntegrationOneUANoReceiverBrowserTest.ReconnectSession". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFNZWRpYVJvdXRlckludGVncmF0aW9uT25lVUFOb1JlY2VpdmVyQnJvd3NlclRlc3QuUmVjb25uZWN0U2Vzc2lvbgw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
The test in c#23 should be disabled.
Labels: -Pri-1 M-69 Pri-2
Here is a summary of what's been disabled.   I will start a doc with the failure output before it's lost.  It's going to take some effort set aside in Q2 to fix all of these, so setting a future milestone.

MediaRouterIntegrationBrowserTest::MANUAL_OpenLocalMediaFileFullscreen
MediaRouterIntegrationBrowserTest::MANUAL_OpenLocalMediaFileInCurrentTab

MediaRouterIntegrationBrowserTest::MANUAL_ReconnectSession
MediaRouterIntegrationBrowserTest::MANUAL_Dialog_RouteCreationTimedOut

MediaRouterIntegrationIncognitoBrowserTest::MANUAL_ReconnectSession

MediaRouterIntegrationOneUABrowserTest::MANUAL_Basic
MediaRouterIntegrationOneUABrowserTest::MANUAL_SendAndOnMessage
MediaRouterIntegrationOneUABrowserTest::MANUAL_ReceiverCloseConnection
MediaRouterIntegrationOneUABrowserTest::MANUAL_ReconnectSession
MediaRouterIntegrationOneUABrowserTest::MANUAL_ReconnectSessionSameTab

MediaRouterIntegrationOneUANoReceiverBrowserTest::MANUAL_Basic
MediaRouterIntegrationOneUANoReceiverBrowserTest::MANUAL_Fail_SendMessage
MediaRouterIntegrationOneUANoReceiverBrowserTest::MANUAL_ReconnectSession


I dumped a bunch of output from the failed builders into this doc (tried to group by root cause).  It seems like we can fix most of the Presentation API tests by handling pending Mojo callbacks better and working around a ChromeOS DCHECK.

https://docs.google.com/document/d/1WS9YYlC-sgjdpFS1f8NtCWMrzUhEBALghL1bClwMxFc/edit?usp=sharing
Cc: -crouleau@chromium.org
Cc: -karandeepb@chromium.org
Project Member

Comment 29 by Findit, Mar 20 2018

Findit identified the culprit r543005 with confidence 100.0% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKmAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI2NTczL211c19icm93c2VyX3Rlc3RzL1RXVmthV0ZTYjNWMFpYSkpiblJsWjNKaGRHbHZiazl1WlZWQlRtOVNaV05sYVhabGNrSnliM2R6WlhKVVpYTjBMa1poYVd4ZlUyVnVaRTFsYzNOaFoyVT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgDDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in alpha version.
Feedback is welcome using component Tools>Test>FindIt>Flakiness !
Blockedon: 822337
 Issue 824889  has been merged into this issue.

Comment 32 by amp@chromium.org, Mar 30 2018

 Issue 818766  has been merged into this issue.

Comment 33 by amp@chromium.org, Mar 30 2018

Cc: imch...@chromium.org
 Issue 778397  has been merged into this issue.
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 35 by w...@chromium.org, Apr 2 2018

 Issue 828039  has been merged into this issue.

Comment 36 by zmin@chromium.org, Apr 4 2018

 Issue 828798  has been merged into this issue.

Comment 37 by zmin@chromium.org, Apr 4 2018

WebContentsImplBrowserTest.PausePageScheduledTasks is Flaky
Blocking: 678472
Project Member

Comment 39 by Findit, Apr 6 2018

Findit identified the culprit r547403 with confidence 100.0% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKVAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI2ODc2L2NvbnRlbnRfYnJvd3NlcnRlc3RzL1YyVmlRMjl1ZEdWdWRITkpiWEJzUW5KdmQzTmxjbFJsYzNRdVVHRjFjMlZRWVdkbFUyTm9aV1IxYkdWa1ZHRnphM009DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAgw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in alpha version.
Feedback is welcome using component Tools>Test>FindIt>Flakiness !
Cc: m...@chromium.org
 Issue 826016  has been merged into this issue.
Cc: amp@chromium.org
 Issue 834681  has been merged into this issue.
Summary: Media Router integration tests are flaky (was: MediaRouterIntegrationOneUABrowserTest.Basic is Flaky)
 Issue 840165  has been merged into this issue.
Cc: taku...@chromium.org
 Issue 853114  has been merged into this issue.
Labels: -M-69 Target-70 M-70
Cc: -zhaobin@chromium.org
Cc: -amp@chromium.org
 Issue 873912  has been merged into this issue.
Labels: -Target-70 -M-70 Target-71
Labels: -Pri-2 -Target-71 Pri-3
Owner: ----
Status: Available (was: Assigned)
Cc: -imch...@chromium.org
We are now done with converting the integration/e2e tests to use the Views UI instead of WebUI (issue 900248). There still are 7 flaky test cases that are either disabled or run only in our private waterfall:

MediaRouterE2EBrowserTest.DISABLED_OpenLocalMediaFileFullscreen (issue 903016)
MediaRouterIntegrationBrowserTest.DISABLED_OpenLocalMediaFileFullscreen (issue 903016)
MediaRouterIntegrationBrowserTest.MANUAL_Fail_NoProvider
MediaRouterIntegrationBrowserTest.MANUAL_Dialog_Basic
MediaRouterIntegrationBrowserTest.MANUAL_Dialog_RouteCreationTimedOut
MediaRouterIntegrationOneUABrowserTest.MANUAL_SendAndOnMessage
MediaRouterIntegrationOneUABrowserTest.MANUAL_ReceiverCloseConnection

Sign in to add a comment