New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822207 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2

Blocking:
issue 804500



Sign in to add a comment

Generate PNG assets for tab Grid page control

Project Member Reported by marq@chromium.org, Mar 15 2018

Issue description

We require image assets for the segmented page control in the tab grid toolbar.

Each icon in the toolbar needs to be in two sizes and styles -- the regular off-white style to appear on the dark grey background, and the slightly larger black style to appear when the icon is "selected". In both cases, the background of the icon should be transparent.

Please generate @1x, @2x, and @3x resolutions for each asset.

Assets should be named thusly:

(prefix).png
(prefix)@2x.png
(prefix)@3x.png
(prefix)_selected.png
(prefix)_selected@2x.png
(prefix)_selected@3x.png

I have assumed that these assets do not vary between size classes or devices; please let me know if this is incorrect.

Mocks for the tab grid show two variants of the page control: one where there is a tab count label associated with the incognito tabs icon, and one where there is not. My tacit assumption is that the incognito tab count is only shown when it is > 0. Please let me know if this is incorrect.

Page control assets:
page_control_incognito_tabs 
page_control_incognito_tabs_nolabel
page_control_regular_tabs
page_control_remote_tabs

Additionally, the following sizes and fonts are needed:
- Font and color for the tab count labels (both regular and selected).

I have assumed that the page control is always the same size, regardless of device, orientation, or size class. That size is computed from these sizes:

Size of each segment : 64w x 36h
Size of the white "slider" : 78w x 40h
Width of the dividing lines between segments: 1
Corner radii : 13

Please let me know if any of these dimensions are incorrect.
 

Comment 1 by marq@chromium.org, Mar 15 2018

Blocking: 804500
NextAction: 2018-03-28
Cc: khalilcader@chromium.org
Owner: pschaffner@chromium.org
The NextAction date has arrived: 2018-03-28

Comment 5 by cmasso@google.com, Apr 10 2018

Labels: -Pri-1 -Q1 Q2 Pri-0

Comment 6 by marq@chromium.org, Apr 12 2018

Status: Fixed (was: Assigned)
This is done; if we need to update the assets, we'll open a new bug,

Comment 7 by cma...@chromium.org, Apr 25 2018

NextAction: ----

Sign in to add a comment