Regression:Unable to click on any listed video on 'www.youtube.com' after clicking the back arrow button on the Macbook touchbar panel
Reported by
vineetha...@etouch.net,
Mar 15 2018
|
||||||||||
Issue descriptionChrome Version: 66.0.3359.33 (Official Build) Revision 829b54d98e4bcf8906c6ea642e2645f91e98ca29-refs/branch-heads/3359@{#258}(64 bit) OS: Mac 10.13.4(Mac Touchbar) What steps will reproduce the problem? (1) Launch Chrome, click on the full screen icon of the browser. (2) Navigate to 'www.youtube.com' and play any video. (3) Click on the full screen icon of the video player. (4) Now click the back arrow button, on the tab strip of the Mac touchbar and observe. Actual Result: Unable to click on any listed video on www.youtube.com after clicking the back arrow button on the Macbook touchbar panel. Expected Result: Should be able to click on any listed video on www.youtube.com after clicking the back arrow button on the Macbook touchbar panel. This is regression issue broken in ‘M-65’ and providing the bisect using per-revision bisect, Good build: 65.0.3288.0(Revision: 522667) Bad build: 65.0.3289.0(Revision: 522956) You are probably looking for a change made after 522770 (known good), but no later than 522771 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3b0721d2e0a2f632436646b89648959f69a9dce9..17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2 Suspect:https://chromium.googlesource.com/chromium/src/+/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2 @foolip: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is not seen Windows(7,8,8.1,10), Mac(10.12.6,10.13.1) and Linux(14.04). 2. Issue is also seen on Stable(build #65.0.3325.162), Canary(build #67.0.3371.0) Thank You!
,
Mar 16 2018
,
Mar 17 2018
,
Mar 17 2018
Seems like this is dupe of bug 821576 . + mlamouri@ who looked at bug bug 821576 and also(CL reviewer) as foolip@ is OOO.
,
Mar 19 2018
cc spqchan@ who is the mac touchbar owner
,
Mar 19 2018
I had a look at this and it doesn't seem related to bug 821576 . The issue is that when going back, there seems to be an issue in the fullscreen cleanup. It's most likely a very old bug that had no consequence until foolip@'s change to prevents events from going trough outside of the fullscreen's element tree. The bug is not Mac/Touchbar specific and on any machine can be reproduced like this: - Open youtube.com - In the Chrome menu, go fullscreen - Play a video, go fullscreen - Open the inspector - type `history.back()` Expected result: - `document.webkitFullscreenElement` is null - the user can click on the page Actual result: - `document.webkitFullscreenElement` is *not* null - the user can't interact with the page Notes: - Even though it's not TouchBar related, it's hard to trigger `history.back()` outside of the touchbar. - Calling `document.webkitCancelFullScreen()` fixes the issue so it's most likely a cleanup that may check if the page is fullscreen to update the fullscreen element and doesn't realise the page is fullscreen but not the document. I may investigate further later in the day.
,
Mar 19 2018
Mac TL: Stripping RBS. This is a bad bug, but not bad enough to block stable; let's target a fix for M66.
,
Mar 19 2018
Tagging as M66 stable blocker per comment #8.
,
Mar 20 2018
Looking more into it, this is a bug with YouTube than became worse with the change we added in Chrome 65. I will reach out to them.
,
Mar 20 2018
And dropping MBP specific stuff as Alt+Left reaches exactly the same bug.
,
Mar 20 2018
Thanks for looking into this, mlamouri@! Do you still believe there's something wrong with Blink's fullscreen logic? If it's ever possible to exit fullscreen by any means and have document.webkitFullscreenElement not be null, that's a problem. But it's not clear if the `history.back()` bit in #7 does exit fullscreen. (I didn't try it.)
,
Mar 20 2018
No, it does not exit fullscreen and this is the problem: because the video is fullscreen but hidden, it's no longer possible to interact with the page.
,
Mar 21 2018
OK, thanks, not the kind of problem I was imagining/fearing then. That's good!
,
Apr 2 2018
Just a heads up, M66 Stable cut is on April 12th, 10 days away. This issue is marked as RB-Stable for 66. Please make sure to address this issue prior to stable cut. Thanks!
,
Apr 9 2018
Friendly ping to get an update on this issue as it is marked as stable blocker & M66 Stable cut is on April 12th. Thanks..!
,
Apr 9 2018
Reminder: Please note that M66 Stable is only 7 days away. This bug has been marked as ReleaseBlock Stable for M66. So please take a look and appropriately address this bug.
,
Apr 16 2018
Gentle ping to get an update on this issue ASAP as M66 stable release is tomorrow and this bug is marked as stable blocker. Thanks..!
,
Apr 16 2018
This shouldn't be a RBS per comment 8. Let's target a fix for 67 instead.
,
Apr 30 2018
Do we have an internal youtube bug number for this?
,
May 1 2018
,
May 29 2018
Marking as closed as the action is on the YouTube team, isn't chrome specific, and is being tracked in an internal issue (see comment 21).
,
Jun 13 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by manoranj...@chromium.org
, Mar 15 2018