New issue
Advanced search Search tips

Issue 822183 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Windows-specific native notifications code should use base::string16 where possible

Project Member Reported by grt@chromium.org, Mar 15 2018

Issue description

The native string type on Windows is a UTF-16 string. This matches our base::string16 type. I notice that there are spots in the notifications code where strings obtained from the OS (e.g., command lines) are converted to ASCII and then passed around as std::strings. I think it would be an improvement to stick with string16 (at least in Win-specific code) to reduce the number of conversions and to remove any confusion about when to use ASCII vs UTF8.
 

Comment 2 by chengx@chromium.org, Mar 20 2018

Status: Fixed (was: Assigned)

Sign in to add a comment