New issue
Advanced search Search tips

Issue 822147 link

Starred by 1 user
Status: Fixed
Owner:
tangltom@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : In 'Avatar' menu, action is being performed before releasing the mouse button.

Reported by avsha...@etouch.net, Mar 15 2018 
Chrome Version : 67.0.3371.0 (Official Build) 497c718be40e845d85a70a9b3a01c6f1ebe44efc-refs/heads/master@{#543278} 32/64-bit
OS : Windows(7,8,8.1,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and open 'Avatar' menu.
2. Now, try to click on profile name and observe.

Actual Result : In Avatar menu, action is being performed before releasing the mouse button. (i.e action is performed upon mouse down event) 

Expected Result : In Avatar menu, action should get performed on mouse release event.

This is a regression issue, broken in M-67 and will soon update other info.
Good Build : 67.0.3370.0
Bad Build : 67.0.3371.0
Actual_Result.mp4
623 KB View Download
Expected_Result.mp4
352 KB View Download

Comment 1 by avsha...@etouch.net, Mar 15 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67 ET-MUM-Reported OS-Mac
Owner: tangltom@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-67 and providing the bisect using Per-Revision script:
Good Build : 67.0.3370.0 (Revision : 542910)
Bad Build : 67.0.3371.0 (Revision : 543278)

You are probably looking for a change made after 543060 (known good), but no later than 543061 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/12ecdf0a71ce4e50ee25e5c4d0d128a2a2d0f06e..7f9a64d3d178a323ac21f039310bfceb45bc4d6a

Suspect : https://chromium.googlesource.com/chromium/src/+/7f9a64d3d178a323ac21f039310bfceb45bc4d6a

@Thomas : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by tangltom@chromium.org, Mar 15 2018

Status: Started (was: Assigned)
Yes, this was introduced with https://chromium.googlesource.com/chromium/src/+/7f9a64d3d178a323ac21f039310bfceb45bc4d6a.

I'm working on a fix.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bda1898036dc3ddac9e4d5f9df2f76f68b072d51

commit bda1898036dc3ddac9e4d5f9df2f76f68b072d51
Author: Thomas Tangl <tangltom@chromium.org>
Date: Wed Mar 21 11:23:24 2018

Change HoverButton activation to on mouse released

This CL changes the activation of HoverButton to on mouse
released instead of on mouse pressed, which was inherited
from MenuButton.

Also, unlike MenuButton, HoverButton should not be pressed on
key up or down. This CL fixes this.

Bug:  822147 
Change-Id: Ia336a3f0e6b6f4f618c9cb2e6f4009d2fa0a826b
Reviewed-on: https://chromium-review.googlesource.com/966286
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544666}
[modify] https://crrev.com/bda1898036dc3ddac9e4d5f9df2f76f68b072d51/chrome/browser/ui/views/hover_button.cc
[modify] https://crrev.com/bda1898036dc3ddac9e4d5f9df2f76f68b072d51/chrome/browser/ui/views/hover_button.h

Comment 4 by tangltom@chromium.org, Mar 21 2018

Status: Fixed (was: Started)

Comment 5 by avsha...@etouch.net, Mar 22 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3378.0
Update : 
Retested above issue in latest Canary #67.0.3378.0 build on Mac(10.12.6, 10.13.1, 10.13.4), Windows(7,8,8.1,10) and Linux(14.04 LTS) OS and the original issue is fixed. Now in Avatar menu, action is being performed on mouse release event as expected. Kindly review an attached screen-cast.
Canary_behavior.mp4
470 KB View Download
►

Sign in to add a comment