Desktop PWA: "Open link in app" context menu crashes on unicode |
||
Issue descriptionRepro: 1. Install PWA with unicode name: https://mint-horn.glitch.me/ 2. Right click a link to it: https://mint-horn.glitch.me/ [66997:66997:0315/155151.238696:FATAL:utf_string_conversions.cc(218)] Check failed: IsStringASCII(ascii). 㯙㯜㯙㯟㯙㯜㯙㯟㯙㯜㯙㯟 #0 0x7f3db08c636c base::debug::StackTrace::StackTrace() #1 0x7f3db08ecfec logging::LogMessage::~LogMessage() #2 0x7f3db0948dce base::ASCIIToUTF16() #3 0x55b5dc3423cc RenderViewContextMenu::AppendOpenInBookmarkAppLinkItems() #4 0x55b5dc340c8d RenderViewContextMenu::AppendLinkItems() #5 0x55b5dc340429 RenderViewContextMenu::InitMenu() #6 0x55b5dbefa33b RenderViewContextMenuBase::Init() #7 0x55b5dbced538 ChromeWebContentsViewDelegateViews::BuildMenu() #8 0x55b5dbced60f ChromeWebContentsViewDelegateViews::ShowContextMenu() #9 0x7f3dadfdf15f content::WebContentsImpl::ShowContextMenu() #10 0x7f3dadca1d3e content::RenderFrameHostImpl::OnContextMenu()
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9bbbe1a486850571e8ef8a8e0e3dd232e7632fa commit f9bbbe1a486850571e8ef8a8e0e3dd232e7632fa Author: Alan Cutter <alancutter@chromium.org> Date: Thu Mar 22 02:14:11 2018 Fix crash on unicode characters in PWA names in context menu Bug: 822144 Change-Id: I810ee10d0f428f8893d90281079341101d7d8c04 Reviewed-on: https://chromium-review.googlesource.com/963956 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#544949} [modify] https://crrev.com/f9bbbe1a486850571e8ef8a8e0e3dd232e7632fa/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/f9bbbe1a486850571e8ef8a8e0e3dd232e7632fa/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
,
Mar 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by alancutter@chromium.org
, Mar 15 2018