Enable scheme and www/m trimming omnibox experiments on Android |
|||||||||||||||
Issue descriptionPRD here: go/omnibox-ui-experiments-trim-displayed-url-on-blur Desktop toolbar model and Android diverged here: https://chromium-review.googlesource.com/c/chromium/src/+/876646 Initial steps to try this on Android is: replacing ToolbarModelAndroid::GetText to call GetURLForDisplay replace the text when focusing the omnibox with GetFormattedFullURL?
,
Mar 15 2018
tommycli@ - Are there experiments that we would need to gate the proposed changes in #0 against? Some field trial? Or is that in the internals of toolbar model itself?
,
Mar 15 2018
Hey Ted, please gate the change on: omnibox::kUIExperimentHideSteadyStateUrlSchemeAndSubdomains feature flag. We specifically did not gate it on the ToolbarModel itself, as it was an Omnibox experiment, and Toolbar seemed to be at a lower level than Omnibox.
,
Mar 16 2018
Note: please also implement on CCT if possible :)
,
Mar 16 2018
,
Mar 16 2018
I'm labelling this M67 since we're aiming to do this on desktop in M67 and it would be great to align. If that's not possible and we end up doing slightly subsequent releases I think it would be fine.
,
Mar 22 2018
,
Mar 22 2018
,
Mar 22 2018
,
Mar 22 2018
Uploading some screenshots of the CL: unfocused - Google.com w/ unfocused omnibox focus-initial-scroll - Tapped omnibox and auto-scrolled to the end (existing behavior) focus-scroll-to-beginning - Tapped omnibox and scrolled to the beginning manually and https is there cct - Custom tab loaded with google.com showing shortened URL
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d310777b21c40dc8a06a8b418efe6e77efc5a7a commit 4d310777b21c40dc8a06a8b418efe6e77efc5a7a Author: Ted Choc <tedchoc@google.com> Date: Fri Mar 23 18:56:25 2018 Add support for www/m trimming experiment to Android omnibox. BUG= 822137 Change-Id: I3b9bf9c5280599f061b3c22f78569d91b78d6168 Reviewed-on: https://chromium-review.googlesource.com/974647 Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545541} [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchBoxDataProvider.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarDataProvider.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarModelTest.java [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/browser/ui/android/toolbar/toolbar_model_android.cc [modify] https://crrev.com/4d310777b21c40dc8a06a8b418efe6e77efc5a7a/chrome/browser/ui/android/toolbar/toolbar_model_android.h
,
Mar 23 2018
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by tedc...@chromium.org
, Mar 15 2018