New issue
Advanced search Search tips

Issue 822135 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocking:
issue 523952



Sign in to add a comment

Show deprecation message of styling from HTML Imports when it's being applied

Project Member Reported by kochi@chromium.org, Mar 15 2018

Issue description

For  issue 523952 , we show deprecation message, targeting M67:

Prior to M65:

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.

Since M66:

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M67, around May 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.

This happens even when author applies a workaround to move <style>
element to document, because the message is shown when an import's
HTML is parsed, not when the style is applied.

This is happening on major Polymer sites including www.youtube.com
and users are sometimes confused.
(example: https://github.com/TakayoshiKochi/deprecate-style-in-html-imports/issues/5 )

 

Comment 1 by kochi@chromium.org, Mar 16 2018

Components: Blink>HTML>Modules
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows
Owner: yoichio@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by kochi@chromium.org, Jun 19 2018

@yoichio shall we close this bug?
Could you write down why this was technically infeasible as a record?
Status: WontFix (was: Assigned)
It turned out detecting if styles in imported documents applies to main document was complex.
We thought that StyleEngine::UpdateActiveStyleSheetsInImport was entry point
but since polymer's fix was moving styles after load, StyleEngine can
have active styles before the moving. There was race condition between
style computation and paint.
Another way is checking each style application on each element on-the-fly
but its is really heavy to just making deprecation message better.

Sign in to add a comment