New issue
Advanced search Search tips

Issue 822131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 752394
issue 828331



Sign in to add a comment

Implement ProceedWithResponse() for ServiceWorkerNavigationLoader

Project Member Reported by shimazu@chromium.org, Mar 15 2018

Issue description

We need to implement it before shipping S13nServiceWorker without NetworkService.


 

Comment 1 by falken@chromium.org, Mar 15 2018

Summary: Implement ProceedWithResponse() for ServiceWorkerNavigationLoader (was: Impelemt ProceedWithResponse() for ServiceWorkerNavigationLoader)

Comment 2 by shimazu@google.com, Apr 3 2018

Blocking: 828331

Comment 3 by shimazu@google.com, Apr 3 2018

Owner: shimazu@chromium.org
Status: Started (was: Available)
Started to see how it can be implemented.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca399a948c83ba4e9165402a9ba40567199b7577

commit ca399a948c83ba4e9165402a9ba40567199b7577
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Apr 05 07:56:43 2018

NetS13nServiceWorker: Remove NOTREACHED in ProceedWithResponse

ProceedWithResponse doesn't have to be implemented for
ServiceWorkerNavigationLoader since it's not using MojoAsyncResourceHandler.
This CL just removes the NOTREACHED() there.

Bug:  822131 
Change-Id: I5fb97dd8c0a0428b642f74368409b787e47f9315
Reviewed-on: https://chromium-review.googlesource.com/994496
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548364}
[modify] https://crrev.com/ca399a948c83ba4e9165402a9ba40567199b7577/content/browser/service_worker/service_worker_navigation_loader.cc

Status: Fixed (was: Started)

Sign in to add a comment