New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822130 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 845075



Sign in to add a comment

Increase test coverage of FileManagerPrivate API

Project Member Reported by sashab@chromium.org, Mar 15 2018

Issue description

The FileManagerPrivate API currently has some unit tests (e.g. /usr/local/google/home/sashab/code/chromeos-dev/src/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc), but not many. Investigate which tests already exist, and add new ones to increase coverage.
 
Once we have a list of required tests please shard out the implementations. 

Comment 2 by sashab@chromium.org, Mar 25 2018

Cc: -joelhockey@chromium.org sashab@chromium.org
Owner: joelhockey@chromium.org
Re-assigning to Joel - PTAL for M67.

Comment 3 by sashab@chromium.org, Mar 28 2018

Labels: -M-67 M-68

Comment 4 by sashab@chromium.org, Apr 12 2018

Owner: noel@chromium.org

Comment 5 by sashab@chromium.org, May 10 2018

Labels: -M-68 M-69

Comment 6 by sashab@chromium.org, May 21 2018

Labels: -Pri-1 Pri-2
Lowering priority to P2.

Comment 7 by sashab@chromium.org, May 21 2018

Would be great if we could get some data on our coverage dashboard, e.g.:

https://chromium-coverage.appspot.com/reports/559420/linux/chromium/src/cc/animation/report.html

Not suer how this report is generated :)

Comment 8 by noel@chromium.org, May 21 2018

See the post on chromium-dev Friday-last [1], about the new coverage tool.  It's meant to cover ChromeOS but I don't see out tests in reports as yet.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ewIXgtLncwI

Comment 9 by noel@chromium.org, May 25 2018

Cc: sa...@chromium.org

Comment 10 by noel@chromium.org, May 25 2018

Cc: joelhockey@chromium.org
Blockedon: 845075
Owner: dats@chromium.org
Assigning to sergei, who is working on tests for DriveFS. We should ensure we have good FMP API test coverage so we can catch any regressions DriveFS introduces.

Comment 13 by noel@chromium.org, May 29 2018

When we add new File Manager Private API ... need tests. And see also the tests in chrome/test/data/extensions/api_test/file_browser. These are browser tests, driven by external_filesystem_apitest.cc

  chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc

and in addition to the unit tests: file_manager_private_apitest.cc. HTH.
Project Member

Comment 14 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4268a4de0dfd26787354ecab6e1298d1c04cf15

commit b4268a4de0dfd26787354ecab6e1298d1c04cf15
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu May 31 05:13:59 2018

Add a fileManagerPrivate.isCrostiniEnabled test

Additional test for fileManagerPrivate.mountCrostiniContainer
will be added to these files next.

Bug:  845075 , 822130
Change-Id: I8e4fbb840764e975b5d670556905f3b4b411f2da
Reviewed-on: https://chromium-review.googlesource.com/1075878
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563153}
[modify] https://crrev.com/b4268a4de0dfd26787354ecab6e1298d1c04cf15/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[add] https://crrev.com/b4268a4de0dfd26787354ecab6e1298d1c04cf15/chrome/test/data/extensions/api_test/file_browser/crostini_test/manifest.json
[add] https://crrev.com/b4268a4de0dfd26787354ecab6e1298d1c04cf15/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/817a0f93053534947536a8c98811aa541f5e9926

commit 817a0f93053534947536a8c98811aa541f5e9926
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Jun 01 01:35:50 2018

fileManagerPrivate.mountCrostiniContainer test

* Added CrostiniManager::SkipRestartForTesting
  to bypass component loading and starting
  concierge to start VM and container.
* Added MockDiskMountManager::NotifyMountEvent
  to trigger OnMountEvent to observers.

Bug:  845075 
Bug: 822130
Change-Id: Ifd9464730c6cd50a683cc40f60a289c80a36158c
Reviewed-on: https://chromium-review.googlesource.com/1080487
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563476}
[modify] https://crrev.com/817a0f93053534947536a8c98811aa541f5e9926/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/817a0f93053534947536a8c98811aa541f5e9926/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/817a0f93053534947536a8c98811aa541f5e9926/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/817a0f93053534947536a8c98811aa541f5e9926/chrome/test/data/extensions/api_test/file_browser/crostini_test/manifest.json
[modify] https://crrev.com/817a0f93053534947536a8c98811aa541f5e9926/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/817a0f93053534947536a8c98811aa541f5e9926/chromeos/disks/mock_disk_mount_manager.cc
[modify] https://crrev.com/817a0f93053534947536a8c98811aa541f5e9926/chromeos/disks/mock_disk_mount_manager.h

Labels: -M-69 M-70
Cc: mmoroz@chromium.org
re c#7, the test needs to be added to https://cs.chromium.org/chromium/src/tools/code_coverage/test_suite.txt so that code coverage bots would run it
Labels: -M-70 M-71
Labels: -M-71

Sign in to add a comment