New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822123 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 809281



Sign in to add a comment

Hosted app windows: Hidden elements accessible through tab order

Project Member Reported by mgiuca@chromium.org, Mar 15 2018

Issue description

Chrome Version: 66
OS: Chrome

What steps will reproduce the problem?
(1) Open a hosted / bookmark / PWA app window (e.g., Google Santa Tracker, installed).
(2) Press Tab to cycle through all the controls in the page, and then one more.
(3) Press Space. Opens the (hidden) page info popup.
(4) Press Tab. Opens the (hidden) Omnibox. Navigation is disabled.

What is the expected result?
The page info popup and address bar are not addressable in the tab order.

What happens instead?
These controls are addressable in the tab order.
 

Comment 1 by mgiuca@chromium.org, Mar 26 2018

Labels: M-67
Labels: -Pri-3 Pri-2
This is more important than P3.
Labels: -Pri-2 Pri-1
Accessibility.
Cc: alancutter@chromium.org
Owner: ortuno@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d052d4edfdd662d01910ae8b707f1a472585c13a

commit d052d4edfdd662d01910ae8b707f1a472585c13a
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Thu Apr 12 08:14:00 2018

desktop-pwas: Set the visibility of the View when the location bar shows/hides

Changes LocationBarView to also update its visibility based on the
animation state. Before this patch, we would only update the height of
the view which resulted in the LocationBarView's elements to still
be focusable, even when the bar was supposed to be hidden.

Bug:  822123 
Change-Id: If8188bb11d5971072192036a4c644e3d3fb5e489
Reviewed-on: https://chromium-review.googlesource.com/1003932
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550097}
[modify] https://crrev.com/d052d4edfdd662d01910ae8b707f1a472585c13a/chrome/browser/ui/browser_focus_uitest.cc
[modify] https://crrev.com/d052d4edfdd662d01910ae8b707f1a472585c13a/chrome/browser/ui/views/location_bar/location_bar_view.cc

Comment 7 by mgiuca@chromium.org, Apr 12 2018

Status: Fixed (was: Started)

Sign in to add a comment