Where is your original doc approved by privacy? Can you share the link and also mark where you are modifying?

Form Interactions UKM was one of the first UKMs added. It was before we had a process for privacy review of new metric.

It was added in crbug/709530.

I can briefly describe the metric:- 

Autofill_FormSubmitted is recorded when autofill detects form submit on a page. Following additional data is recorded with form submits -

AutofillFormSubmittedState - Enum storing one of the values, all fields were autofill, some field were autofill, no field were autofilled, form was not fillable.

MillisecondsSinceFormParsed - Time since form parse.

I am proposing to add form_type information to this. Form type is one of the 3 values CreditCard, Password and Profile.

This metric doesn't add any new data. This data is already available through other fields. e.g IsForCreditCard is available in Autofill_InteractedWithForm, Password type is present through various Password related UKM. Having this directly in FormSubmitted will simplify querying for number of form submits for each of the form type.

Thanks to help from holte@ I was able to find the initial review doc. Although this is in different format -

https://docs.google.com/document/d/1M5hkTc4ZEUwKeCqBXGQBvVktdX8zpx1loxnXv6BrCNs/edit#heading=h.bzl43651yhcs

The section is "Credit Card and Address Form Interactions"

It looks like original design envisioned adding form_type (Credit card vs Address form). Although this wasn't implemented.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47b4ea743a10764e2855b070efe9922efec272fa

commit 47b4ea743a10764e2855b070efe9922efec272fa
Author: Nikunj Bhagat <nikunjb@chromium.org>
Date: Thu Apr 12 08:29:49 2018

Add Credit card to form submit.


Bug:  822100 
Change-Id: Idf29d6ea4648dcdf65620fe406441f2983a0a8f6
Reviewed-on: https://chromium-review.googlesource.com/963843
Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550105}
[modify] https://crrev.com/47b4ea743a10764e2855b070efe9922efec272fa/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/47b4ea743a10764e2855b070efe9922efec272fa/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/47b4ea743a10764e2855b070efe9922efec272fa/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/47b4ea743a10764e2855b070efe9922efec272fa/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/47b4ea743a10764e2855b070efe9922efec272fa/tools/metrics/ukm/ukm.xml