[VR browsing] Video player's 2D Cast UI dialog not suppressed |
||||||
Issue descriptionChrome Version: 66.0.3359.31 VRCore: 1.13.185188193 OS: Android N Device: Galaxy S8+ What steps will reproduce the problem? enable flags: vr-browsing-native-android-ui vr-web-input-editing *Doesn't repro without these flags This test also requires that a Chromecast device is available on the local network. (1) go to m.youtube.com (2) enter VR browsing (3) select any video (4) click cast icon in video player What is the expected result? 2D Cast dialog is suppressed. What happens instead? 2D Cast dialog appears breaking VR experience. See screenshot. For the manual testing plan: I always click on the Cast icon to test it, but I don't think we have a specific test written. We probably want to add it, maybe to an existing test case.
,
Mar 21 2018
,
Mar 21 2018
could this also be tied to crbug.com/809021 ? part of that effort is to also disable cast functionality.
,
Mar 30 2018
No, but it is part of crbug.com/683352? - Suppress Cast icon in default video controls when in VR I have verified that the bug is fixed and the Cast To option is no longer available. Thus blocking this issue.
,
Mar 30 2018
Issue 683352 just removes the Cast icon from the default media controls. Apps can still trigger the UI using the Presentation API (i.e., from their own custom controls). dailymotion.com can be used to repro this. I just caused the 2D UI on dailymotion.com in 67.0.3384.0. There is also the Remote Playback API. The samples at https://www.chromestatus.com/features/5778318691401728 may be useful for testing. Related issues: * issue 733410 - original disabling of the feature * issue 738196 * issue 738202
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad11084ac45eb15a7b8b81f98862e56c6f465a6a commit ad11084ac45eb15a7b8b81f98862e56c6f465a6a Author: Amirhossein Simjour <asimjour@chromium.org> Date: Tue Apr 10 23:30:14 2018 Close cast dialog in VR Cast dialog was enabled behind a flag in VR. It was a mistake since, the same flag is used to enable some other popups. We should enable cast icon once we VR can support this dilog. Bug: 822090 Change-Id: I6c414f85d7b24a0f5dfaea4d37d541268abb4556 Reviewed-on: https://chromium-review.googlesource.com/1006037 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#549675} [modify] https://crrev.com/ad11084ac45eb15a7b8b81f98862e56c6f465a6a/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
,
Apr 11 2018
,
Apr 23 2018
Checked both Dailymotion and YouTube with 67.0.3396.16. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yfried...@chromium.org
, Mar 15 2018Owner: asimjour@chromium.org
Status: Assigned (was: Untriaged)