New issue
Advanced search Search tips

Issue 822083 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-20
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/FileAPI by import https://crrev.com/c/963500

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Mar 15 2018

Issue description

WPT import https://crrev.com/c/963500 introduced new failures in external/wpt/FileAPI:

List of new failures:
external/wpt/FileAPI/FileReader/workers.html new failing tests: https://crrev.com/c/963500/4/third_party/WebKit/LayoutTests/external/wpt/FileAPI/FileReader/workers-expected.txt

This import contains upstream changes from 3686c5fe05978d9c7f62a5b66b6752a9f9aeaa75 to b229e33b76e3b705f9eb71957b30c9988d510572:
Don't use external server in CSS tables test,: https://github.com/w3c/web-platform-tests/commit/b229e33b76e3b705f9eb71957b30c9988d510572
Add web platform test for uploading a file through a form.: https://github.com/w3c/web-platform-tests/commit/7743b48b702dc4e25ec25ba4cbe59ebf41f5490a
Use WorkerRef in FileReader, bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436784 gecko-commit: 7344e313e2e9f32118ceb5a7aab1e93e2b4c2f8f gecko-integration-branch: central gecko-reviewers: smaug: https://github.com/w3c/web-platform-tests/commit/4fa21650e08d4f84e6b6bf5c6db1770f6c9f1455 [affecting this directory]
Use WorkerRef in WebSocket, bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436784 gecko-commit: b59d4d53efd636b5d0ccd4287d44bdc269e77dab gecko-integration-branch: central gecko-reviewers: smaug: https://github.com/w3c/web-platform-tests/commit/9ffd2c408a81528670e1de0ca40a348919daf843
Use WorkerRef in BroadcastChannel and MessagePort, bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1436784 gecko-commit: fd00b80ae9b7a48d67af6645305917a7147fb8ac gecko-integration-branch: central gecko-reviewers: smaug: https://github.com/w3c/web-platform-tests/commit/c4ea3b307a9aa71f11d1f1c1a2ffccd9ba862ba1
Correctly compare height in open-features-non-integer-height.html test. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1445509 gecko-commit: 870ccf04f6aab961a02549c9dbe144c5c1d7d072 gecko-integration-branch: central gecko-reviewers: bz: https://github.com/w3c/web-platform-tests/commit/6abf7227e4de6116d16df1c1be1447cb5f4881d0
Update the feature-policy IDL file (#9783): https://github.com/w3c/web-platform-tests/commit/e4b9ecc4e150f2616a4b6f1dd8b9239433956517
Update links in IndexedDB's README: https://github.com/w3c/web-platform-tests/commit/68f88af092394d6863bb5a63b364479146ec1283
Add a WPT test for calc font-variation-settings.: https://github.com/w3c/web-platform-tests/commit/09e44d1f1b46d90613f589487d7c3248cfbc0893
Snap Point selection should satisfy visibility requirement.: https://github.com/w3c/web-platform-tests/commit/343fd25cd72c64ed30da54b650220cca7338cd57
Remove duplicate code: https://github.com/w3c/web-platform-tests/commit/ec54ac4479d66e039809ac65026a12eb9529d34a
Rename bind_hostname to bind_address: https://github.com/w3c/web-platform-tests/commit/24da741d3c5bba4110f590c1faf771596d543482
[Beacon API] Port beacon-cross-origin.https.html to wpt: https://github.com/w3c/web-platform-tests/commit/88e7f59976ad727b77d6fb1380ef5765762ae899
Add README file for entries-api: https://github.com/w3c/web-platform-tests/commit/77530f262b327b5e74e84337c1c8d7b8e82972aa
Stop running Chrome wptrunner infrastructure tests for bustage: https://github.com/w3c/web-platform-tests/commit/17dd2c43fad3aa637398dc5da918db9950bcdcc3
Exit wptrunner with an error status if no tests ran: https://github.com/w3c/web-platform-tests/commit/d0a30f8821e50ad1d61fda745453810c8c53a17e
Fix a link to the README in the documentation.: https://github.com/w3c/web-platform-tests/commit/a656fe777e17de3c4be1d0ea81b66acde3529156
Remove redundant importScript bits from a .any.js test (#10033): https://github.com/w3c/web-platform-tests/commit/bd1994b0b1ab35ffddf535045009dc4055bc5cce
Merge pull request #10032 from mrego/css-align-prefix-gutter: https://github.com/w3c/web-platform-tests/commit/e3d85cec3b11ef2b9c878eddff0cd2d44809c1ef
Replace a lonely domstringlist.idl with filtering html.idl: https://github.com/w3c/web-platform-tests/commit/93beb831be6e9fd1c059333eca0d2cc4a16c2470
Add a lint to catch adding files that would otherwise be ignored by git.: https://github.com/w3c/web-platform-tests/commit/a956588de9d51723e44f82262ed817f9b803d956
Update the screen-orientation IDL file (#9827): https://github.com/w3c/web-platform-tests/commit/6534d852f8bcef689ffa4023325c8cbaa71cdf9c
[css-align] Use actual prefixed properties in the grid-* gutter tests: https://github.com/w3c/web-platform-tests/commit/7278d99a68da4b055807c635a9e710207565fc8b
Move reference file: https://github.com/w3c/web-platform-tests/commit/7d1bf740cf22612d712e15c6e50be43324c77228
Address reviewer comments: https://github.com/w3c/web-platform-tests/commit/8e84ffc2c96f52967533f3cabb1a8ab80a98e6fe
Add test for whitespace: nowrap and float:left: https://github.com/w3c/web-platform-tests/commit/c221fc79aacacd1d3e1fa12b50c6f5213ad720fc
[css-grid] Add support for calc() in gutter properties: https://github.com/w3c/web-platform-tests/commit/f721ccc131535df0ba4cf1dc9eddbbe1a13858eb
Adjust MathML tests to Workaround WebKit's bug with document.fonts.ready (#10025): https://github.com/w3c/web-platform-tests/commit/716fa061d4296f6cd39cb5f8353e64e3222e7707

 

Comment 1 by mek@chromium.org, Mar 15 2018

That looks like the test using non standard Firefox only methods... What's the procedure for dealing with incorrect tests like this?
I was about to say comment on their bug https://bugzilla.mozilla.org/show_bug.cgi?id=1436784 but saw you already did that.

Let's wait a few days and hopefully they reply. It's really case-by-case and the process is usually more about communication I think. I'm not familiar with the particular API, but:
* If this is testing something currently being discussed in spec, it should be named as .tentative.
* If the non-standard API is just used accidentally and there is obvious standard alternative, we should go ahead and fix the test.

Comment 3 by mek@chromium.org, Mar 15 2018

This is more the second case (the use of the non-standard API arguably makes it slightly easier to write the test since they can have the body of the worker as a js function rather than a js string, but that's about it...), but yeah, lets wait for them to hopefully fix it.

Comment 4 by mek@chromium.org, Mar 15 2018

NextAction: 2018-03-20
Status: ExternalDependency (was: Untriaged)

Comment 5 by mek@chromium.org, Mar 19 2018

Status: Fixed (was: ExternalDependency)
Seems to be fixed by todays import.
The NextAction date has arrived: 2018-03-20
Components: Blink>Storage>FileAPI
Components: -Blink>FileAPI

Sign in to add a comment