Related / xref:  issue 822000 

+cc tommycli@ since he's working on omnibox shadows in case it happens to overlap

xref crrev.com/c/978590

Taking this.

The shadows should be small enough they don't need to be click-through-able, since that is probably out of scope.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cd88c77b560468f1d41938f8d653fd0a22c4232

commit 8cd88c77b560468f1d41938f8d653fd0a22c4232
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed May 30 18:58:26 2018

Update shadows for bubbles and dialogs for Refresh.

This patch introduces a new function MakeRefreshShadowValues, intended
to eventually replace the existing MakeMdShadowValues, and adds the
elevation used for for dialogs and bubbles. It does not add shadow
values for other elevations, instead it will fall back to
MakeMdShadowValues.

This patch also gives bubbles and dialogs a corner radius and elevation
pre-Refresh. This will cause a small visual change.

Bug: 822075
Change-Id: Ib3bd03dc1c1e7a63b7fba84c72e6c6430c03e0df
Reviewed-on: https://chromium-review.googlesource.com/1070566
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562942}
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/chrome/browser/ui/views/harmony/material_refresh_layout_provider.h
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/ui/gfx/shadow_value.cc
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/ui/gfx/shadow_value.h
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/ui/views/layout/layout_provider.h
[modify] https://crrev.com/8cd88c77b560468f1d41938f8d653fd0a22c4232/ui/views/window/dialog_delegate.cc

r562942 has apparently forced thick nonremovable 4px borders on extension popups (8px in the upcoming "refresh"), which looks unpolished with dark themes, even ugly (see the attachments). Should I open a new issue?

Deleted: 4px normal top-ui.png 16.9 KB

	4px normal top-ui.png 16.9 KB View Download

Deleted: 8px refresh top-ui.png 4.9 KB

	8px refresh top-ui.png 4.9 KB View Download

#13: Yes, please open a new bug and cross-link here. That was not intentional.

Done:  bug 849802 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba30493edf9b0417de03cae95f6da4815e4c3ec8

commit ba30493edf9b0417de03cae95f6da4815e4c3ec8
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jun 13 18:36:27 2018

Revert increased corner radius and shadows for Refresh.

This caused some issues and we don't have time to address them for M69.
For example:  crbug.com/849802 ,  crbug.com/851852 ,  crbug.com/848164 .

Bug: 822075
Change-Id: I2b318ea6a9ff0b05120b21262088f6fbe2c3df10
Reviewed-on: https://chromium-review.googlesource.com/1098376
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566931}
[modify] https://crrev.com/ba30493edf9b0417de03cae95f6da4815e4c3ec8/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/ba30493edf9b0417de03cae95f6da4815e4c3ec8/ui/views/window/dialog_delegate.cc

Reverted for 69

Cross-link  bug 848300  as well.