New issue
Advanced search Search tips

Issue 822073 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: 7
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 821991


Show other hotlists

Hotlists containing this issue:
Gm2-bugs-ready-for-UX-review


Sign in to add a comment

Update alternate states for buttons in secondary UI

Project Member Reported by pbos@chromium.org, Mar 15 2018

Issue description

MDTextButton and friends (checkboxes etc) need to be updated to a new style for the MD refresh.
 

Comment 1 by pbos@chromium.org, Mar 15 2018

Labels: Proj-MdRefresh
Owner: kylixrd@chromium.org
Status: Assigned (was: Available)

Comment 3 by bettes@chromium.org, Apr 19 2018

From go/chrome-ux-gm2:
https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g34d24941d1_37_5
Screen Shot 2018-04-18 at 4.59.39 PM.png
86.4 KB View Download
Screen Shot 2018-04-18 at 4.59.41 PM.png
114 KB View Download

Comment 4 by bettes@chromium.org, Apr 20 2018

Note that the headers to those images say WebUI, but they're really for Secondary UI

Comment 5 by bsep@chromium.org, Apr 25 2018

Owner: bsep@chromium.org
Taking this.
Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f924b3a7c4363535f7bbda769afae492d29f36b

commit 7f924b3a7c4363535f7bbda769afae492d29f36b
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed May 02 23:59:00 2018

Change button size and corner radius for MD Refresh.

This updates MdTextButton to draw 32dips high and with 4dip corner
radii when refresh is on. Also updates LayoutProvider::
GetControlHeightForFont even though it's not used by MdTextButton, to
avoid the two getting out of sync. Also moves empahsis methods to
LayoutProvider so that general views code can access them.

Bug: 822073
Change-Id: Ia3038ccafdddd79ca42837dc1de4f726894377e2
Reviewed-on: https://chromium-review.googlesource.com/1031551
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555614}
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/chrome_layout_provider.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/chrome_layout_provider.h
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/material_refresh_layout_provider.h
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/test/base/view_event_test_base.h
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/controls/button/md_text_button.h
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/layout/layout_provider.h

Cc: ftirelo@chromium.org
EstimatedDays: 4
bsep@: what's left here?

Comment 10 by bsep@chromium.org, May 31 2018

#9: Colors and alternate states. This can be downscoped quite a bit if needed.
Summary: Update alternate states for buttons in secondary UI (was: Update button look for secondary UI MD refresh)
Triage: updated title to reflect remaining work.

bsep@ can you please update remaining time?

Comment 12 by bsep@chromium.org, Jun 7 2018

EstimatedDays: 7
Based on how long the first, "easy" part took the current estimate was probably optimistic.
Labels: M-70
Labels: -M-70 Group-Dialogs
Labels: M-70
Labels: Target-70
Labels: -M-70 -Target-70 M-71 Target-71
Labels: -Proj-MdRefresh Proj-DesktopUI
Labels: Hotlist-DesktopUITriaged
Labels: -M-71 -Target-71 M-72 Target-72
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
*** UI Mass Triage ***

Adding appropriate label for expert review.
Labels: -M-72 -Target-72 M-73 Target-73

Sign in to add a comment