Update alternate states for buttons in secondary UI |
|||||||||||||||||
Issue descriptionMDTextButton and friends (checkboxes etc) need to be updated to a new style for the MD refresh.
,
Mar 26 2018
,
Apr 20 2018
Note that the headers to those images say WebUI, but they're really for Secondary UI
,
Apr 25 2018
Taking this.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f924b3a7c4363535f7bbda769afae492d29f36b commit 7f924b3a7c4363535f7bbda769afae492d29f36b Author: Bret Sepulveda <bsep@chromium.org> Date: Wed May 02 23:59:00 2018 Change button size and corner radius for MD Refresh. This updates MdTextButton to draw 32dips high and with 4dip corner radii when refresh is on. Also updates LayoutProvider:: GetControlHeightForFont even though it's not used by MdTextButton, to avoid the two getting out of sync. Also moves empahsis methods to LayoutProvider so that general views code can access them. Bug: 822073 Change-Id: Ia3038ccafdddd79ca42837dc1de4f726894377e2 Reviewed-on: https://chromium-review.googlesource.com/1031551 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555614} [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/chrome_layout_provider.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/chrome_layout_provider.h [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/material_refresh_layout_provider.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/harmony/material_refresh_layout_provider.h [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/tabs/new_tab_button.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/chrome/test/base/view_event_test_base.h [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/controls/button/md_text_button.h [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/layout/layout_provider.cc [modify] https://crrev.com/7f924b3a7c4363535f7bbda769afae492d29f36b/ui/views/layout/layout_provider.h
,
May 23 2018
,
May 29 2018
,
May 31 2018
bsep@: what's left here?
,
May 31 2018
#9: Colors and alternate states. This can be downscoped quite a bit if needed.
,
Jun 7 2018
Triage: updated title to reflect remaining work. bsep@ can you please update remaining time?
,
Jun 7 2018
Based on how long the first, "easy" part took the current estimate was probably optimistic.
,
Jun 28 2018
,
Jul 12
,
Jul 12
,
Jul 26
,
Aug 27
,
Sep 20
,
Sep 26
,
Oct 11
,
Nov 22
*** UI Mass Triage *** Adding appropriate label for expert review.
,
Dec 11
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by pbos@chromium.org
, Mar 15 2018