BrowserNavigatorTest.SingletonProfileLeak and 2 other(s) in browser_tests failing on chromium.win/Win7 Tests (dbg)(1) |
|||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@chromium.org BrowserNavigatorTest.SingletonProfileLeak and 2 other(s) in browser_tests failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 [ RUN ] BrowserNavigatorTest.SingletonProfileLeak [5484:2640:0312/183608.393:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [5484:4468:0312/183608.705:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=BrowserNavigatorTest.SingletonProfileLeak --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir876_19668\results876_8905\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iog_5cgu\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir876_19668\d876_25533" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [6388:428:0312/183609.329:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported. [6652:4384:0312/183610.345:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [7128:2584:0312/183612.878:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [6228:5172:0312/183615.126:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [5484:4468:0312/183617.417:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M67, around May 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [6544:4976:0312/183634.271:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [6968:6436:0312/183636.287:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [5976:3604:0312/183637.484:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [5484:4468:0312/183638.451:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M67, around May 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [2352:6148:0312/183642.671:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [5544:3120:0312/183644.745:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [4128:4852:0312/183644.884:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [5484:4468:0312/183645.254:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M67, around May 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [6576:4608:0312/183647.011:ERROR:runtime_enabled_features.cc(1447)] RuntimeEnabledFeature not recognized: VibrateRequiresUserGesture [5484:4468:0312/183648.012:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M67, around May 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [377/378] BrowserNavigatorTest.SingletonProfileLeak (TIMED OUT)
,
Mar 15 2018
,
Mar 15 2018
,
Mar 15 2018
It's a long test that I recently added some synchronization to. I can look into splitting it, or disabling it.
,
Mar 15 2018
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48f8020636690af5737b6cecb02b569ea8e7642b commit 48f8020636690af5737b6cecb02b569ea8e7642b Author: Kevin Bailey <krb@chromium.org> Date: Fri Mar 16 14:29:52 2018 [omnibox browser test] Split up test and narrow waiting I suspect that a test wasn't timing out due to slowness, but in fact because a SINGLETON navigation was switching instead, and not waking up waiting observers. This CL adds an explicit 'wait' parameter for choosing (instead of relying on disposition). It also splits up the respective test into SINGLETON and SWITCH_TO_TAB versions (they're orthogonal) and cleans up some comments. Bug: 822071 Change-Id: I241478b7a566b0e843f92b091d8f090ffbf9011c Reviewed-on: https://chromium-review.googlesource.com/964386 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#543695} [modify] https://crrev.com/48f8020636690af5737b6cecb02b569ea8e7642b/chrome/browser/ui/browser_navigator_browsertest.cc [modify] https://crrev.com/48f8020636690af5737b6cecb02b569ea8e7642b/chrome/browser/ui/browser_navigator_browsertest.h
,
Mar 19 2018
krb@: Both the introduced tests still seem to flake/timeout on Win 7 dbg. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=SingletonIncognitoLeak and https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=SwitchToTabIncognitoLeak. Do you have a resolution in mind, else this'll need to be disabled on Win Dbg bots.
,
Mar 19 2018
Hi karandeepb@, I had hoped to fix the issue with that CL. When I get my Windows machine re-built, I can take another run at it, but for now, disabling on the platform seems wise.
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c5a9f98d3809da6a12843660947f8cad3d7633d commit 3c5a9f98d3809da6a12843660947f8cad3d7633d Author: Karan Bhatia <karandeepb@chromium.org> Date: Mon Mar 19 21:57:24 2018 Disable some flaky BrowserNavigatorTest(s) on Windows Debug bots. BUG= 822071 TBR=pkasting@chromium.org, krb@chromium.org Change-Id: I57ea1d13d8f859cd3bcf9f3c192781b48c748dd5 Reviewed-on: https://chromium-review.googlesource.com/969592 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544177} [modify] https://crrev.com/3c5a9f98d3809da6a12843660947f8cad3d7633d/chrome/browser/ui/browser_navigator_browsertest.cc
,
Mar 19 2018
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99bae2e9b0362881734f5632e4893cc85de564d0 commit 99bae2e9b0362881734f5632e4893cc85de564d0 Author: Kevin Bailey <krb@chromium.org> Date: Wed Aug 08 18:38:37 2018 [omnibox] Re-enable long-running singleton and switch-to-tab tests The singleton/switch-to-tab browser tests, which happened to load Maps and chrome://settings, were taking so much time, that on Windows, they were timing out. By using simpler sites and loading settings asynchronously, the time is cut in half. Bug: 822071 Change-Id: I73e6de0e8a7c13e1670c8daa76d18c2acb9cc9d4 Reviewed-on: https://chromium-review.googlesource.com/1165797 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581638} [modify] https://crrev.com/99bae2e9b0362881734f5632e4893cc85de564d0/chrome/browser/ui/browser_navigator_browsertest.cc
,
Aug 9
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by crouleau@chromium.org
, Mar 15 2018