New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 822068 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

X11 linux should respect iCC profiles for secondary screens

Project Member Reported by hubbe@chromium.org, Mar 14 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b2841f34cb726c6472a72604481215829266d6e

commit 6b2841f34cb726c6472a72604481215829266d6e
Author: Fredrik Hubinette <hubbe@google.com>
Date: Tue Apr 03 21:31:43 2018

Read per-display ICC profiles on linux.
For future reference, the correct "order" of monitors in X11
is the one given by xrandr --listmonitors

Bug:  822068 
Change-Id: I6ceedc8db1d381ab3955af584fd365a764910ea7
Reviewed-on: https://chromium-review.googlesource.com/972547
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547839}
[modify] https://crrev.com/6b2841f34cb726c6472a72604481215829266d6e/ui/views/widget/desktop_aura/desktop_screen_x11.cc
[modify] https://crrev.com/6b2841f34cb726c6472a72604481215829266d6e/ui/views/widget/desktop_aura/desktop_screen_x11.h

Comment 2 by hubbe@chromium.org, Apr 3 2018

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9ccc2a8c1dd5dd079791b83267daeccf5d6d62d

commit a9ccc2a8c1dd5dd079791b83267daeccf5d6d62d
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Apr 04 01:12:13 2018

[jumbo] X11/gfx: Need to say ::Display or it's ambiguous.

There are several classes/types named Display so to get
the X11 one, you have to specify it with ::Display (gfx::Display
is a common alternative when you're inside the gfx namespace).

TBR=hubbe@google.com

Bug:  822068 
Change-Id: I402b7ad2d37a82d3091577733f3f06e673c29c7e
Reviewed-on: https://chromium-review.googlesource.com/994212
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#547916}
[modify] https://crrev.com/a9ccc2a8c1dd5dd079791b83267daeccf5d6d62d/ui/views/widget/desktop_aura/desktop_screen_x11.cc

Sign in to add a comment