Update tab loading animation for MD refresh |
|||||||||||||||||||||
Issue descriptionNew tab animation, see spec.
,
Mar 26 2018
,
Apr 3 2018
,
Apr 24 2018
I'll start taking a stab at this.
,
May 29 2018
,
May 31 2018
Update estimated days remaining, please.
,
Jun 7 2018
Ping. See C#7.
,
Jun 7 2018
Sure, I think it's fair as a P2 though, but we need it for release.
,
Jun 28 2018
Bumping this to M70.
,
Jun 28 2018
I'm still a good owner since I have started, so taking back and adding more padding. :)
,
Jul 12
,
Jul 26
,
Aug 20
,
Aug 21
,
Sep 13
,
Sep 20
,
Sep 26
,
Oct 11
,
Oct 19
,
Oct 19
Duping these feels like a bugmorph of the other bug. This bug is mostly about visual appearance and that bug is, at least originally, about showing the spinner less often. Are we still capturing the "change when this shows" aspect on the other bug?
,
Oct 19
,
Oct 19
,
Oct 19
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3 commit 18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3 Author: Peter Boström <pbos@chromium.org> Date: Wed Oct 31 19:03:50 2018 Create new tab-loading animation This implements three parts of the new tab-loading animation: * Bottom bouncing pill of the indeterminate waiting state. * Painting the loading state. * Fading out the loading state animation once progress hits 100%. This also makes all BrowserView tab animations' indeterminate state run off of the same timer so this animation stays in sync across multiple tabs. This timer restarts every time the animation timer starts, so the first visible animation starts at 0 but following ones use the same elapsed time as the already-running one. Bug: chromium:822067 Change-Id: I7f5c38a92dc26556d11a01765831497027913f38 Reviewed-on: https://chromium-review.googlesource.com/c/1060605 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604356} [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/browser.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/browser.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab_icon.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab_icon.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab_renderer_data.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab_renderer_data.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/browser/ui/views/tabs/tab_unittest.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/common/chrome_features.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/chrome/common/chrome_features.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/content/browser/frame_host/frame_tree.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/content/public/browser/web_contents.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/ui/gfx/color_palette.h [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/ui/gfx/paint_throbber.cc [modify] https://crrev.com/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3/ui/gfx/paint_throbber.h
,
Nov 1
Landed in Canary, I'm expecting us to have to do various levels of polish and issue fixes, but I think those should be separate bugs once they appear. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pbos@chromium.org
, Mar 15 2018