New issue
Advanced search Search tips

Issue 822059 link

Starred by 2 users
Status: Fixed
Owner:
x...@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cros splitscreen - crash when adding a snapped window to the overview grid

Project Member Reported by x...@chromium.org, Mar 14 2018 
Chrome Version: 67.0.3371.0
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Have two windows open in tablet mode
(2) Tap on the overview button to enter overview mode, snap one window to left and one window to right
(3) Tap on the overview button again to enter overview mode
(4) Tap on the split divider to move toward closing the snapped window, and now the snapped window returned back to the overview window grid 
(5) Tap on the overview button again to exit overview mode

What is the expected result?
Overview mode is ended without any crash

What happens instead?
The DCHECK failed in WindowSelector::Shutdown(): 
DCHECK(num_items_ >= remaining_items);
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b647c5c03542d54fddee1d4970498b4627f55fd7

commit b647c5c03542d54fddee1d4970498b4627f55fd7
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Fri Mar 16 06:18:10 2018

Update overview items numbers when adding/removing a window item.

Because of splitscreen, it's now possible to remove an overview window
item to snap in splitscreen, or to add an overview window item from one
of the snapped windows in splitscreen, we should update the overview
items in these two cases. Otherwise in WindowSelector::Shutdown(), the
DCHECK(num_items_ >= remaining_items) might fail and the UMA stat
Ash.WindowSelector.OverviewClosedItems might not record the correct
number.

Bug:  822059 
Change-Id: Ic60cd10a8e352bc6ea5c559b1d79f60dee7e81dd
Reviewed-on: https://chromium-review.googlesource.com/963723
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543638}
[modify] https://crrev.com/b647c5c03542d54fddee1d4970498b4627f55fd7/ash/wm/overview/window_selector.cc

Comment 2 by x...@chromium.org, Mar 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment