New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 822058 link

Starred by 2 users
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
█ xunji...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

services_unittests (iPad Air 2 iOS 10.0) timing out on chromium.mac/ios-simulator

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Mar 14 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@chromium.org

services_unittests (iPad Air 2 iOS 10.0) failing on chromium.mac/ios-simulator

Builders failed on: 
- ios-simulator: 
  https://build.chromium.org/p/chromium.mac/builders/ios-simulator

services_unittests (iPad Air 2 iOS 10.0) services_unittests (iPad Air 2 iOS 10.0)
Test timed out. 

timed out after 12 minutes. on previous build this step took 0 seconds.

Comment 1 by crouleau@chromium.org, Mar 14 2018 

Timing out while running 
[ RUN      ] TCPSocketTest.ReadAndWriteMultiple

Comment 3 by crouleau@chromium.org, Mar 14 2018

Components: Internals>Network
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94

commit d27e71f2fea189d519f1b24dda0aa55d1c1b3c94
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Wed Mar 14 23:45:51 2018

Revert "Reland: Add TCP socket API to network service"

This reverts commit a8cf1a861b668acb63e6616a136268b3aa907d6d.

Reason for revert: added faking test case TCPSocketTest.ReadAndWriteMultiple

BUG:  822058 

Original change's description:
> Reland: Add TCP socket API to network service
> 
> This CL adds TCP socket API to network service.
> This is partly based on mandoline implementation
> (https://codereview.chromium.org/1873463003/)
> 
> Two TCP socket interfaces are added.
> - TCPConnectedSocket
> - TCPServerSocket
> 
> Change in reland:
> - adds logging to TCPSocketTest.ReadAndWriteMultiple to investigate
>   the test timeout observed in  crbug.com/821232 
> - Modifies TestServer slightly to own all client connections instead
>   of only the latest one.
> 
> R=​mmenke@chromium.org
> TBR=miu@chromium.org
> TBR=tsepez@chromium.org
> 
> Bug:  721401 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I0426a7aeda30cce7a2a1e84afae5208958dc4a10
> Reviewed-on: https://chromium-review.googlesource.com/960250
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543064}

TBR=miu@chromium.org,mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org

Change-Id: I078642396307e5eb20853a12596d931e0bb30d88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  721401 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/963667
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543239}
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/BUILD.gn
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/network_context.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/network_context.h
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/public/mojom/network_service.mojom
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/public/mojom/tcp_socket.mojom
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/socket_factory.cc
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/socket_factory.h
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_connected_socket.cc
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_connected_socket.h
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_server_socket.cc
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_server_socket.h
[delete] https://crrev.com/14aced2aea8e21a9021118d3e42fcfe81779c019/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket.h
[add] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_factory.cc
[add] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_factory.h
[add] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_factory_unittest.cc
[modify] https://crrev.com/d27e71f2fea189d519f1b24dda0aa55d1c1b3c94/services/network/udp_socket_unittest.cc

Comment 5 by crouleau@chromium.org, Mar 14 2018

Cc: -crouleau@chromium.org
Labels: -Sheriff-Chromium
Owner: xunji...@chromium.org
Status: Assigned (was: Available)

Comment 6 by xunji...@chromium.org, Mar 15 2018 

Looks like base::RunLoop::RunUntilIdle() timed-out.

------
    // Test sending data multiple times from the client to server.
    for (size_t i = 0; i < arraysize(kTestMsg); ++i) {
      uint32_t num_bytes = 1;
      VLOG(0) << "Client writes byte " << i;
      EXPECT_EQ(MOJO_RESULT_OK,
                client_socket_send_handle->WriteData(
                    &kTestMsg[i], &num_bytes, MOJO_WRITE_DATA_FLAG_NONE));
      // Flush the 1 byte write.
      base::RunLoop().RunUntilIdle();
    }
    VLOG(0) << "Waiting for server to receive entire msg";
    read_run_loop.Run();
  }
------

Logs from the flaky run:
https://chromium-swarm.appspot.com/task?id=3c3f84650902f910&refresh=10&show_raw=1


[ RUN      ] TCPSocketTest.ReadAndWriteMultiple
[5158:1027:0314/154849.290550:5482461144280:INFO:tcp_socket_unittest.cc(508)] Server sends 0 to client
[5158:1027:0314/154849.290750:5482461274063:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.291170:5482461702783:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.291253:5482461777893:INFO:tcp_socket_unittest.cc(508)] Server sends 1 to client
[5158:1027:0314/154849.291368:5482461899347:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.291779:5482462315109:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.291880:5482462408941:INFO:tcp_socket_unittest.cc(508)] Server sends 2 to client
[5158:1027:0314/154849.292004:5482462551268:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.292457:5482463003129:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.292561:5482463081249:INFO:tcp_socket_unittest.cc(508)] Server sends 3 to client
[5158:1027:0314/154849.292673:5482463223392:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.293124:5482463662255:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.293219:5482463745435:INFO:tcp_socket_unittest.cc(508)] Server sends 4 to client
[5158:1027:0314/154849.293341:5482463868629:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.293792:5482464349805:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.293905:5482464433368:INFO:tcp_socket_unittest.cc(508)] Server sends 5 to client
[5158:1027:0314/154849.294024:5482464553520:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.294452:5482464985741:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.294539:5482465064702:INFO:tcp_socket_unittest.cc(508)] Server sends 6 to client
[5158:1027:0314/154849.294661:5482465168866:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.295068:5482465599447:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.295151:5482465680868:INFO:tcp_socket_unittest.cc(508)] Server sends 7 to client
[5158:1027:0314/154849.295273:5482465819305:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.295716:5482466241462:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.295794:5482466319163:INFO:tcp_socket_unittest.cc(508)] Server sends 8 to client
[5158:1027:0314/154849.295907:5482466430552:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.296309:5482466845232:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.296397:5482466925456:INFO:tcp_socket_unittest.cc(508)] Server sends 9 to client
[5158:1027:0314/154849.296514:5482467066170:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.296961:5482467498702:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.297054:5482467597267:INFO:tcp_socket_unittest.cc(508)] Server sends 0 to client
[5158:1027:0314/154849.297188:5482467726814:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.297639:5482468179160:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.297734:5482468282111:INFO:tcp_socket_unittest.cc(508)] Server sends [5158:1027:0314/154849.298291:5482468844055:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.298403:5482468930620:INFO:tcp_socket_unittest.cc(517)] Server starts reading kTestMsg from client.
[5158:1027:0314/154849.298525:5482469064612:INFO:tcp_socket_unittest.cc(523)] Client writes byte 0
[5158:1027:0314/154849.299115:5482469642604:INFO:tcp_socket_unittest.cc(523)] Client writes byte 1
[5158:1027:0314/154849.299621:5482470152545:INFO:tcp_socket_unittest.cc(523)] Client writes byte 2
[5158:1027:0314/154849.300123:5482470654347:INFO:tcp_socket_unittest.cc(523)] Client writes byte 3
[5158:1027:0314/154849.300549:5482471074245:INFO:tcp_socket_unittest.cc(523)] Client writes byte 4
[5158:1027:0314/154849.300944:5482471464308:INFO:tcp_socket_unittest.cc(523)] Client writes byte 5
[5158:1027:0314/154849.301337:5482471855405:INFO:tcp_socket_unittest.cc(523)] Client writes byte 6
[5158:1027:0314/154849.301744:5482472267082:INFO:tcp_socket_unittest.cc(523)] Client writes byte 7
[5158:1027:0314/154849.302171:5482472694207:INFO:tcp_socket_unittest.cc(523)] Client writes byte 8
[5158:1027:0314/154849.302595:5482473115576:INFO:tcp_socket_unittest.cc(523)] Client writes byte 9
[5158:1027:0314/154849.303002:5482473523587:INFO:tcp_socket_unittest.cc(523)] Client writes byte 10
[5158:1027:0314/154849.303417:5482473937255:INFO:tcp_socket_unittest.cc(523)] Client writes byte 11
[5158:1027:0314/154849.303806:5482474328122:INFO:tcp_socket_unittest.cc(530)] Waiting for server to receive entire msg
[5158:1027:0314/154849.303878:5482474402020:INFO:tcp_socket_unittest.cc(508)] Server sends 0 to client
[5158:1027:0314/154849.303994:5482474568967:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.304403:5482474926506:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.304472:5482474994135:INFO:tcp_socket_unittest.cc(508)] Server sends 1 to client
[5158:1027:0314/154849.304573:5482475166941:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.305044:5482475576330:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.305127:5482475656124:INFO:tcp_socket_unittest.cc(508)] Server sends 2 to client
[5158:1027:0314/154849.305246:5482475795403:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.305668:5482476199881:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.305751:5482476297727:INFO:tcp_socket_unittest.cc(508)] Server sends 3 to client
[5158:1027:0314/154849.305887:5482476417894:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.306282:5482477415514:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.306970:5482477495531:INFO:tcp_socket_unittest.cc(508)] Server sends 4 to client
[5158:1027:0314/154849.307090:5482477620446:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.307518:5482478095475:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.307651:5482478204911:INFO:tcp_socket_unittest.cc(508)] Server sends 5 to client
[5158:1027:0314/154849.307781:5482478307340:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.308126:5482478666303:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.308214:5482478732967:INFO:tcp_socket_unittest.cc(508)] Server sends 6 to client
[5158:1027:0314/154849.308307:5482478851628:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.308671:5482479203111:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.308758:5482479287079:INFO:tcp_socket_unittest.cc(508)] Server sends 7 to client
[5158:1027:0314/154849.308863:5482479403461:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.309195:5482479744134:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.309291:5482479812181:INFO:tcp_socket_unittest.cc(508)] Server sends 8 to client
[5158:1027:0314/154849.309385:5482479902688:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.309741:5482480289113:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.309846:5482480399004:INFO:tcp_socket_unittest.cc(508)] Server sends 9 to client
[5158:1027:0314/154849.309980:5482480504612:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.310328:5482480871579:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.310436:5482480951447:INFO:tcp_socket_unittest.cc(508)] Server sends 0 to client
[5158:1027:0314/154849.310528:5482481048986:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.310846:5482481378371:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.310935:5482481484670:INFO:tcp_socket_unittest.cc(508)] Server sends [5158:1027:0314/154849.311372:5482481898194:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.311449:5482481963410:INFO:tcp_socket_unittest.cc(517)] Server starts reading kTestMsg from client.
[5158:1027:0314/154849.311549:5482482084512:INFO:tcp_socket_unittest.cc(523)] Client writes byte 0
[5158:1027:0314/154849.311942:5482482507069:INFO:tcp_socket_unittest.cc(523)] Client writes byte 1
[5158:1027:0314/154849.312380:5482482937488:INFO:tcp_socket_unittest.cc(523)] Client writes byte 2
[5158:1027:0314/154849.312852:5482483379711:INFO:tcp_socket_unittest.cc(523)] Client writes byte 3
[5158:1027:0314/154849.313276:5482483833994:INFO:tcp_socket_unittest.cc(523)] Client writes byte 4
[5158:1027:0314/154849.313712:5482484293042:INFO:tcp_socket_unittest.cc(523)] Client writes byte 5
[5158:1027:0314/154849.314165:5482484721805:INFO:tcp_socket_unittest.cc(523)] Client writes byte 6
[5158:1027:0314/154849.314600:5482485181367:INFO:tcp_socket_unittest.cc(523)] Client writes byte 7
[5158:1027:0314/154849.315068:5482485625773:INFO:tcp_socket_unittest.cc(523)] Client writes byte 8
[5158:1027:0314/154849.315502:5482486059319:INFO:tcp_socket_unittest.cc(523)] Client writes byte 9
[5158:1027:0314/154849.315771:5482486291721:INFO:tcp_socket_unittest.cc(523)] Client writes byte 10
[5158:1027:0314/154849.316251:5482486832898:INFO:tcp_socket_unittest.cc(523)] Client writes byte 11
[5158:1027:0314/154849.316709:5482487266724:INFO:tcp_socket_unittest.cc(530)] Waiting for server to receive entire msg
[5158:1027:0314/154849.316837:5482487354913:INFO:tcp_socket_unittest.cc(508)] Server sends 0 to client
[5158:1027:0314/154849.316932:5482487451153:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.317300:5482487829023:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.317372:5482487886983:INFO:tcp_socket_unittest.cc(508)] Server sends 1 to client
[5158:1027:0314/154849.317458:5482487974808:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.317774:5482488301421:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.317849:5482488370165:INFO:tcp_socket_unittest.cc(508)] Server sends 2 to client
[5158:1027:0314/154849.317983:5482488500656:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.318284:5482488828525:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.318383:5482488900512:INFO:tcp_socket_unittest.cc(508)] Server sends 3 to client
[5158:1027:0314/154849.318477:5482488995909:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.318791:5482489338972:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.318910:5482489420572:INFO:tcp_socket_unittest.cc(508)] Server sends 4 to client
[5158:1027:0314/154849.318996:5482489515273:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.319307:5482489851655:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.319397:5482489917314:INFO:tcp_socket_unittest.cc(508)] Server sends 5 to client
[5158:1027:0314/154849.319488:5482490006530:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.319837:5482490369545:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.319916:5482490437967:INFO:tcp_socket_unittest.cc(508)] Server sends 6 to client
[5158:1027:0314/154849.320011:5482490532248:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.320339:5482490866553:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.320413:5482490929404:INFO:tcp_socket_unittest.cc(508)] Server sends 7 to client
[5158:1027:0314/154849.320509:5482491030686:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.320823:5482491374392:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.320940:5482491467945:INFO:tcp_socket_unittest.cc(508)] Server sends 8 to client
[5158:1027:0314/154849.321046:5482491569239:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.321355:5482491901954:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.321450:5482491970235:INFO:tcp_socket_unittest.cc(508)] Server sends 9 to client
[5158:1027:0314/154849.321539:5482492053795:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.321830:5482492382590:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.321925:5482492446002:INFO:tcp_socket_unittest.cc(508)] Server sends 0 to client
[5158:1027:0314/154849.322025:5482492542516:INFO:tcp_socket_unittest.cc(510)] Client reads from server...
[5158:1027:0314/154849.322340:5482492893555:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.322438:5482492954410:INFO:tcp_socket_unittest.cc(508)] Server sends [5158:1027:0314/154849.322843:5482493364348:INFO:tcp_socket_unittest.cc(512)] Client is done reading from server.
[5158:1027:0314/154849.322909:5482493434230:INFO:tcp_socket_unittest.cc(517)] Server starts reading kTestMsg from client.
[5158:1027:0314/154849.323013:5482493549960:INFO:tcp_socket_unittest.cc(523)] Client writes byte 0
[5158:1027:0314/154849.323451:5482493995170:INFO:tcp_socket_unittest.cc(523)] Client writes byte 1
[5158:1027:0314/154849.323867:5482494447651:INFO:tcp_socket_unittest.cc(523)] Client writes byte 2
[5158:1027:0314/154849.324327:5482494884680:INFO:tcp_socket_unittest.cc(523)] Client writes byte 3
[5158:1027:0314/154849.324766:5482495322933:INFO:tcp_socket_unittest.cc(523)] Client writes byte 4
[5158:1027:0314/154849.325198:5482495754909:INFO:tcp_socket_unittest.cc(523)] Client writes byte 5
[5158:1027:0314/154849.325631:5482496188546:INFO:tcp_socket_unittest.cc(523)] Client writes byte 6

Comment 7 by xunji...@chromium.org, Mar 15 2018

Cc: xunji...@chromium.org
 Issue 821232  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d867246f9c673d3ee39130eac6c7a5fe0dab6575

commit d867246f9c673d3ee39130eac6c7a5fe0dab6575
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Mar 15 16:10:12 2018

Reland: Add TCP socket API to network service

This CL adds TCP socket API to network service.
This is partly based on mandoline implementation
(https://codereview.chromium.org/1873463003/)

Two TCP socket interfaces are added.
- TCPConnectedSocket
- TCPServerSocket

Change in reland:
- Removes TCPSocketTest.ReadAndWriteMultiple because
  base::RunLoop().RunUntilIdle(), when used in conjunction with the rest of the
  test logic, times out sometimes on iOS bot. We have a better
  version of this test (ReadAndWriteMultipleWithMockClientSocket) written using
  mock sockets. See  crbug.com/822058 

R=mmenke@chromium.org
TBR=miu@chromium.org
TBR=tsepez@chromium.org

Bug:  721401 ,  822058 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I71cde7f2a16d022e888d62a6fec3d4fd5917b6e9
Reviewed-on: https://chromium-review.googlesource.com/964250
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543381}
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/media/cast/net/udp_socket_client_unittest.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/BUILD.gn
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/network_context.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/network_context.h
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/public/mojom/network_service.mojom
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/public/mojom/tcp_socket.mojom
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/socket_factory.cc
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/socket_factory.h
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_connected_socket.cc
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_connected_socket.h
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_server_socket.cc
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_server_socket.h
[add] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/tcp_socket_unittest.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/udp_socket.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/udp_socket.h
[delete] https://crrev.com/ef8a99cba301276aa64d628cd683be9c142e6335/services/network/udp_socket_factory.cc
[delete] https://crrev.com/ef8a99cba301276aa64d628cd683be9c142e6335/services/network/udp_socket_factory.h
[delete] https://crrev.com/ef8a99cba301276aa64d628cd683be9c142e6335/services/network/udp_socket_factory_unittest.cc
[modify] https://crrev.com/d867246f9c673d3ee39130eac6c7a5fe0dab6575/services/network/udp_socket_unittest.cc

Comment 9 by xunji...@chromium.org, Mar 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment