Dart gatekeeper emails broken |
||
Issue descriptionFYI, dart's email sending has been broken for at least a week, probably longer Getting this error in the server logs: build_step['urls'] is None I don't know if this is a misconfiguration on your part; I'll take a look.
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ede0a8c88d62622a25d5516c79fcd098de7b4e8d commit ede0a8c88d62622a25d5516c79fcd098de7b4e8d Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Mar 15 01:29:55 2018 gatekeeper: Handle milo giving inconsistent data It appears milo sometimes gives us different (roughly) empty values for urls for a step in a build. Sometimes it gives a "{}" and sometimes a "null". Dart builds somehow return null instead of {}, which means that the chromium_build app sees this (JS) null, which is converted to a python None, and gets confused. Additionally, change the default value to be a dict, since the mailer https://crrev.com/4abc8b9d659ea87b757239f418b0ced08f866b50/appengine/chromium_build/templates/waterfall_mail.html#36 seems to expect a dict. Bug: 822050 Change-Id: I6625d3b1f78ec1defc37de54112d525c2633bddd Reviewed-on: https://chromium-review.googlesource.com/963751 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org> [modify] https://crrev.com/ede0a8c88d62622a25d5516c79fcd098de7b4e8d/scripts/slave/unittests/gatekeeper_ng_test.py [modify] https://crrev.com/ede0a8c88d62622a25d5516c79fcd098de7b4e8d/scripts/slave/gatekeeper_ng.py
,
Mar 15 2018
The above seems to have fixed this. You'll probably be receiving emails, and you might not have been before. If it's too much, feel free to change your config at https://cs.chromium.org/chromium/build/scripts/slave/dart/gatekeeper_dart.json?q=gatekeeper_dart.js&sq=package:chromium&l=1 to fine tune the alerts. |
||
►
Sign in to add a comment |
||
Comment 1 by martiniss@chromium.org
, Mar 15 2018Ok, looks like the problem is that milo sometimes gives us different empty values for the "urls" field. Sometimes it gives {}, and sometimes null (in the JSON we got from milo). I'll change the code to be smarter about this.